Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1320155 > unrolled thread

[PATCH] media: Fix media_open() to clear filp->private_data in error leg

Started byShuah Khan <shuahkh@osg.samsung.com>
First post2016-01-28 00:50 +0100
Last post2016-01-28 01:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] media: Fix media_open() to clear filp->private_data in error leg Shuah Khan <shuahkh@osg.samsung.com> - 2016-01-28 00:50 +0100
    Re: [PATCH] media: Fix media_open() to clear filp->private_data in  error leg Sakari Ailus <sakari.ailus@iki.fi> - 2016-01-28 01:40 +0100

#1320155 — [PATCH] media: Fix media_open() to clear filp->private_data in error leg

FromShuah Khan <shuahkh@osg.samsung.com>
Date2016-01-28 00:50 +0100
Subject[PATCH] media: Fix media_open() to clear filp->private_data in error leg
Message-ID<qVI0y-2V1-23@gated-at.bofh.it>
Fix media_open() to clear filp->private_data when file open
fails.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 drivers/media/media-devnode.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/media-devnode.c b/drivers/media/media-devnode.c
index cea35bf..29409f4 100644
--- a/drivers/media/media-devnode.c
+++ b/drivers/media/media-devnode.c
@@ -181,6 +181,7 @@ static int media_open(struct inode *inode, struct file *filp)
 		ret = mdev->fops->open(filp);
 		if (ret) {
 			put_device(&mdev->dev);
+			filp->private_data = NULL;
 			return ret;
 		}
 	}
-- 
2.5.0

[toc] | [next] | [standalone]


#1320177 — Re: [PATCH] media: Fix media_open() to clear filp->private_data in error leg

FromSakari Ailus <sakari.ailus@iki.fi>
Date2016-01-28 01:40 +0100
SubjectRe: [PATCH] media: Fix media_open() to clear filp->private_data in error leg
Message-ID<qVIMW-3vP-27@gated-at.bofh.it>
In reply to#1320155
On Wed, Jan 27, 2016 at 04:49:33PM -0700, Shuah Khan wrote:
> Fix media_open() to clear filp->private_data when file open
> fails.
> 
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web