Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318947 > unrolled thread

Re: [PATCH v4 0/9] Add STM32 pinctrl/GPIO driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 0/9] Add STM32 pinctrl/GPIO driver Linus Walleij <linus.walleij@linaro.org> - 2016-01-27 14:30 +0100
    Re: [PATCH v4 0/9] Add STM32 pinctrl/GPIO driver Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-01-27 18:10 +0100
    Re: [PATCH v4 0/9] Add STM32 pinctrl/GPIO driver Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-01-27 22:00 +0100
      Re: [PATCH v4 0/9] Add STM32 pinctrl/GPIO driver Linus Walleij <linus.walleij@linaro.org> - 2016-02-06 00:00 +0100

#1318947 — Re: [PATCH v4 0/9] Add STM32 pinctrl/GPIO driver

On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin
<mcoquelin.stm32@gmail.com> wrote:

> This is the fourth round of STM32 pinctrl series, which takes into
> account comments made by Patrice on patch 4.

I have applied patch 2 and 4 to the pinctrl tree.

Please put the rest of the patches in through ARM SoC, you can
add my
Acked-by: Linus Walleij <linus.walleij@linaro.org>
to them.

AFAICT there is no compile-time dependency between these two
patches and the rest, so it should merge just fine.

Yours,
Linus Walleij

[toc] | [next] | [standalone]

#1319161

Hi Linus,

On 01/27/2016 02:20 PM, Linus Walleij wrote:
> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin
> <mcoquelin.stm32@gmail.com> wrote:
>
>> This is the fourth round of STM32 pinctrl series, which takes into
>> account comments made by Patrice on patch 4.
>
> I have applied patch 2 and 4 to the pinctrl tree.

Thanks a lot!
>
> Please put the rest of the patches in through ARM SoC, you can
> add my
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> to them.
>
> AFAICT there is no compile-time dependency between these two
> patches and the rest, so it should merge just fine.
Indeed, I confirm.

Regards,
Maxime

[toc] | [prev] | [next] | [standalone]

#1319808

On 01/27/2016 02:20 PM, Linus Walleij wrote:
> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin
> <mcoquelin.stm32@gmail.com>  wrote:
>
>> >This is the fourth round of STM32 pinctrl series, which takes into
>> >account comments made by Patrice on patch 4.
> I have applied patch 2 and 4 to the pinctrl tree.

Just tried to compile your devel branch, and it breaks:

   CC      drivers/pinctrl/stm32/pinctrl-stm32f429.o
drivers/pinctrl/stm32/pinctrl-stm32.c: In function 
'stm32_gpiolib_register_bank':
drivers/pinctrl/stm32/pinctrl-stm32.c:692:17: error: 'struct gpio_chip' 
has no member named 'dev'
   bank->gpio_chip.dev = dev;
                  ^
make[3]: *** [drivers/pinctrl/stm32/pinctrl-stm32.o] Error 1

This is due to the field renaming you did in gpio_chip struct:
58383c7 gpio: change member .dev to .parent

How do you prefer to proceed?
Should I send a fix on top of your devel branch, or you will fix it 
directly?

Thanks,
Maxime

[toc] | [prev] | [next] | [standalone]

#1328112

On Wed, Jan 27, 2016 at 9:59 PM, Maxime Coquelin
<mcoquelin.stm32@gmail.com> wrote:

> How do you prefer to proceed?
> Should I send a fix on top of your devel branch, or you will fix it
> directly?

I fixed it now and also got rid of the surplus container_of
static inline. Sorry for the delay.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web