Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1315730 > unrolled thread

[PATCH] um: use %lx format specifiers for unsigned longs

Back to article view | Back to linux.kernel

Contents

  [PATCH] um: use %lx format specifiers for unsigned longs Colin King <colin.king@canonical.com> - 2016-01-23 20:20 +0100
    Re: [PATCH] um: use %lx format specifiers for unsigned longs Richard Weinberger <richard@nod.at> - 2016-01-27 22:20 +0100

#1315730 — [PATCH] um: use %lx format specifiers for unsigned longs

From: Colin Ian King <colin.king@canonical.com>

static analysis from cppcheck detected %x being used for
unsigned longs:

[arch/x86/um/os-Linux/task_size.c:112]: (warning) %x in format
  string (no. 1) requires 'unsigned int' but the argument type
  is 'unsigned long'.

Use %lx instead of %x

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 arch/x86/um/os-Linux/task_size.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/um/os-Linux/task_size.c b/arch/x86/um/os-Linux/task_size.c
index 8502ad3..5adb6a2 100644
--- a/arch/x86/um/os-Linux/task_size.c
+++ b/arch/x86/um/os-Linux/task_size.c
@@ -109,7 +109,7 @@ unsigned long os_get_top_address(void)
 		exit(1);
 	}
 
-	printf("0x%x\n", bottom << UM_KERN_PAGE_SHIFT);
+	printf("0x%lx\n", bottom << UM_KERN_PAGE_SHIFT);
 	printf("Locating the top of the address space ... ");
 	fflush(stdout);
 
@@ -134,7 +134,7 @@ out:
 		exit(1);
 	}
 	top <<= UM_KERN_PAGE_SHIFT;
-	printf("0x%x\n", top);
+	printf("0x%lx\n", top);
 
 	return top;
 }
-- 
2.7.0.rc3

[toc] | [next] | [standalone]

#1319861

Am 23.01.2016 um 20:17 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
> 
> static analysis from cppcheck detected %x being used for
> unsigned longs:
> 
> [arch/x86/um/os-Linux/task_size.c:112]: (warning) %x in format
>   string (no. 1) requires 'unsigned int' but the argument type
>   is 'unsigned long'.
> 
> Use %lx instead of %x
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, Thanks!
//richard

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web