Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1319513 > unrolled thread

[PATCH] drivers/cpuidle: coupled: remove unused define cpuidle_coupled_lock

Started byAnders Roxell <anders.roxell@linaro.org>
First post2016-01-27 20:40 +0100
Last post2016-01-28 00:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] drivers/cpuidle: coupled: remove unused define cpuidle_coupled_lock Anders Roxell <anders.roxell@linaro.org> - 2016-01-27 20:40 +0100
    Re: [PATCH] drivers/cpuidle: coupled: remove unused define cpuidle_coupled_lock "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-28 00:00 +0100

#1319513 — [PATCH] drivers/cpuidle: coupled: remove unused define cpuidle_coupled_lock

FromAnders Roxell <anders.roxell@linaro.org>
Date2016-01-27 20:40 +0100
Subject[PATCH] drivers/cpuidle: coupled: remove unused define cpuidle_coupled_lock
Message-ID<qVE6E-8tR-57@gated-at.bofh.it>
This was found with the -RT patch enabled, but the fix should apply to
non-RT also.

Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
warning without this fix:
../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
defined but not used [-Wunused-variable]

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 drivers/cpuidle/coupled.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
index 344058f..d5657d5 100644
--- a/drivers/cpuidle/coupled.c
+++ b/drivers/cpuidle/coupled.c
@@ -119,7 +119,6 @@ struct cpuidle_coupled {
 
 #define CPUIDLE_COUPLED_NOT_IDLE	(-1)
 
-static DEFINE_MUTEX(cpuidle_coupled_lock);
 static DEFINE_PER_CPU(struct call_single_data, cpuidle_coupled_poke_cb);
 
 /*
-- 
2.1.4

[toc] | [next] | [standalone]


#1320097

From"Rafael J. Wysocki" <rjw@rjwysocki.net>
Date2016-01-28 00:00 +0100
Message-ID<qVHea-2ip-11@gated-at.bofh.it>
In reply to#1319513
On Wednesday, January 27, 2016 08:26:54 PM Anders Roxell wrote:
> This was found with the -RT patch enabled, but the fix should apply to
> non-RT also.
> 
> Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
> warning without this fix:
> ../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
> defined but not used [-Wunused-variable]
> 
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

Applied, thanks!

Rafael

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web