Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1316669 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2016-01-25 14:00 +0100 |
| Last post | 2016-01-26 07:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v5 1/5] doc: bindings: Add document for mfd hi665x PMIC Lee Jones <lee.jones@linaro.org> - 2016-01-25 14:00 +0100
Re: [PATCH v5 1/5] doc: bindings: Add document for mfd hi665x PMIC chenfeng <puck.chen@hisilicon.com> - 2016-01-26 07:30 +0100
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-01-25 14:00 +0100 |
| Subject | Re: [PATCH v5 1/5] doc: bindings: Add document for mfd hi665x PMIC |
| Message-ID | <qUOUq-40h-19@gated-at.bofh.it> |
On Mon, 11 Jan 2016, Chen Feng wrote:
> Add document for mfd driver hi655x pmic driver
>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> Signed-off-by: Fei Wang <w.f@huawei.com>
> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
> ---
> .../devicetree/bindings/mfd/hisilicon,hi655x.txt | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
> new file mode 100644
> index 0000000..3180c40
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
> @@ -0,0 +1,28 @@
> +Hisilicon hi655x Power Management Integrated Circuit (PMIC)
> +
> +The hardware layout for access PMIC Hi655x from AP SoC Hi6220.
> +Between PMIC Hi655x and Hi6220, the physical signal channel is SSI.
> +We can use memory-mapped I/O to communicate.
> +
> ++----------------+ +-------------+
> +| | | |
> +| Hi6220 | SSI bus | Hi655x |
> +| |-------------| |
> +| |(REGMAP_MMIO)| |
> ++----------------+ +-------------+
> +
> +Required properties:
> +- compatible: Should be "hisilicon,hi655x-pmic"
> +- reg: Base address of PMIC on hi6220 soc
SoC
> +- interrupt-controller: Hi655x has internal IRQs (has own IRQ domain).
> +- pmic-gpios: The gpio used by pmic irq.
PMIC IRQ
> +
> +Example:
> + pmic: pmic@f8000000 {
> + compatible = "hisilicon,hi655x-pmic";
> + reg = <0x0 0xf8000000 0x0 0x1000>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + pmic-gpios = <&gpio1 2 0>;
What's the last cell for here? If they are flags, there is probably a
#define you can use in dt-include.
> + status = "disabled";
What's the point in disabling example code?
> + }
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [next] | [standalone]
| From | chenfeng <puck.chen@hisilicon.com> |
|---|---|
| Date | 2016-01-26 07:30 +0100 |
| Message-ID | <qV5ix-7WO-1@gated-at.bofh.it> |
| In reply to | #1316669 |
On 2016/1/25 20:53, Lee Jones wrote:
> On Mon, 11 Jan 2016, Chen Feng wrote:
>
>> Add document for mfd driver hi655x pmic driver
>>
>> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
>> Signed-off-by: Fei Wang <w.f@huawei.com>
>> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>
>> ---
>> .../devicetree/bindings/mfd/hisilicon,hi655x.txt | 28 ++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>> new file mode 100644
>> index 0000000..3180c40
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>> @@ -0,0 +1,28 @@
>> +Hisilicon hi655x Power Management Integrated Circuit (PMIC)
>> +
>> +The hardware layout for access PMIC Hi655x from AP SoC Hi6220.
>> +Between PMIC Hi655x and Hi6220, the physical signal channel is SSI.
>> +We can use memory-mapped I/O to communicate.
>> +
>> ++----------------+ +-------------+
>> +| | | |
>> +| Hi6220 | SSI bus | Hi655x |
>> +| |-------------| |
>> +| |(REGMAP_MMIO)| |
>> ++----------------+ +-------------+
>> +
>> +Required properties:
>> +- compatible: Should be "hisilicon,hi655x-pmic"
>> +- reg: Base address of PMIC on hi6220 soc
>
> SoC
>
>> +- interrupt-controller: Hi655x has internal IRQs (has own IRQ domain).
>> +- pmic-gpios: The gpio used by pmic irq.
>
> PMIC IRQ
>
>> +
>> +Example:
>> + pmic: pmic@f8000000 {
>> + compatible = "hisilicon,hi655x-pmic";
>> + reg = <0x0 0xf8000000 0x0 0x1000>;
>> + #interrupt-cells = <2>;
>> + interrupt-controller;
>> + pmic-gpios = <&gpio1 2 0>;
>
> What's the last cell for here? If they are flags, there is probably a
> #define you can use in dt-include.
ok, I will use the irq flag in dt-include.
>
>> + status = "disabled";
>
> What's the point in disabling example code?
It's just copy from the dts, I will drop this.
>
>> + }
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web