Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1315731 > unrolled thread

[PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init()

Started byMasahiro Yamada <yamada.masahiro@socionext.com>
First post2016-01-23 20:30 +0100
Last post2016-01-27 21:30 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-23 20:30 +0100
    Re: [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init() Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-23 23:20 +0100
    Re: [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init() Linus Walleij <linus.walleij@linaro.org> - 2016-01-27 13:40 +0100
      Re: [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init() Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-27 21:30 +0100

#1315731 — [PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init()

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-01-23 20:30 +0100
Subject[PATCH] pinctrl: pxa: export pxa2xx_pinctrl_init()
Message-ID<qUc2J-7pM-1@gated-at.bofh.it>
Building pinctrl-pxa27x.c as a module causes a link error:

ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/pinctrl/pxa/pinctrl-pxa2xx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
index d90e205..216f227 100644
--- a/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
+++ b/drivers/pinctrl/pxa/pinctrl-pxa2xx.c
@@ -426,6 +426,7 @@ int pxa2xx_pinctrl_init(struct platform_device *pdev,
 
 	return 0;
 }
+EXPORT_SYMBOL(pxa2xx_pinctrl_init);
 
 int pxa2xx_pinctrl_exit(struct platform_device *pdev)
 {
-- 
1.9.1

[toc] | [next] | [standalone]


#1315766

FromRobert Jarzmik <robert.jarzmik@free.fr>
Date2016-01-23 23:20 +0100
Message-ID<qUeHf-3x3-3@gated-at.bofh.it>
In reply to#1315731
Masahiro Yamada <yamada.masahiro@socionext.com> writes:

> Building pinctrl-pxa27x.c as a module causes a link error:
>
> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Yeah, I see no other way out to spare namespace polution.

Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

Cheers.

-- 
Robert

[toc] | [prev] | [next] | [standalone]


#1318921

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-01-27 13:40 +0100
Message-ID<qVxyb-3tH-33@gated-at.bofh.it>
In reply to#1315731
On Sat, Jan 23, 2016 at 8:25 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> Building pinctrl-pxa27x.c as a module causes a link error:
>
> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied with Robert's ACK.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]


#1319699

FromRobert Jarzmik <robert.jarzmik@free.fr>
Date2016-01-27 21:30 +0100
Message-ID<qVET3-FR-81@gated-at.bofh.it>
In reply to#1318921
Linus Walleij <linus.walleij@linaro.org> writes:

> On Sat, Jan 23, 2016 at 8:25 PM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>
>> Building pinctrl-pxa27x.c as a module causes a link error:
>>
>> ERROR: "pxa2xx_pinctrl_init" [drivers/pinctrl/pxa/pinctrl-pxa27x.ko] undefined!
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Patch applied with Robert's ACK.
Thanks Linus.

Cheers.

-- 
Robert

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web