Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316956 > unrolled thread

Re: 3.14 stable regression don't remove from shrink list in select_collect()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: 3.14 stable regression don't remove from shrink list in  select_collect() Jason Baron <jbaron@akamai.com> - 2016-01-25 17:30 +0100
    Re: 3.14 stable regression don't remove from shrink list in  select_collect() Guillaume Morin <guillaume@morinfr.org> - 2016-01-25 18:10 +0100

#1316956 — Re: 3.14 stable regression don't remove from shrink list in select_collect()

On 01/25/2016 11:05 AM, Shawn Bohrer wrote:
> I recently updated some machines to 3.14.58 and they reliably get soft
> lockups.  Sometimes the soft lockup recovers and some times it does
> not.  I've bisected this on the 3.14 stable branch and arrived at:
> 
> c214cb82cdc744225d85899fc138251527f75fff don't remove from shrink
> list in select_collect()
> 
> Reverting this commit plus adding back dentry_lru_del() which was
> removed later on top of 3.14.58 resolves the issue for me.  I've
> included a patch at the bottom with the revert.
> 

I ran into this too on 3.14. You can revert these patches as you've done
or backport the upstream fixes mentioned here:

http://www.spinics.net/lists/stable/msg111544.html

I don't see these fixes queued yet to 3.14, but I may be missing something.

Thanks,

-Jason

[toc] | [next] | [standalone]

#1317066

On 25 Jan 11:25, Jason Baron wrote:
>
> On 01/25/2016 11:05 AM, Shawn Bohrer wrote:
> > I recently updated some machines to 3.14.58 and they reliably get soft
> > lockups.  Sometimes the soft lockup recovers and some times it does
> > not.  I've bisected this on the 3.14 stable branch and arrived at:
> > 
> > c214cb82cdc744225d85899fc138251527f75fff don't remove from shrink
> > list in select_collect()
> > 
> > Reverting this commit plus adding back dentry_lru_del() which was
> > removed later on top of 3.14.58 resolves the issue for me.  I've
> > included a patch at the bottom with the revert.
> 
> I ran into this too on 3.14. You can revert these patches as you've done
> or backport the upstream fixes mentioned here:
> 
> http://www.spinics.net/lists/stable/msg111544.html

I actually messed up the commit ids in that message, the fixed list is
here:
http://www.spinics.net/lists/stable/msg111553.html

-- 
Guillaume Morin <guillaume@morinfr.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web