Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1316537 > unrolled thread

Re: [PATCH] usb: option.c: Fix Cinterion AHxx enumeration.

Started byJohan Hovold <johan@kernel.org>
First post2016-01-25 12:50 +0100
Last post2016-01-25 12:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] usb: option.c: Fix Cinterion AHxx enumeration. Johan Hovold <johan@kernel.org> - 2016-01-25 12:50 +0100
    Re: [PATCH] usb: option.c: Fix Cinterion AHxx enumeration. John Ernberg <john.ernberg@actia.se> - 2016-01-25 12:50 +0100

#1316537 — Re: [PATCH] usb: option.c: Fix Cinterion AHxx enumeration.

FromJohan Hovold <johan@kernel.org>
Date2016-01-25 12:50 +0100
SubjectRe: [PATCH] usb: option.c: Fix Cinterion AHxx enumeration.
Message-ID<qUNOG-3ga-21@gated-at.bofh.it>
[ Please avoid top-posting. ]

On Thu, Jan 07, 2016 at 08:52:38AM +0000, John Ernberg wrote:
> Hi Johan,
> 
> Apologies for the late reply, I was out of office.
> 
> Below is the 'lsusb -v' output for the AH3 modem.

Thanks for the info. I believe your fix is the right one, but it seems
you forgot to sign-off on it (see Documentation/SubmittingPatches).

You could also replace the dmesg output in the commit message with for
example the more compact usb-devices output for your device when
resending.

Thanks,
Johan

[toc] | [next] | [standalone]


#1316543

FromJohn Ernberg <john.ernberg@actia.se>
Date2016-01-25 12:50 +0100
Message-ID<qUNOH-3ga-37@gated-at.bofh.it>
In reply to#1316537

On 01/25/2016 12:44 PM, Johan Hovold wrote:
> [ Please avoid top-posting. ]
>
> On Thu, Jan 07, 2016 at 08:52:38AM +0000, John Ernberg wrote:
>> Hi Johan,
>>
>> Apologies for the late reply, I was out of office.
>>
>> Below is the 'lsusb -v' output for the AH3 modem.
> Thanks for the info. I believe your fix is the right one, but it seems
> you forgot to sign-off on it (see Documentation/SubmittingPatches).
>
> You could also replace the dmesg output in the commit message with for
> example the more compact usb-devices output for your device when
> resending.
>
> Thanks,
> Johan
Hi Johan,

Apologies for the top posting.
I will send in a v2 with the fixed commit message during the week.
Thank you for the review.

Best regards // John Ernberg

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web