Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1316264 > unrolled thread
| Started by | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| First post | 2016-01-25 08:40 +0100 |
| Last post | 2016-01-25 11:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ARM64: rk3368: add tuning clk for emmc and sdmmc Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-25 08:40 +0100
Re: [PATCH] ARM64: rk3368: add tuning clk for emmc and sdmmc Heiko Stübner <heiko@sntech.de> - 2016-01-25 11:40 +0100
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2016-01-25 08:40 +0100 |
| Subject | [PATCH] ARM64: rk3368: add tuning clk for emmc and sdmmc |
| Message-ID | <qUJUJ-zs-7@gated-at.bofh.it> |
Add tuning clk for emmc and sdmmc, otherwise I get the following failure while enabling mmc-hs200-1_8v. dwmmc_rockchip ff0f0000.dwmmc: Tuning clock (sample_clk) not defined. mmc0: tuning execution failed mmc0: error -5 whilst initialising MMC card With it dwmmc_rockchip ff0f0000.dwmmc: Successfully tuned phase to 170 mmc0: new HS200 MMC card at address 0001 mmcblk0: mmc0:0001 M8G1GC 7.28 GiB Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3368.dtsi | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index 122777b..1cf3cf7 100644 --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi @@ -231,8 +231,9 @@ compatible = "rockchip,rk3368-dw-mshc", "rockchip,rk3288-dw-mshc"; reg = <0x0 0xff0c0000 0x0 0x4000>; clock-freq-min-max = <400000 150000000>; - clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>; - clock-names = "biu", "ciu"; + clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>, + <&cru SCLK_SDMMC_DRV>, <&cru SCLK_SDMMC_SAMPLE>; + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; fifo-depth = <0x100>; interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; @@ -256,6 +257,9 @@ clock-freq-min-max = <400000 150000000>; clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>; clock-names = "biu", "ciu"; + clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>, + <&cru SCLK_EMMC_DRV>, <&cru SCLK_EMMC_SAMPLE>; + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; fifo-depth = <0x100>; interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; -- 2.3.7
[toc] | [next] | [standalone]
| From | Heiko Stübner <heiko@sntech.de> |
|---|---|
| Date | 2016-01-25 11:40 +0100 |
| Message-ID | <qUMIV-2z3-3@gated-at.bofh.it> |
| In reply to | #1316264 |
Hi Shawn, Am Montag, 25. Januar 2016, 15:33:43 schrieb Shawn Lin: > Add tuning clk for emmc and sdmmc, otherwise I get > the following failure while enabling mmc-hs200-1_8v. > > dwmmc_rockchip ff0f0000.dwmmc: Tuning clock (sample_clk) not defined. > mmc0: tuning execution failed > mmc0: error -5 whilst initialising MMC card > > With it > dwmmc_rockchip ff0f0000.dwmmc: Successfully tuned phase to 170 > mmc0: new HS200 MMC card at address 0001 > mmcblk0: mmc0:0001 M8G1GC 7.28 GiB > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> applied to my dts64 branch for 4.6 I've adapted the subject to arm64: dts: rockchip: add rk3368 tuning clk for emmc and sdmmc to follow the format used there (it doesn't seem 100% consistent between socs) > clock-freq-min-max = <400000 150000000>; > clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>; > clock-names = "biu", "ciu"; > + clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>, > + <&cru SCLK_EMMC_DRV>, <&cru SCLK_EMMC_SAMPLE>; > + clock-names = "biu", "ciu", "ciu-drive", "ciu-sample"; > fifo-depth = <0x100>; > interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; I've also removed the duplicate clock entry here ;-) Heiko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web