Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314576 > unrolled thread

[PATCH v5 0/4] Add device tree support to the cyttsp driver

Back to article view | Back to linux.kernel

Contents

  [PATCH v5 0/4] Add device tree support to the cyttsp driver Oreste Salerno <oreste.salerno@tomtom.com> - 2016-01-21 23:30 +0100
    [PATCH v5 4/4] Input: cyttsp - perform hard reset of the chip during probe Oreste Salerno <oreste.salerno@tomtom.com> - 2016-01-21 23:30 +0100

#1314576 — [PATCH v5 0/4] Add device tree support to the cyttsp driver

Implement a number of updates for the cyttsp driver to be able to parse generic
ACPI/of/static properties and drop support for platform data (no platform data
user is present in the kernel tree).

---
Changes in v5:
  Use custom devm action to turn off the chip
  Make reset gpio and touchscreen size properties optional
Changes in v4:
  Major rework based on Dmitry's review:
  - Use device_property_read() functions instead of of_property()
  - Use touchscreen_parse_properties to parse common properties
  - Drop support for platform data
  - Used devres managed allocations
Changes in v3:
  - Rework binding names and descriptions
Changes in v2:
  - Fix err_cast.cocci warning in patch 2/3
Oreste Salerno (4):
  Input: cyttsp - use devres managed resource allocations
  Input: cyttsp - check return value of input_mt_init_slots
  Input: cyttsp - switch to using device properties
  Input: cyttsp - perform hard reset of the chip during probe

 .../bindings/input/touchscreen/cyttsp.txt          |  95 ++++++++++
 drivers/input/touchscreen/cyttsp_core.c            | 193 +++++++++++++--------
 drivers/input/touchscreen/cyttsp_core.h            |  10 +-
 drivers/input/touchscreen/cyttsp_i2c.c             |  10 --
 drivers/input/touchscreen/cyttsp_spi.c             |  10 --
 include/linux/input/cyttsp.h                       |  15 --
 6 files changed, 228 insertions(+), 105 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cyttsp.txt

-- 
1.9.1

[toc] | [next] | [standalone]

#1314578 — [PATCH v5 4/4] Input: cyttsp - perform hard reset of the chip during probe

Since we removed support for calling an init() callback from
the platform data, introduce a function which initializes
the chip by performing a hard reset, using the reset gpio
defined in the device properties.

Signed-off-by: Oreste Salerno <oreste.salerno@tomtom.com>
---
 drivers/input/touchscreen/cyttsp_core.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index d91668d..0fd0956 100644
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c
@@ -240,6 +240,16 @@ static int cyttsp_set_sysinfo_regs(struct cyttsp *ts)
 	return retval;
 }
 
+static void cyttsp_hard_reset(struct cyttsp *ts)
+{
+	if (ts->reset_gpio) {
+		gpiod_set_value_cansleep(ts->reset_gpio, 1);
+		msleep(CY_DELAY_DFLT);
+		gpiod_set_value_cansleep(ts->reset_gpio, 0);
+		msleep(CY_DELAY_DFLT);
+	}
+}
+
 static int cyttsp_soft_reset(struct cyttsp *ts)
 {
 	unsigned long timeout;
@@ -663,6 +673,8 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
 
 	disable_irq(ts->irq);
 
+	cyttsp_hard_reset(ts);
+
 	error = cyttsp_power_on(ts);
 	if (error)
 		return ERR_PTR(error);
-- 
1.9.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web