Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314346 > unrolled thread

Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

Started byHelmut Schaa <helmut.schaa@googlemail.com>
First post2016-01-21 18:00 +0100
Last post2016-01-21 18:20 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues Helmut Schaa <helmut.schaa@googlemail.com> - 2016-01-21 18:00 +0100
    Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues Helmut Schaa <helmut.schaa@googlemail.com> - 2016-01-21 18:10 +0100
      Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues Kalle Valo <kvalo@codeaurora.org> - 2016-01-21 18:20 +0100

#1314346 — Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

FromHelmut Schaa <helmut.schaa@googlemail.com>
Date2016-01-21 18:00 +0100
SubjectRe: [PATCH] net: wireless: rt2x00: Fixed Spacing issues
Message-ID<qTqKu-7ZR-23@gated-at.bofh.it>
On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <paulmcquad@gmail.com> wrote:
> Removed empty spaces before/after parenthesis
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>

Just noticed these did not get applied by Kalle yet.

Looks good to me.

Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>

> ---
>  drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt61pci.h b/drivers/net/wireless/rt2x00/rt61pci.h
> index 1442075..ab86415 100644
> --- a/drivers/net/wireless/rt2x00/rt61pci.h
> +++ b/drivers/net/wireless/rt2x00/rt61pci.h
> @@ -138,14 +138,14 @@
>  #define PAIRWISE_TA_TABLE_BASE         0x1a00
>
>  #define SHARED_KEY_ENTRY(__idx) \
> -       ( SHARED_KEY_TABLE_BASE + \
> -               ((__idx) * sizeof(struct hw_key_entry)) )
> +       (SHARED_KEY_TABLE_BASE + \
> +               ((__idx) * sizeof(struct hw_key_entry)))
>  #define PAIRWISE_KEY_ENTRY(__idx) \
> -       ( PAIRWISE_KEY_TABLE_BASE + \
> -               ((__idx) * sizeof(struct hw_key_entry)) )
> +       (PAIRWISE_KEY_TABLE_BASE + \
> +               ((__idx) * sizeof(struct hw_key_entry)))
>  #define PAIRWISE_TA_ENTRY(__idx) \
> -       ( PAIRWISE_TA_TABLE_BASE + \
> -               ((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
> +       (PAIRWISE_TA_TABLE_BASE + \
> +               ((__idx) * sizeof(struct hw_pairwise_ta_entry)))
>
>  struct hw_key_entry {
>         u8 key[16];
> @@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
>  #define HW_BEACON_BASE3                        0x2f00
>
>  #define HW_BEACON_OFFSET(__index) \
> -       ( HW_BEACON_BASE0 + (__index * 0x0100) )
> +       (HW_BEACON_BASE0 + (__index * 0x0100))
>
>  /*
>   * HOST-MCU shared memory.
> @@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
>  /*
>   * DMA descriptor defines.
>   */
> -#define TXD_DESC_SIZE                  ( 16 * sizeof(__le32) )
> -#define TXINFO_SIZE                    ( 6 * sizeof(__le32) )
> -#define RXD_DESC_SIZE                  ( 16 * sizeof(__le32) )
> +#define TXD_DESC_SIZE                  (16 * sizeof(__le32))
> +#define TXINFO_SIZE                    (6 * sizeof(__le32))
> +#define RXD_DESC_SIZE                  (16 * sizeof(__le32))
>
>  /*
>   * TX descriptor format for TX, PRIO and Beacon Ring.
> --
> 2.6.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [next] | [standalone]

#1314359

FromHelmut Schaa <helmut.schaa@googlemail.com>
Date2016-01-21 18:10 +0100
Message-ID<qTqUb-8kQ-43@gated-at.bofh.it>
In reply to#1314346
On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa
<helmut.schaa@googlemail.com> wrote:
> On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <paulmcquad@gmail.com> wrote:
>> Removed empty spaces before/after parenthesis
>>
>> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
>
> Just noticed these did not get applied by Kalle yet.

Kalle, can you fix up the path (ralink/rt2x00 instead of rt2x00) when applying?
Or would you prefer Paul to respin the whole code style cleanup series?

Thanks,
Helmut

> Looks good to me.
>
> Acked-by: Helmut Schaa <helmut.schaa@googlemail.com>
>
>> ---
>>  drivers/net/wireless/rt2x00/rt61pci.h | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rt2x00/rt61pci.h b/drivers/net/wireless/rt2x00/rt61pci.h
>> index 1442075..ab86415 100644
>> --- a/drivers/net/wireless/rt2x00/rt61pci.h
>> +++ b/drivers/net/wireless/rt2x00/rt61pci.h
>> @@ -138,14 +138,14 @@
>>  #define PAIRWISE_TA_TABLE_BASE         0x1a00
>>
>>  #define SHARED_KEY_ENTRY(__idx) \
>> -       ( SHARED_KEY_TABLE_BASE + \
>> -               ((__idx) * sizeof(struct hw_key_entry)) )
>> +       (SHARED_KEY_TABLE_BASE + \
>> +               ((__idx) * sizeof(struct hw_key_entry)))
>>  #define PAIRWISE_KEY_ENTRY(__idx) \
>> -       ( PAIRWISE_KEY_TABLE_BASE + \
>> -               ((__idx) * sizeof(struct hw_key_entry)) )
>> +       (PAIRWISE_KEY_TABLE_BASE + \
>> +               ((__idx) * sizeof(struct hw_key_entry)))
>>  #define PAIRWISE_TA_ENTRY(__idx) \
>> -       ( PAIRWISE_TA_TABLE_BASE + \
>> -               ((__idx) * sizeof(struct hw_pairwise_ta_entry)) )
>> +       (PAIRWISE_TA_TABLE_BASE + \
>> +               ((__idx) * sizeof(struct hw_pairwise_ta_entry)))
>>
>>  struct hw_key_entry {
>>         u8 key[16];
>> @@ -180,7 +180,7 @@ struct hw_pairwise_ta_entry {
>>  #define HW_BEACON_BASE3                        0x2f00
>>
>>  #define HW_BEACON_OFFSET(__index) \
>> -       ( HW_BEACON_BASE0 + (__index * 0x0100) )
>> +       (HW_BEACON_BASE0 + (__index * 0x0100))
>>
>>  /*
>>   * HOST-MCU shared memory.
>> @@ -1287,9 +1287,9 @@ struct hw_pairwise_ta_entry {
>>  /*
>>   * DMA descriptor defines.
>>   */
>> -#define TXD_DESC_SIZE                  ( 16 * sizeof(__le32) )
>> -#define TXINFO_SIZE                    ( 6 * sizeof(__le32) )
>> -#define RXD_DESC_SIZE                  ( 16 * sizeof(__le32) )
>> +#define TXD_DESC_SIZE                  (16 * sizeof(__le32))
>> +#define TXINFO_SIZE                    (6 * sizeof(__le32))
>> +#define RXD_DESC_SIZE                  (16 * sizeof(__le32))
>>
>>  /*
>>   * TX descriptor format for TX, PRIO and Beacon Ring.
>> --
>> 2.6.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1314367

FromKalle Valo <kvalo@codeaurora.org>
Date2016-01-21 18:20 +0100
Message-ID<qTr3R-8oL-41@gated-at.bofh.it>
In reply to#1314359
Helmut Schaa <helmut.schaa@googlemail.com> writes:

> On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa
> <helmut.schaa@googlemail.com> wrote:
>> On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <paulmcquad@gmail.com> wrote:
>>> Removed empty spaces before/after parenthesis
>>>
>>> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
>>
>> Just noticed these did not get applied by Kalle yet.
>
> Kalle, can you fix up the path (ralink/rt2x00 instead of rt2x00) when applying?
> Or would you prefer Paul to respin the whole code style cleanup series?

Actually git should be manage that automatically, it's so awesome :)

I can also fix the title and remove the unnecessary "net: wireless:"
prefix.


-- 
Kalle Valo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web