Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314126 > unrolled thread

Re: [PATCH] 8250: uniphier: allow modular build with 8250 console

Started byMasahiro Yamada <yamada.masahiro@socionext.com>
First post2016-01-21 12:40 +0100
Last post2016-01-26 02:50 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] 8250: uniphier: allow modular build with 8250 console Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-21 12:40 +0100
    Re: [PATCH] 8250: uniphier: allow modular build with 8250 console Arnd Bergmann <arnd@arndb.de> - 2016-01-21 13:30 +0100
      Re: [PATCH] 8250: uniphier: allow modular build with 8250 console Rob Herring <robh+dt@kernel.org> - 2016-01-21 15:10 +0100
        Re: [PATCH] 8250: uniphier: allow modular build with 8250 console Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-21 18:00 +0100
          Re: [PATCH] 8250: uniphier: allow modular build with 8250 console Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-26 02:50 +0100

#1314126 — Re: [PATCH] 8250: uniphier: allow modular build with 8250 console

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-01-21 12:40 +0100
SubjectRe: [PATCH] 8250: uniphier: allow modular build with 8250 console
Message-ID<qTlKP-4CC-23@gated-at.bofh.it>
Hi Arnd,


2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The recently added uniphier 8250 port driver supports early console
> probing, and it supports being built as a module, but the combination
> of the two fails to link:
>
> ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>
> Given that earlycon support in a loadable module makes no sense,
> making that code conditional on 'MODULE' is a correct solution.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
>
> diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
> index bab6b3ae2540..1b7bd26555b7 100644
> --- a/drivers/tty/serial/8250/8250_uniphier.c
> +++ b/drivers/tty/serial/8250/8250_uniphier.c
> @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>         spinlock_t atomic_write_lock;
>  };
>
> -#ifdef CONFIG_SERIAL_8250_CONSOLE
> +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>  static int __init uniphier_early_console_setup(struct earlycon_device *device,
>                                                const char *options)
>  {
>
>


If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
this build error will be fixed as well.  But I doubt it is accepted soon...

So, I am OK with this workaround to fix "make allmodconfig".

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>



-- 
Best Regards
Masahiro Yamada

[toc] | [next] | [standalone]

#1314155

FromArnd Bergmann <arnd@arndb.de>
Date2016-01-21 13:30 +0100
Message-ID<qTmxd-5b1-23@gated-at.bofh.it>
In reply to#1314126
On Thursday 21 January 2016 20:39:03 Masahiro Yamada wrote:
> 2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> > The recently added uniphier 8250 port driver supports early console
> > probing, and it supports being built as a module, but the combination
> > of the two fails to link:
> >
> > ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
> >
> > Given that earlycon support in a loadable module makes no sense,
> > making that code conditional on 'MODULE' is a correct solution.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
> >
> > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
> > index bab6b3ae2540..1b7bd26555b7 100644
> > --- a/drivers/tty/serial/8250/8250_uniphier.c
> > +++ b/drivers/tty/serial/8250/8250_uniphier.c
> > @@ -35,7 +35,7 @@ struct uniphier8250_priv {
> >         spinlock_t atomic_write_lock;
> >  };
> >
> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
> >  static int __init uniphier_early_console_setup(struct earlycon_device *device,
> >                                                const char *options)
> >  {
> >
> >
> 
> 
> If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
> this build error will be fixed as well.  But I doubt it is accepted soon...
> 
> So, I am OK with this workaround to fix "make allmodconfig".
> 
> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> 

Good point. Adding the DT maintainers to Cc. Guys, any chance of you
picking up Masahiro's patch for 4.5?

It can't hurt to have both patches merged, so it would still be good
to have mine in the serial driver fixes, but we can live with either
of the two to fix the build.

	Arnd

[toc] | [prev] | [next] | [standalone]

#1314216

FromRob Herring <robh+dt@kernel.org>
Date2016-01-21 15:10 +0100
Message-ID<qTo5Z-6jn-15@gated-at.bofh.it>
In reply to#1314155
On Thu, Jan 21, 2016 at 6:21 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 21 January 2016 20:39:03 Masahiro Yamada wrote:
>> 2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>> > The recently added uniphier 8250 port driver supports early console
>> > probing, and it supports being built as a module, but the combination
>> > of the two fails to link:
>> >
>> > ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>> >
>> > Given that earlycon support in a loadable module makes no sense,
>> > making that code conditional on 'MODULE' is a correct solution.
>> >
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> > Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
>> >
>> > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
>> > index bab6b3ae2540..1b7bd26555b7 100644
>> > --- a/drivers/tty/serial/8250/8250_uniphier.c
>> > +++ b/drivers/tty/serial/8250/8250_uniphier.c
>> > @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>> >         spinlock_t atomic_write_lock;
>> >  };
>> >
>> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
>> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>> >  static int __init uniphier_early_console_setup(struct earlycon_device *device,
>> >                                                const char *options)
>> >  {
>> >
>> >
>>
>>
>> If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
>> this build error will be fixed as well.  But I doubt it is accepted soon...
>>
>> So, I am OK with this workaround to fix "make allmodconfig".
>>
>> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>
>
> Good point. Adding the DT maintainers to Cc. Guys, any chance of you
> picking up Masahiro's patch for 4.5?

I will if you can update the commit log with the details here about it
fixing an actual problem.

Rob

[toc] | [prev] | [next] | [standalone]

#1314351

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-01-21 18:00 +0100
Message-ID<qTqKv-7ZR-37@gated-at.bofh.it>
In reply to#1314216
Hi Rob.


2016-01-21 23:09 GMT+09:00 Rob Herring <robh+dt@kernel.org>:
> On Thu, Jan 21, 2016 at 6:21 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Thursday 21 January 2016 20:39:03 Masahiro Yamada wrote:
>>> 2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>>> > The recently added uniphier 8250 port driver supports early console
>>> > probing, and it supports being built as a module, but the combination
>>> > of the two fails to link:
>>> >
>>> > ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>>> >
>>> > Given that earlycon support in a loadable module makes no sense,
>>> > making that code conditional on 'MODULE' is a correct solution.
>>> >
>>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> > Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
>>> >
>>> > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
>>> > index bab6b3ae2540..1b7bd26555b7 100644
>>> > --- a/drivers/tty/serial/8250/8250_uniphier.c
>>> > +++ b/drivers/tty/serial/8250/8250_uniphier.c
>>> > @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>>> >         spinlock_t atomic_write_lock;
>>> >  };
>>> >
>>> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
>>> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>>> >  static int __init uniphier_early_console_setup(struct earlycon_device *device,
>>> >                                                const char *options)
>>> >  {
>>> >
>>> >
>>>
>>>
>>> If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
>>> this build error will be fixed as well.  But I doubt it is accepted soon...
>>>
>>> So, I am OK with this workaround to fix "make allmodconfig".
>>>
>>> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>>
>>
>> Good point. Adding the DT maintainers to Cc. Guys, any chance of you
>> picking up Masahiro's patch for 4.5?
>
> I will if you can update the commit log with the details here about it
> fixing an actual problem.

I did so in v2.

Thanks!




-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#1317454

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-01-26 02:50 +0100
Message-ID<qV0VA-4hz-11@gated-at.bofh.it>
In reply to#1314351
Just for clarification:

The build error was fixed by another patch
(https://patchwork.kernel.org/patch/8082931/)

So, this one is unneeded.



2016-01-22 1:50 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Hi Rob.
>
>
> 2016-01-21 23:09 GMT+09:00 Rob Herring <robh+dt@kernel.org>:
>> On Thu, Jan 21, 2016 at 6:21 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Thursday 21 January 2016 20:39:03 Masahiro Yamada wrote:
>>>> 2016-01-14 7:33 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
>>>> > The recently added uniphier 8250 port driver supports early console
>>>> > probing, and it supports being built as a module, but the combination
>>>> > of the two fails to link:
>>>> >
>>>> > ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined!
>>>> >
>>>> > Given that earlycon support in a loadable module makes no sense,
>>>> > making that code conditional on 'MODULE' is a correct solution.
>>>> >
>>>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>>> > Fixes: b8d20e06eaad ("serial: 8250_uniphier: add earlycon support")
>>>> >
>>>> > diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c
>>>> > index bab6b3ae2540..1b7bd26555b7 100644
>>>> > --- a/drivers/tty/serial/8250/8250_uniphier.c
>>>> > +++ b/drivers/tty/serial/8250/8250_uniphier.c
>>>> > @@ -35,7 +35,7 @@ struct uniphier8250_priv {
>>>> >         spinlock_t atomic_write_lock;
>>>> >  };
>>>> >
>>>> > -#ifdef CONFIG_SERIAL_8250_CONSOLE
>>>> > +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
>>>> >  static int __init uniphier_early_console_setup(struct earlycon_device *device,
>>>> >                                                const char *options)
>>>> >  {
>>>> >
>>>> >
>>>>
>>>>
>>>> If my patch (https://patchwork.kernel.org/patch/8029331/) is accepted,
>>>> this build error will be fixed as well.  But I doubt it is accepted soon...
>>>>
>>>> So, I am OK with this workaround to fix "make allmodconfig".
>>>>
>>>> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>>>
>>>
>>> Good point. Adding the DT maintainers to Cc. Guys, any chance of you
>>> picking up Masahiro's patch for 4.5?
>>
>> I will if you can update the commit log with the details here about it
>> fixing an actual problem.
>
> I did so in v2.
>
> Thanks!
>
>
>
>
> --
> Best Regards
> Masahiro Yamada



-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web