Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1313127 > unrolled thread

[PATCH] IMA: fix non-ANSI declaration of ima_check_policy()

Started byColin King <colin.king@canonical.com>
First post2016-01-20 12:20 +0100
Last post2016-01-21 14:30 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] IMA: fix non-ANSI declaration of ima_check_policy() Colin King <colin.king@canonical.com> - 2016-01-20 12:20 +0100
    Re: [PATCH] IMA: fix non-ANSI declaration of ima_check_policy() Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-01-21 14:30 +0100

#1313127 — [PATCH] IMA: fix non-ANSI declaration of ima_check_policy()

FromColin King <colin.king@canonical.com>
Date2016-01-20 12:20 +0100
Subject[PATCH] IMA: fix non-ANSI declaration of ima_check_policy()
Message-ID<qSYXT-5Aj-5@gated-at.bofh.it>
From: Colin Ian King <colin.king@canonical.com>

ima_check_policy() has no parameters, so use the normal void
parameter convention to make it match the prototype in the header file
security/integrity/ima/ima.h

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 security/integrity/ima/ima_policy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
index 0a3b781..e0e18cc 100644
--- a/security/integrity/ima/ima_policy.c
+++ b/security/integrity/ima/ima_policy.c
@@ -417,7 +417,7 @@ void __init ima_init_policy(void)
 }
 
 /* Make sure we have a valid policy, at least containing some rules. */
-int ima_check_policy()
+int ima_check_policy(void)
 {
 	if (list_empty(&ima_temp_rules))
 		return -EINVAL;
-- 
2.7.0.rc3

[toc] | [next] | [standalone]


#1314193

FromMimi Zohar <zohar@linux.vnet.ibm.com>
Date2016-01-21 14:30 +0100
Message-ID<qTntg-5NW-11@gated-at.bofh.it>
In reply to#1313127
On Wed, 2016-01-20 at 11:13 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> ima_check_policy() has no parameters, so use the normal void
> parameter convention to make it match the prototype in the header file
> security/integrity/ima/ima.h
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thank you.

Mimi

> ---
>  security/integrity/ima/ima_policy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
> index 0a3b781..e0e18cc 100644
> --- a/security/integrity/ima/ima_policy.c
> +++ b/security/integrity/ima/ima_policy.c
> @@ -417,7 +417,7 @@ void __init ima_init_policy(void)
>  }
> 
>  /* Make sure we have a valid policy, at least containing some rules. */
> -int ima_check_policy()
> +int ima_check_policy(void)
>  {
>  	if (list_empty(&ima_temp_rules))
>  		return -EINVAL;

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web