Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314009 > unrolled thread

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence  mode configuration Pali Rohár <pali.rohar@gmail.com> - 2016-01-21 10:00 +0100
    Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration Kalle Valo <kvalo@codeaurora.org> - 2016-01-21 14:50 +0100
      Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence  mode configuration Pali Rohár <pali.rohar@gmail.com> - 2016-01-21 15:00 +0100
        Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration Kalle Valo <kvalo@codeaurora.org> - 2016-01-21 15:50 +0100
          Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence  mode configuration Pali Rohár <pali.rohar@gmail.com> - 2016-01-22 10:30 +0100
            Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration Kalle Valo <kvalo@codeaurora.org> - 2016-01-22 13:00 +0100

#1314009 — Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

On Thursday 14 January 2016 10:16:54 Pavel Machek wrote:
> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote:
> > On 12/26/2015 12:45 PM, Pali Rohár wrote:
> > >Port the bt_coex_mode sysfs interface from wl1251 driver version included
> > >in the Maemo Fremantle kernel to allow bt-coexistence mode configuration.
> > >This enables userspace applications to set one of the modes
> > >WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO.
> > >The default mode is WL1251_BT_COEX_OFF.
> > >It should be noted that this driver always enabled bt-coexistence before
> > >and enabled bt-coexistence directly affects the receiving performance,
> > >rendering it unusable in some low-signal situations. Especially monitor
> > >mode is affected very badly with bt-coexistence enabled.
> > 
> > So what user-space process will be using this interface. Did you consider
> > adding debugfs interface? In case of monitor mode you could consider
> > disabling bt-coex from within the driver itself.
> 
> This aint no debugging feature.
> 									Pavel

Right, bt-coex is not for debugging purpose, but for normal usage, when
user want to use together bluetooth and wifi or just one of those.

Are there any other objections for this patch?

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [next] | [standalone]

#1314203 — Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

Pali Rohár <pali.rohar@gmail.com> writes:

> On Thursday 14 January 2016 10:16:54 Pavel Machek wrote:
>> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote:
>> > On 12/26/2015 12:45 PM, Pali Rohár wrote:
>> > >Port the bt_coex_mode sysfs interface from wl1251 driver version included
>> > >in the Maemo Fremantle kernel to allow bt-coexistence mode configuration.
>> > >This enables userspace applications to set one of the modes
>> > >WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO.
>> > >The default mode is WL1251_BT_COEX_OFF.
>> > >It should be noted that this driver always enabled bt-coexistence before
>> > >and enabled bt-coexistence directly affects the receiving performance,
>> > >rendering it unusable in some low-signal situations. Especially monitor
>> > >mode is affected very badly with bt-coexistence enabled.
>> > 
>> > So what user-space process will be using this interface. Did you consider
>> > adding debugfs interface? In case of monitor mode you could consider
>> > disabling bt-coex from within the driver itself.
>> 
>> This aint no debugging feature.
>
> Right, bt-coex is not for debugging purpose, but for normal usage, when
> user want to use together bluetooth and wifi or just one of those.

I think most of other drivers have a debugfs interface for btcoex, I
guess mostly for testing purposes. But this really should be added to
cfg80211.

-- 
Kalle Valo

[toc] | [prev] | [next] | [standalone]

#1314211

On Thursday 21 January 2016 15:48:14 Kalle Valo wrote:
> Pali Rohár <pali.rohar@gmail.com> writes:
> 
> > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote:
> >> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote:
> >> > On 12/26/2015 12:45 PM, Pali Rohár wrote:
> >> > >Port the bt_coex_mode sysfs interface from wl1251 driver version included
> >> > >in the Maemo Fremantle kernel to allow bt-coexistence mode configuration.
> >> > >This enables userspace applications to set one of the modes
> >> > >WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO.
> >> > >The default mode is WL1251_BT_COEX_OFF.
> >> > >It should be noted that this driver always enabled bt-coexistence before
> >> > >and enabled bt-coexistence directly affects the receiving performance,
> >> > >rendering it unusable in some low-signal situations. Especially monitor
> >> > >mode is affected very badly with bt-coexistence enabled.
> >> > 
> >> > So what user-space process will be using this interface. Did you consider
> >> > adding debugfs interface? In case of monitor mode you could consider
> >> > disabling bt-coex from within the driver itself.
> >> 
> >> This aint no debugging feature.
> >
> > Right, bt-coex is not for debugging purpose, but for normal usage, when
> > user want to use together bluetooth and wifi or just one of those.
> 
> I think most of other drivers have a debugfs interface for btcoex, I
> guess mostly for testing purposes. But this really should be added to
> cfg80211.

All other TI wireless drivers have "bt_coex_state" sysfs node.

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [prev] | [next] | [standalone]

#1314235 — Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

Pali Rohár <pali.rohar@gmail.com> writes:

> On Thursday 21 January 2016 15:48:14 Kalle Valo wrote:
>> Pali Rohár <pali.rohar@gmail.com> writes:
>> 
>> > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote:
>> >> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote:
>> >> > On 12/26/2015 12:45 PM, Pali Rohár wrote:
>> >> > >Port the bt_coex_mode sysfs interface from wl1251 driver version included
>> >> > >in the Maemo Fremantle kernel to allow bt-coexistence mode configuration.
>> >> > >This enables userspace applications to set one of the modes
>> >> > >WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO.
>> >> > >The default mode is WL1251_BT_COEX_OFF.
>> >> > >It should be noted that this driver always enabled bt-coexistence before
>> >> > >and enabled bt-coexistence directly affects the receiving performance,
>> >> > >rendering it unusable in some low-signal situations. Especially monitor
>> >> > >mode is affected very badly with bt-coexistence enabled.
>> >> > 
>> >> > So what user-space process will be using this interface. Did you consider
>> >> > adding debugfs interface? In case of monitor mode you could consider
>> >> > disabling bt-coex from within the driver itself.
>> >> 
>> >> This aint no debugging feature.
>> >
>> > Right, bt-coex is not for debugging purpose, but for normal usage, when
>> > user want to use together bluetooth and wifi or just one of those.
>> 
>> I think most of other drivers have a debugfs interface for btcoex, I
>> guess mostly for testing purposes. But this really should be added to
>> cfg80211.
>
> All other TI wireless drivers have "bt_coex_state" sysfs node.

Then that's a mistake, they shouldn't have that.

-- 
Kalle Valo

[toc] | [prev] | [next] | [standalone]

#1314846

On Thursday 21 January 2016 16:44:33 Kalle Valo wrote:
> Pali Rohár <pali.rohar@gmail.com> writes:
> 
> > On Thursday 21 January 2016 15:48:14 Kalle Valo wrote:
> >> Pali Rohár <pali.rohar@gmail.com> writes:
> >> 
> >> > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote:
> >> >> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote:
> >> >> > On 12/26/2015 12:45 PM, Pali Rohár wrote:
> >> >> > >Port the bt_coex_mode sysfs interface from wl1251 driver version included
> >> >> > >in the Maemo Fremantle kernel to allow bt-coexistence mode configuration.
> >> >> > >This enables userspace applications to set one of the modes
> >> >> > >WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO.
> >> >> > >The default mode is WL1251_BT_COEX_OFF.
> >> >> > >It should be noted that this driver always enabled bt-coexistence before
> >> >> > >and enabled bt-coexistence directly affects the receiving performance,
> >> >> > >rendering it unusable in some low-signal situations. Especially monitor
> >> >> > >mode is affected very badly with bt-coexistence enabled.
> >> >> > 
> >> >> > So what user-space process will be using this interface. Did you consider
> >> >> > adding debugfs interface? In case of monitor mode you could consider
> >> >> > disabling bt-coex from within the driver itself.
> >> >> 
> >> >> This aint no debugging feature.
> >> >
> >> > Right, bt-coex is not for debugging purpose, but for normal usage, when
> >> > user want to use together bluetooth and wifi or just one of those.
> >> 
> >> I think most of other drivers have a debugfs interface for btcoex, I
> >> guess mostly for testing purposes. But this really should be added to
> >> cfg80211.
> >
> > All other TI wireless drivers have "bt_coex_state" sysfs node.
> 
> Then that's a mistake, they shouldn't have that.

But it is there, wl1251 is also TI wireless driver and for last two
years there is no interface to deal with this problem...

So as other drivers do, I'm proposing solution which fix bt coex also
for wl1251 driver need on Nokia N900.

-- 
Pali Rohár
pali.rohar@gmail.com

[toc] | [prev] | [next] | [standalone]

#1314926 — Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

Pali Rohár <pali.rohar@gmail.com> writes:

>> >> > Right, bt-coex is not for debugging purpose, but for normal usage, when
>> >> > user want to use together bluetooth and wifi or just one of those.
>> >> 
>> >> I think most of other drivers have a debugfs interface for btcoex, I
>> >> guess mostly for testing purposes. But this really should be added to
>> >> cfg80211.
>> >
>> > All other TI wireless drivers have "bt_coex_state" sysfs node.
>> 
>> Then that's a mistake, they shouldn't have that.
>
> But it is there, wl1251 is also TI wireless driver and for last two
> years there is no interface to deal with this problem...
>
> So as other drivers do, I'm proposing solution which fix bt coex also
> for wl1251 driver need on Nokia N900.

Even if the wlcore sysfs interface fell through the cracks it's no
excuse to add more private interfaces to wireless drivers. We have
cfg80211 and all generic interfaces, like btcoex control, should go
through that subsystem. That way all drivers can share a common
interface and everyone are happy.

What I suggest is that you add this yourself to cfg80211 and mac80211.
It's not that hard and I think you could use NL80211_CMD_SET_POWER_SAVE
as an example.

-- 
Kalle Valo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web