Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1314165 > unrolled thread
| Started by | "Lee, Chun-Yi" <joeyli.kernel@gmail.com> |
|---|---|
| First post | 2016-01-21 13:40 +0100 |
| Last post | 2016-01-21 17:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string "Lee, Chun-Yi" <joeyli.kernel@gmail.com> - 2016-01-21 13:40 +0100
Re: [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-01-21 17:10 +0100
| From | "Lee, Chun-Yi" <joeyli.kernel@gmail.com> |
|---|---|
| Date | 2016-01-21 13:40 +0100 |
| Subject | [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string |
| Message-ID | <qTmGT-5g3-31@gated-at.bofh.it> |
It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
coded string.
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
drivers/acpi/nfit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
index aa45d48..9fb1a6a 100644
--- a/drivers/acpi/nfit.c
+++ b/drivers/acpi/nfit.c
@@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
acpi_size sz;
int rc;
- status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
+ status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
if (ACPI_FAILURE(status)) {
/* This is ok, we could have an nvdimm hotplugged later */
dev_dbg(dev, "failed to find NFIT at startup\n");
--
2.1.4
[toc] | [next] | [standalone]
| From | Ross Zwisler <ross.zwisler@linux.intel.com> |
|---|---|
| Date | 2016-01-21 17:10 +0100 |
| Subject | Re: [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string |
| Message-ID | <qTpY6-7Ez-23@gated-at.bofh.it> |
| In reply to | #1314165 |
On Thu, Jan 21, 2016 at 08:32:10PM +0800, Lee, Chun-Yi wrote:
> It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
> coded string.
>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> drivers/acpi/nfit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
> index aa45d48..9fb1a6a 100644
> --- a/drivers/acpi/nfit.c
> +++ b/drivers/acpi/nfit.c
> @@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
> acpi_size sz;
> int rc;
>
> - status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
> + status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
> if (ACPI_FAILURE(status)) {
> /* This is ok, we could have an nvdimm hotplugged later */
> dev_dbg(dev, "failed to find NFIT at startup\n");
> --
> 2.1.4
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web