Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314082 > unrolled thread

[PATCH] staging: nvec: replace led_classdev_register

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: nvec: replace led_classdev_register "Gujulan Elango, Hari Prasath (H.)" <hgujulan@visteon.com> - 2016-01-21 11:30 +0100
    Re: [PATCH] staging: nvec: replace led_classdev_register Marc Dietrich <marvin24@gmx.de> - 2016-01-25 22:10 +0100

#1314082 — [PATCH] staging: nvec: replace led_classdev_register

From: Hari Prasath Gujulan Elango <hgujulan@visteon.com>

Replace the led_classdev_register() with the platform managed version
devm_led_classdev_register() & henceforth remove the redundant
nvec_paz00_remove() function.

Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
---
 drivers/staging/nvec/nvec_paz00.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/staging/nvec/nvec_paz00.c b/drivers/staging/nvec/nvec_paz00.c
index 68146bf..cddbfd2 100644
--- a/drivers/staging/nvec/nvec_paz00.c
+++ b/drivers/staging/nvec/nvec_paz00.c
@@ -63,7 +63,7 @@ static int nvec_paz00_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, led);
 
-	ret = led_classdev_register(&pdev->dev, &led->cdev);
+	ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
 	if (ret < 0)
 		return ret;
 
@@ -73,18 +73,8 @@ static int nvec_paz00_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int nvec_paz00_remove(struct platform_device *pdev)
-{
-	struct nvec_led *led = platform_get_drvdata(pdev);
-
-	led_classdev_unregister(&led->cdev);
-
-	return 0;
-}
-
 static struct platform_driver nvec_paz00_driver = {
 	.probe  = nvec_paz00_probe,
-	.remove = nvec_paz00_remove,
 	.driver = {
 		.name  = "nvec-paz00",
 	},
-- 
1.9.1

[toc] | [next] | [standalone]

#1317302

[Multipart message — attachments visible in raw view] — view raw

Am Donnerstag 21 Januar 2016, 10:23:46 schrieb Gujulan Elango, Hari Prasath:
> From: Hari Prasath Gujulan Elango <hgujulan@visteon.com>
> 
> Replace the led_classdev_register() with the platform managed version
> devm_led_classdev_register() & henceforth remove the redundant
> nvec_paz00_remove() function.
> 
> Signed-off-by: Hari Prasath Gujulan Elango <hgujulan@visteon.com>

Thanks!

Acked-by: Marc Dietrich <marvin24@gmx.de>

> ---
>  drivers/staging/nvec/nvec_paz00.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/nvec/nvec_paz00.c
> b/drivers/staging/nvec/nvec_paz00.c index 68146bf..cddbfd2 100644
> --- a/drivers/staging/nvec/nvec_paz00.c
> +++ b/drivers/staging/nvec/nvec_paz00.c
> @@ -63,7 +63,7 @@ static int nvec_paz00_probe(struct platform_device *pdev)
> 
>  	platform_set_drvdata(pdev, led);
> 
> -	ret = led_classdev_register(&pdev->dev, &led->cdev);
> +	ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
>  	if (ret < 0)
>  		return ret;
> 
> @@ -73,18 +73,8 @@ static int nvec_paz00_probe(struct platform_device *pdev)
> return 0;
>  }
> 
> -static int nvec_paz00_remove(struct platform_device *pdev)
> -{
> -	struct nvec_led *led = platform_get_drvdata(pdev);
> -
> -	led_classdev_unregister(&led->cdev);
> -
> -	return 0;
> -}
> -
>  static struct platform_driver nvec_paz00_driver = {
>  	.probe  = nvec_paz00_probe,
> -	.remove = nvec_paz00_remove,
>  	.driver = {
>  		.name  = "nvec-paz00",
>  	},

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web