Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1311527 > unrolled thread
| Started by | Marc Gonzalez <marc_gonzalez@sigmadesigns.com> |
|---|---|
| First post | 2016-01-18 14:10 +0100 |
| Last post | 2016-01-20 18:10 +0100 |
| Articles | 4 on this page of 24 — 4 participants |
Back to article view | Back to linux.kernel
[RFC PATCH v2] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 14:10 +0100
Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-18 14:10 +0100
Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 17:10 +0100
[RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-18 17:50 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-01-20 17:10 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:20 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:30 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:40 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:40 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:50 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 19:10 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:00 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:40 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:40 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:40 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-22 17:50 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-22 17:50 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2016-01-20 17:30 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 17:30 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 17:30 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2016-01-20 18:10 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 18:10 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Mark Rutland <mark.rutland@arm.com> - 2016-01-20 18:10 +0100
Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller Måns Rullgård <mans@mansr.com> - 2016-01-20 18:10 +0100
Page 2 of 2 — ← Prev page 1 [2]
| From | Marc Gonzalez <marc_gonzalez@sigmadesigns.com> |
|---|---|
| Date | 2016-01-20 18:10 +0100 |
| Subject | Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller |
| Message-ID | <qT4qB-1bh-3@gated-at.bofh.it> |
| In reply to | #1313339 |
On 20/01/2016 18:02, Mark Rutland wrote: > When you put together the binding document, please point out that the > ranges property is necessary. I don't quite understand. Can I write the node without a ranges property, and the driver would still function correctly? Regards.
[toc] | [prev] | [next] | [standalone]
| From | Måns Rullgård <mans@mansr.com> |
|---|---|
| Date | 2016-01-20 18:10 +0100 |
| Subject | Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller |
| Message-ID | <qT4qD-1bh-31@gated-at.bofh.it> |
| In reply to | #1313374 |
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes: > On 20/01/2016 18:02, Mark Rutland wrote: > >> When you put together the binding document, please point out that the >> ranges property is necessary. > > I don't quite understand. > > Can I write the node without a ranges property, and the driver would > still function correctly? Not the one you posted. -- Måns Rullgård
[toc] | [prev] | [next] | [standalone]
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Date | 2016-01-20 18:10 +0100 |
| Subject | Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller |
| Message-ID | <qT4qB-1bh-5@gated-at.bofh.it> |
| In reply to | #1313339 |
On Wed, Jan 20, 2016 at 05:24:14PM +0100, Marc Gonzalez wrote:
> On 20/01/2016 17:10, Måns Rullgård wrote:
>
> > Marc Zyngier wrote:
> >
> >>> + if (of_property_read_u32(node, "reg", &ctl))
> >>> + panic("%s: failed to get reg base", node->name);
> >>> +
> >>> + chip = kzalloc(sizeof(*chip), GFP_KERNEL);
> >>> + chip->ctl = ctl;
> >>> + chip->base = base;
> >
> > As I said before, this assumes the outer DT node uses a ranges
> > property. Normally reg properties work the same whether they specify an
> > offset within an outer "ranges" or have a full address directly. It
> > would be easy enough to make this work with either, so I don't see any
> > reason not to.
>
> IIRC, I was told very early in the review process that the ranges prop
> was mandatory. Lemme look for it... It was Arnd:
>
> http://thread.gmane.org/gmane.linux.ports.arm.kernel/444131/focus=444207
I believe Arnd's point was that you need _a_ ranges property, rather
than specifically requiring an idmap/empty ranges property.
As Marc pointed out, you can use of_iomap on the child nodes to map the
portions described by the reg properties, which will handle any
ranges-based translation automatically.
When you put together the binding document, please point out that the
ranges property is necessary.
Thanks,
Mark.
[toc] | [prev] | [next] | [standalone]
| From | Måns Rullgård <mans@mansr.com> |
|---|---|
| Date | 2016-01-20 18:10 +0100 |
| Subject | Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller |
| Message-ID | <qT4qD-1bh-37@gated-at.bofh.it> |
| In reply to | #1313377 |
Mark Rutland <mark.rutland@arm.com> writes:
> On Wed, Jan 20, 2016 at 05:24:14PM +0100, Marc Gonzalez wrote:
>> On 20/01/2016 17:10, Måns Rullgård wrote:
>>
>> > Marc Zyngier wrote:
>> >
>> >>> + if (of_property_read_u32(node, "reg", &ctl))
>> >>> + panic("%s: failed to get reg base", node->name);
>> >>> +
>> >>> + chip = kzalloc(sizeof(*chip), GFP_KERNEL);
>> >>> + chip->ctl = ctl;
>> >>> + chip->base = base;
>> >
>> > As I said before, this assumes the outer DT node uses a ranges
>> > property. Normally reg properties work the same whether they specify an
>> > offset within an outer "ranges" or have a full address directly. It
>> > would be easy enough to make this work with either, so I don't see any
>> > reason not to.
>>
>> IIRC, I was told very early in the review process that the ranges prop
>> was mandatory. Lemme look for it... It was Arnd:
>>
>> http://thread.gmane.org/gmane.linux.ports.arm.kernel/444131/focus=444207
>
> I believe Arnd's point was that you need _a_ ranges property, rather
> than specifically requiring an idmap/empty ranges property.
>
> As Marc pointed out, you can use of_iomap on the child nodes to map the
> portions described by the reg properties, which will handle any
> ranges-based translation automatically.
No, that's going to get ugly because the generic irqchip needs a single
base address and some of the registers are shared (not part of the range
specified in the child nodes).
--
Måns Rullgård
[toc] | [prev] | [standalone]
Page 2 of 2 — ← Prev page 1 [2]
Back to top | Article view | linux.kernel
csiph-web