Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1311872 > unrolled thread
| Started by | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| First post | 2016-01-19 02:10 +0100 |
| Last post | 2016-01-21 11:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: virtio pull for 4.5 (was Re: [PULL] virtio: barrier rework+fixes) Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-19 02:10 +0100
Re: virtio pull for 4.5 (was Re: [PULL] virtio: barrier rework+fixes) "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-21 11:30 +0100
| From | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Date | 2016-01-19 02:10 +0100 |
| Subject | Re: virtio pull for 4.5 (was Re: [PULL] virtio: barrier rework+fixes) |
| Message-ID | <qSsY2-sr-7@gated-at.bofh.it> |
On Mon, Jan 18, 2016 at 5:21 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> Hi Linus,
> Just making sure nothing's wrong with this pull request.
> If there's an issue, pls let me know!
It was just pulled because I wasn't 100% sure I wanted the extra
indirection. Oh well, pulled now.
One question:
- the arch/sh/ part of the pacth looks dubious. Why does it do that
#define smp_store_mb(var, value) __smp_store_mb(var, value)
despite the commit log saying it's done by asm-generic?
I haven't pushed out yet, my allmodconfig sanity-check build is still going..
Linus
[toc] | [next] | [standalone]
| From | "Michael S. Tsirkin" <mst@redhat.com> |
|---|---|
| Date | 2016-01-21 11:30 +0100 |
| Message-ID | <qTkF3-3Th-1@gated-at.bofh.it> |
| In reply to | #1311872 |
On Mon, Jan 18, 2016 at 05:01:26PM -0800, Linus Torvalds wrote: > On Mon, Jan 18, 2016 at 5:21 AM, Michael S. Tsirkin <mst@redhat.com> wrote: > > Hi Linus, > > Just making sure nothing's wrong with this pull request. > > If there's an issue, pls let me know! > > It was just pulled because I wasn't 100% sure I wanted the extra > indirection. Oh well, pulled now. > > One question: > > - the arch/sh/ part of the pacth looks dubious. Why does it do that > > #define smp_store_mb(var, value) __smp_store_mb(var, value) > > despite the commit log saying it's done by asm-generic? > > I haven't pushed out yet, my allmodconfig sanity-check build is still going.. > > Linus Oh that's because that's what the existing code did, so the original version of the patch left the bug in place. I wanted to include the fix and I wrote this in the commit message, but I forgot to include it in the code :( Thankfully this just means that the commit log is wrong, the code is just unchanged from 4.4, and I'll include a fix in my tree shortly. -- MST
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web