Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1311432 > unrolled thread

Re: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform

Started byRussell King - ARM Linux <linux@arm.linux.org.uk>
First post2016-01-18 11:00 +0100
Last post2016-01-18 11:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-18 11:00 +0100
    Re: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform Arnd Bergmann <arnd@arndb.de> - 2016-01-18 11:50 +0100

#1311432 — Re: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform

FromRussell King - ARM Linux <linux@arm.linux.org.uk>
Date2016-01-18 11:00 +0100
SubjectRe: [PATCH] ARM: debug-ll: fix BCM63xx entry for multiplatform
Message-ID<qSeLp-7gM-15@gated-at.bofh.it>
On Mon, Jan 18, 2016 at 10:51:00AM +0100, Arnd Bergmann wrote:
> During my randconfig build testing, I found that a kernel with
> DEBUG_AT91_UART and ARCH_BCM_63XX fails to build:
> 
> arch/arm/include/debug/at91.S:18:0: error: "CONFIG_DEBUG_UART_VIRT" redefined [-Werror]

Why do we have files defining CONFIG_* symbols?  This is the real error
here - no source file should be defining this.

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

[toc] | [next] | [standalone]


#1311470

FromArnd Bergmann <arnd@arndb.de>
Date2016-01-18 11:50 +0100
Message-ID<qSfxM-7SR-13@gated-at.bofh.it>
In reply to#1311432
On Monday 18 January 2016 09:59:19 Russell King - ARM Linux wrote:
> On Mon, Jan 18, 2016 at 10:51:00AM +0100, Arnd Bergmann wrote:
> > During my randconfig build testing, I found that a kernel with
> > DEBUG_AT91_UART and ARCH_BCM_63XX fails to build:
> > 
> > arch/arm/include/debug/at91.S:18:0: error: "CONFIG_DEBUG_UART_VIRT" redefined [-Werror]
> 
> Why do we have files defining CONFIG_* symbols?  This is the real error
> here - no source file should be defining this.

I agree that we should change that too, I'll send a patch for it as well.

However, this just let me stumble on the problem, without AT91 getting this
wrong, I would not have noticed that bcm63xx breaks other platforms.
The AT91 thing is just confusing but otherwise harmless, and I wouldn't
mark that fix for stable.

	Arnd

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web