Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311398 > unrolled thread

[RFC 00/26] perf tools: Introduce hists specific format entries

Started byJiri Olsa <jolsa@kernel.org>
First post2016-01-18 10:30 +0100
Last post2016-01-25 15:40 +0100
Articles 8 on this page of 28 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [RFC 00/26] perf tools: Introduce hists specific format entries Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 14/26] perf tools: Introduce struct perf_hpp_list Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
      Re: [PATCH 14/26] perf tools: Introduce struct perf_hpp_list Namhyung Kim <namhyung@kernel.org> - 2016-01-25 16:10 +0100
        Re: [PATCH 14/26] perf tools: Introduce struct perf_hpp_list Jiri Olsa <jolsa@redhat.com> - 2016-01-25 16:10 +0100
    [PATCH 21/26] perf tools: Introduce perf_hpp_list__for_each_sort_list macro Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 16/26] perf tools: Add perf_hpp_list register helpers Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 17/26] perf tools: Pass perf_hpp_list all the way through setup_sort_list Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 09/26] perf tools: Allocate output sort field Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 13/26] perf tools: Separate output fields parsing into setup_output_list function Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 15/26] perf tools: Introduce perf_hpp_list__init function Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 11/26] perf tools: Properly release format fields Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 07/26] perf tools: Make hpp setup function generic Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 12/26] perf tools: Separate sort fields parsing into setup_sort_list function Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 20/26] perf tools: Introduce perf_hpp_list__for_each_format_safe macro Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 23/26] perf tools: Add struct perf_hpp_list argument to helper functions Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 26/26] perf tools: Introduce hists__for_each_sort_list macro Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 06/26] perf tools: Add hpp__equal callback function Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 22/26] perf tools: Introduce perf_hpp_list__for_each_sort_list_safe macro Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 19/26] perf tools: Introduce perf_hpp_list__for_each_format macro Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 25/26] perf tools: Introduce hists__for_each_format macro Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:30 +0100
    [PATCH 01/26] perf tools: Factor output_resort from hists__output_resort Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:40 +0100
    [PATCH 05/26] perf tools: Add equal method to perf_hpp_fmt struct Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:40 +0100
    [PATCH 03/26] perf tools: Add _idx fields into struct perf_hpp_fmt Jiri Olsa <jolsa@kernel.org> - 2016-01-18 10:40 +0100
    Re: [RFC 00/26] perf tools: Introduce hists specific format entries Namhyung Kim <namhyung@kernel.org> - 2016-01-19 14:00 +0100
      Re: [RFC 00/26] perf tools: Introduce hists specific format entries Jiri Olsa <jolsa@redhat.com> - 2016-01-19 14:30 +0100
    Re: [RFC 00/26] perf tools: Introduce hists specific format entries Jiri Olsa <jolsa@redhat.com> - 2016-01-25 08:20 +0100
      Re: [RFC 00/26] perf tools: Introduce hists specific format entries Namhyung Kim <namhyung@kernel.org> - 2016-01-25 15:30 +0100
        Re: [RFC 00/26] perf tools: Introduce hists specific format entries Jiri Olsa <jolsa@redhat.com> - 2016-01-25 15:40 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1311418 — [PATCH 01/26] perf tools: Factor output_resort from hists__output_resort

FromJiri Olsa <jolsa@kernel.org>
Date2016-01-18 10:40 +0100
Subject[PATCH 01/26] perf tools: Factor output_resort from hists__output_resort
Message-ID<qSes1-78G-5@gated-at.bofh.it>
In reply to#1311398
Current hists__output_resort depends on hists based on
hists_evsel struct, but we need to be able to sort common
hists as well.

Cutting out the sorting base sorting code into output_resort
function, so it can be reused in following patch.

Link: http://lkml.kernel.org/n/tip-z38ujjabcpch04u71bd27lyq@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/util/hist.c | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index c226303e3da0..83a6f2733cdc 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -1179,19 +1179,13 @@ static void __hists__insert_output_entry(struct rb_root *entries,
 	rb_insert_color(&he->rb_node, entries);
 }
 
-void hists__output_resort(struct hists *hists, struct ui_progress *prog)
+static void output_resort(struct hists *hists, struct ui_progress *prog,
+			  bool use_callchain)
 {
 	struct rb_root *root;
 	struct rb_node *next;
 	struct hist_entry *n;
 	u64 min_callchain_hits;
-	struct perf_evsel *evsel = hists_to_evsel(hists);
-	bool use_callchain;
-
-	if (evsel && symbol_conf.use_callchain && !symbol_conf.show_ref_callgraph)
-		use_callchain = evsel->attr.sample_type & PERF_SAMPLE_CALLCHAIN;
-	else
-		use_callchain = symbol_conf.use_callchain;
 
 	min_callchain_hits = hists->stats.total_period * (callchain_param.min_percent / 100);
 
@@ -1221,6 +1215,19 @@ void hists__output_resort(struct hists *hists, struct ui_progress *prog)
 	}
 }
 
+void hists__output_resort(struct hists *hists, struct ui_progress *prog)
+{
+	struct perf_evsel *evsel = hists_to_evsel(hists);
+	bool use_callchain;
+
+	if (evsel && symbol_conf.use_callchain && !symbol_conf.show_ref_callgraph)
+		use_callchain = evsel->attr.sample_type & PERF_SAMPLE_CALLCHAIN;
+	else
+		use_callchain = symbol_conf.use_callchain;
+
+	output_resort(hists, prog, use_callchain);
+}
+
 static void hists__remove_entry_filter(struct hists *hists, struct hist_entry *h,
 				       enum hist_filter filter)
 {
-- 
2.4.3

[toc] | [prev] | [next] | [standalone]

#1311419 — [PATCH 05/26] perf tools: Add equal method to perf_hpp_fmt struct

FromJiri Olsa <jolsa@kernel.org>
Date2016-01-18 10:40 +0100
Subject[PATCH 05/26] perf tools: Add equal method to perf_hpp_fmt struct
Message-ID<qSes1-78G-11@gated-at.bofh.it>
In reply to#1311398
To easily compare format entries and make it available
for all kinds of format entries.

Link: http://lkml.kernel.org/n/tip-6ncdmurfcmyk4sfy7fr4bkr1@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/ui/hist.c   |  9 +++++++--
 tools/perf/util/hist.h |  2 +-
 tools/perf/util/sort.c | 39 ++++++++++++++++++++-------------------
 3 files changed, 28 insertions(+), 22 deletions(-)

diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
index 5a11bf0aabc7..71c8bb71a350 100644
--- a/tools/perf/ui/hist.c
+++ b/tools/perf/ui/hist.c
@@ -524,6 +524,11 @@ void perf_hpp__cancel_cumulate(void)
 	perf_hpp__format[PERF_HPP__OVERHEAD].name = "Overhead";
 }
 
+static bool fmt_equal(struct perf_hpp_fmt *a, struct perf_hpp_fmt *b)
+{
+	return a->equal && a->equal(a, b);
+}
+
 void perf_hpp__setup_output_field(void)
 {
 	struct perf_hpp_fmt *fmt;
@@ -542,7 +547,7 @@ void perf_hpp__setup_output_field(void)
 			struct perf_hpp_fmt *pos;
 
 			perf_hpp__for_each_format(pos) {
-				if (perf_hpp__same_sort_entry(pos, fmt))
+				if (fmt_equal(fmt, pos))
 					goto next;
 			}
 		}
@@ -571,7 +576,7 @@ void perf_hpp__append_sort_keys(void)
 			struct perf_hpp_fmt *pos;
 
 			perf_hpp__for_each_sort_list(pos) {
-				if (perf_hpp__same_sort_entry(pos, fmt))
+				if (fmt_equal(fmt, pos))
 					goto next;
 			}
 		}
diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
index 8a0cbdeb449e..9a240d7b8d3b 100644
--- a/tools/perf/util/hist.h
+++ b/tools/perf/util/hist.h
@@ -215,6 +215,7 @@ struct perf_hpp_fmt {
 			    struct hist_entry *a, struct hist_entry *b);
 	int64_t (*sort)(struct perf_hpp_fmt *fmt,
 			struct hist_entry *a, struct hist_entry *b);
+	bool (*equal)(struct perf_hpp_fmt *a, struct perf_hpp_fmt *b);
 
 	struct list_head list;
 	struct list_head sort_list;
@@ -268,7 +269,6 @@ void perf_hpp__reset_output_field(void);
 void perf_hpp__append_sort_keys(void);
 
 bool perf_hpp__is_sort_entry(struct perf_hpp_fmt *format);
-bool perf_hpp__same_sort_entry(struct perf_hpp_fmt *a, struct perf_hpp_fmt *b);
 bool perf_hpp__is_dynamic_entry(struct perf_hpp_fmt *format);
 bool perf_hpp__defined_dynamic_entry(struct perf_hpp_fmt *fmt, struct hists *hists);
 
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
index ec722346e6ff..1b57ec9d7c2f 100644
--- a/tools/perf/util/sort.c
+++ b/tools/perf/util/sort.c
@@ -1440,20 +1440,6 @@ struct hpp_sort_entry {
 	struct sort_entry *se;
 };
 
-bool perf_hpp__same_sort_entry(struct perf_hpp_fmt *a, struct perf_hpp_fmt *b)
-{
-	struct hpp_sort_entry *hse_a;
-	struct hpp_sort_entry *hse_b;
-
-	if (!perf_hpp__is_sort_entry(a) || !perf_hpp__is_sort_entry(b))
-		return false;
-
-	hse_a = container_of(a, struct hpp_sort_entry, hpp);
-	hse_b = container_of(b, struct hpp_sort_entry, hpp);
-
-	return hse_a->se == hse_b->se;
-}
-
 void perf_hpp__reset_sort_width(struct perf_hpp_fmt *fmt, struct hists *hists)
 {
 	struct hpp_sort_entry *hse;
@@ -1539,6 +1525,25 @@ static int64_t __sort__hpp_sort(struct perf_hpp_fmt *fmt,
 	return sort_fn(a, b);
 }
 
+bool perf_hpp__is_sort_entry(struct perf_hpp_fmt *format)
+{
+	return format->header == __sort__hpp_header;
+}
+
+static bool __sort__hpp_equal(struct perf_hpp_fmt *a, struct perf_hpp_fmt *b)
+{
+	struct hpp_sort_entry *hse_a;
+	struct hpp_sort_entry *hse_b;
+
+	if (!perf_hpp__is_sort_entry(a) || !perf_hpp__is_sort_entry(b))
+		return false;
+
+	hse_a = container_of(a, struct hpp_sort_entry, hpp);
+	hse_b = container_of(b, struct hpp_sort_entry, hpp);
+
+	return hse_a->se == hse_b->se;
+}
+
 static struct hpp_sort_entry *
 __sort_dimension__alloc_hpp(struct sort_dimension *sd)
 {
@@ -1560,6 +1565,7 @@ __sort_dimension__alloc_hpp(struct sort_dimension *sd)
 	hse->hpp.cmp = __sort__hpp_cmp;
 	hse->hpp.collapse = __sort__hpp_collapse;
 	hse->hpp.sort = __sort__hpp_sort;
+	hse->hpp.equal = __sort__hpp_equal;
 
 	INIT_LIST_HEAD(&hse->hpp.list);
 	INIT_LIST_HEAD(&hse->hpp.sort_list);
@@ -1570,11 +1576,6 @@ __sort_dimension__alloc_hpp(struct sort_dimension *sd)
 	return hse;
 }
 
-bool perf_hpp__is_sort_entry(struct perf_hpp_fmt *format)
-{
-	return format->header == __sort__hpp_header;
-}
-
 static int __sort_dimension__add_hpp_sort(struct sort_dimension *sd)
 {
 	struct hpp_sort_entry *hse = __sort_dimension__alloc_hpp(sd);
-- 
2.4.3

[toc] | [prev] | [next] | [standalone]

#1311421 — [PATCH 03/26] perf tools: Add _idx fields into struct perf_hpp_fmt

FromJiri Olsa <jolsa@kernel.org>
Date2016-01-18 10:40 +0100
Subject[PATCH 03/26] perf tools: Add _idx fields into struct perf_hpp_fmt
Message-ID<qSes2-78G-37@gated-at.bofh.it>
In reply to#1311398
Currently there's no way of comparing hpp format entries,
which is needed in following patches.

Adding _idx fields into struct perf_hpp_fmt to recognize
and be able to compare hpp format entries.

Link: http://lkml.kernel.org/n/tip-fz58ixswttfdcmv5o7v5b9j4@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/ui/hist.c   | 25 ++++++++++++++-----------
 tools/perf/util/hist.h |  1 +
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
index bf2a66e254ea..d392801ea17e 100644
--- a/tools/perf/ui/hist.c
+++ b/tools/perf/ui/hist.c
@@ -371,7 +371,7 @@ static int64_t hpp__nop_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
 	return 0;
 }
 
-#define HPP__COLOR_PRINT_FNS(_name, _fn)		\
+#define HPP__COLOR_PRINT_FNS(_name, _fn, _idx)		\
 	{						\
 		.name   = _name,			\
 		.header	= hpp__header_fn,		\
@@ -381,9 +381,10 @@ static int64_t hpp__nop_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
 		.cmp	= hpp__nop_cmp,			\
 		.collapse = hpp__nop_cmp,		\
 		.sort	= hpp__sort_ ## _fn,		\
+		.idx	= PERF_HPP__ ## _idx,		\
 	}
 
-#define HPP__COLOR_ACC_PRINT_FNS(_name, _fn)		\
+#define HPP__COLOR_ACC_PRINT_FNS(_name, _fn, _idx)	\
 	{						\
 		.name   = _name,			\
 		.header	= hpp__header_fn,		\
@@ -393,9 +394,10 @@ static int64_t hpp__nop_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
 		.cmp	= hpp__nop_cmp,			\
 		.collapse = hpp__nop_cmp,		\
 		.sort	= hpp__sort_ ## _fn,		\
+		.idx	= PERF_HPP__ ## _idx,		\
 	}
 
-#define HPP__PRINT_FNS(_name, _fn)			\
+#define HPP__PRINT_FNS(_name, _fn, _idx)		\
 	{						\
 		.name   = _name,			\
 		.header	= hpp__header_fn,		\
@@ -404,17 +406,18 @@ static int64_t hpp__nop_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
 		.cmp	= hpp__nop_cmp,			\
 		.collapse = hpp__nop_cmp,		\
 		.sort	= hpp__sort_ ## _fn,		\
+		.idx	= PERF_HPP__ ## _idx,		\
 	}
 
 struct perf_hpp_fmt perf_hpp__format[] = {
-	HPP__COLOR_PRINT_FNS("Overhead", overhead),
-	HPP__COLOR_PRINT_FNS("sys", overhead_sys),
-	HPP__COLOR_PRINT_FNS("usr", overhead_us),
-	HPP__COLOR_PRINT_FNS("guest sys", overhead_guest_sys),
-	HPP__COLOR_PRINT_FNS("guest usr", overhead_guest_us),
-	HPP__COLOR_ACC_PRINT_FNS("Children", overhead_acc),
-	HPP__PRINT_FNS("Samples", samples),
-	HPP__PRINT_FNS("Period", period)
+	HPP__COLOR_PRINT_FNS("Overhead", overhead, OVERHEAD),
+	HPP__COLOR_PRINT_FNS("sys", overhead_sys, OVERHEAD_SYS),
+	HPP__COLOR_PRINT_FNS("usr", overhead_us, OVERHEAD_US),
+	HPP__COLOR_PRINT_FNS("guest sys", overhead_guest_sys, OVERHEAD_GUEST_SYS),
+	HPP__COLOR_PRINT_FNS("guest usr", overhead_guest_us, OVERHEAD_GUEST_US),
+	HPP__COLOR_ACC_PRINT_FNS("Children", overhead_acc, OVERHEAD_ACC),
+	HPP__PRINT_FNS("Samples", samples, SAMPLES),
+	HPP__PRINT_FNS("Period", period, PERIOD)
 };
 
 LIST_HEAD(perf_hpp__list);
diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
index bc2499794bef..8a0cbdeb449e 100644
--- a/tools/perf/util/hist.h
+++ b/tools/perf/util/hist.h
@@ -221,6 +221,7 @@ struct perf_hpp_fmt {
 	bool elide;
 	int len;
 	int user_len;
+	int idx;
 };
 
 extern struct list_head perf_hpp__list;
-- 
2.4.3

[toc] | [prev] | [next] | [standalone]

#1312189

FromNamhyung Kim <namhyung@kernel.org>
Date2016-01-19 14:00 +0100
Message-ID<qSE37-7ZZ-5@gated-at.bofh.it>
In reply to#1311398
On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote:
> hi,
> currently we have global format sort and output
> lists. This rfc patchset introduces hists object
> based format entries to allow the hist object to
> carry specific format entries.
> 
> This will allow to have distinguished hist objects
> displaying different stuff in output.

How do you manage hists objects to have different hpp lists?  Will you
provide an option to users?  Or is it specific to some tools like
c2c?


> 
> Also available in:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/hists_fmt
> 
> thanks for comments,
> jirka
> 
> 
> ---
> Jiri Olsa (26):
>       perf tools: Factor output_resort from hists__output_resort
>       perf tools: Introduce perf_evsel__output_resort function
>       perf tools: Add _idx fields into struct perf_hpp_fmt
>       perf tools: Use struct perf_hpp_fmt::idx in perf_hpp__reset_width
>       perf tools: Add equal method to perf_hpp_fmt struct
>       perf tools: Add hpp__equal callback function
>       perf tools: Make hpp setup function generic
>       perf report: Move ui initialization ahead of sort setup
>       perf tools: Allocate output sort field
>       perf tools: Remove perf_hpp__column_(disable|enable)
>       perf tools: Properly release format fields
>       perf tools: Separate sort fields parsing into setup_sort_list function
>       perf tools: Separate output fields parsing into setup_output_list function
>       perf tools: Introduce struct perf_hpp_list
>       perf tools: Introduce perf_hpp_list__init function
>       perf tools: Add perf_hpp_list register helpers
>       perf tools: Pass perf_hpp_list all the way through setup_sort_list
>       perf tools: Pass perf_hpp_list all the way through setup_output_list
>       perf tools: Introduce perf_hpp_list__for_each_format macro
>       perf tools: Introduce perf_hpp_list__for_each_format_safe macro
>       perf tools: Introduce perf_hpp_list__for_each_sort_list macro
>       perf tools: Introduce perf_hpp_list__for_each_sort_list_safe macro
>       perf tools: Add struct perf_hpp_list argument to helper functions
>       perf tools: Add hpp_list into struct hists object
>       perf tools: Introduce hists__for_each_format macro
>       perf tools: Introduce hists__for_each_sort_list macro
> 
>  tools/perf/builtin-annotate.c     |   2 +-
>  tools/perf/builtin-report.c       |  20 ++++-----
>  tools/perf/builtin-top.c          |  10 +++--
>  tools/perf/tests/hists_cumulate.c |   2 +-
>  tools/perf/tests/hists_filter.c   |   2 +-
>  tools/perf/tests/hists_output.c   |  10 ++---
>  tools/perf/ui/browsers/hists.c    |   8 ++--
>  tools/perf/ui/gtk/hists.c         |   6 +--
>  tools/perf/ui/hist.c              | 170 +++++++++++++++++++++++++++++++++++++----------------------------------
>  tools/perf/ui/stdio/hist.c        |  10 ++---
>  tools/perf/util/hist.c            |  47 ++++++++++++++------
>  tools/perf/util/hist.h            |  65 ++++++++++++++++++++--------
>  tools/perf/util/sort.c            | 231 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------
>  13 files changed, 359 insertions(+), 224 deletions(-)

[toc] | [prev] | [next] | [standalone]

#1312220

FromJiri Olsa <jolsa@redhat.com>
Date2016-01-19 14:30 +0100
Message-ID<qSEw9-8rZ-3@gated-at.bofh.it>
In reply to#1312189
On Tue, Jan 19, 2016 at 09:58:41PM +0900, Namhyung Kim wrote:
> On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote:
> > hi,
> > currently we have global format sort and output
> > lists. This rfc patchset introduces hists object
> > based format entries to allow the hist object to
> > carry specific format entries.
> > 
> > This will allow to have distinguished hist objects
> > displaying different stuff in output.
> 
> How do you manage hists objects to have different hpp lists?  Will you
> provide an option to users?  Or is it specific to some tools like
> c2c?

this patchset does not change the visible things,
it allows to initialize hists with perf_hpp_list
that provides sort/output list

the only visible usage I ahve for this is the c2c display
where I display cahclines with details on one screen and
separate cacheline offsets on another

jirka

[toc] | [prev] | [next] | [standalone]

#1316256

FromJiri Olsa <jolsa@redhat.com>
Date2016-01-25 08:20 +0100
Message-ID<qUJBo-rn-7@gated-at.bofh.it>
In reply to#1311398
On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote:
> hi,
> currently we have global format sort and output
> lists. This rfc patchset introduces hists object
> based format entries to allow the hist object to
> carry specific format entries.
> 
> This will allow to have distinguished hist objects
> displaying different stuff in output.
> 
> Also available in:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/hists_fmt
> 
> thanks for comments,

ping

thanks,
jirka

[toc] | [prev] | [next] | [standalone]

#1316760

FromNamhyung Kim <namhyung@kernel.org>
Date2016-01-25 15:30 +0100
Message-ID<qUQjw-5hx-29@gated-at.bofh.it>
In reply to#1316256
Hi Jiri,

On Mon, Jan 25, 2016 at 08:15:52AM +0100, Jiri Olsa wrote:
> On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote:
> > hi,
> > currently we have global format sort and output
> > lists. This rfc patchset introduces hists object
> > based format entries to allow the hist object to
> > carry specific format entries.
> > 
> > This will allow to have distinguished hist objects
> > displaying different stuff in output.

The concepth is OK.  But I don't want to embed hists into the
hist_entry for hierarchy mode.  As you said it'd be better to factor
out common bits and embed it both from hists and hist entry.  In the
minimal, two rbroot (for in and out) and a format list would be
required IMHO.

Thanks,
Namhyung

[toc] | [prev] | [next] | [standalone]

#1316765

FromJiri Olsa <jolsa@redhat.com>
Date2016-01-25 15:40 +0100
Message-ID<qUQtc-5oH-17@gated-at.bofh.it>
In reply to#1316760
On Mon, Jan 25, 2016 at 11:24:24PM +0900, Namhyung Kim wrote:
> Hi Jiri,
> 
> On Mon, Jan 25, 2016 at 08:15:52AM +0100, Jiri Olsa wrote:
> > On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote:
> > > hi,
> > > currently we have global format sort and output
> > > lists. This rfc patchset introduces hists object
> > > based format entries to allow the hist object to
> > > carry specific format entries.
> > > 
> > > This will allow to have distinguished hist objects
> > > displaying different stuff in output.
> 
> The concepth is OK.  But I don't want to embed hists into the
> hist_entry for hierarchy mode.  As you said it'd be better to factor
> out common bits and embed it both from hists and hist entry.  In the
> minimal, two rbroot (for in and out) and a format list would be
> required IMHO.

right.. however this patchset just adds the support to have
format lists (sort and output) defined for the hists object

I plan the 'cutting out common hists' part to come after this
one and after we merge your hierachy view patchset

thanks,
jirka

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web