Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1313117 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-01-20 12:00 +0100 |
| Last post | 2016-01-20 14:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc Colin King <colin.king@canonical.com> - 2016-01-20 12:00 +0100
Re: [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-01-20 14:00 +0100
Re: [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc Daniel Vetter <daniel@ffwll.ch> - 2016-01-20 14:00 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-01-20 12:00 +0100 |
| Subject | [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc |
| Message-ID | <qSYEz-5ea-19@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Duplicated const, only one is required. Also reformat line to ensure
it is less than 80 columns wide.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index c895b6f..bb88e3d 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -74,7 +74,8 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
};
static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
- const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
+ const struct drm_mode_fb_cmd2 *mode_cmd,
+ struct drm_gem_cma_object **obj,
unsigned int num_planes)
{
struct drm_fb_cma *fb_cma;
--
2.7.0.rc3
[toc] | [next] | [standalone]
| From | Ville Syrjälä <ville.syrjala@linux.intel.com> |
|---|---|
| Date | 2016-01-20 14:00 +0100 |
| Subject | Re: [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc |
| Message-ID | <qT0wH-6v8-19@gated-at.bofh.it> |
| In reply to | #1313117 |
On Wed, Jan 20, 2016 at 10:59:34AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Duplicated const, only one is required. Also reformat line to ensure
> it is less than 80 columns wide.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..bb88e3d 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,8 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
> };
>
> static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> + const struct drm_mode_fb_cmd2 *mode_cmd,
> + struct drm_gem_cma_object **obj,
Seems to have been my mode_cmd constification that added the second
const by accident.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> unsigned int num_planes)
> {
> struct drm_fb_cma *fb_cma;
> --
> 2.7.0.rc3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
[toc] | [prev] | [next] | [standalone]
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Date | 2016-01-20 14:00 +0100 |
| Subject | Re: [PATCH] drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc |
| Message-ID | <qT0wH-6v8-31@gated-at.bofh.it> |
| In reply to | #1313117 |
On Wed, Jan 20, 2016 at 10:59:34AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Duplicated const, only one is required. Also reformat line to ensure
> it is less than 80 columns wide.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..bb88e3d 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,8 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
> };
>
> static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> - const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> + const struct drm_mode_fb_cmd2 *mode_cmd,
> + struct drm_gem_cma_object **obj,
> unsigned int num_planes)
> {
> struct drm_fb_cma *fb_cma;
> --
> 2.7.0.rc3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web