Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1312986 > unrolled thread
| Started by | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| First post | 2016-01-20 09:30 +0100 |
| Last post | 2016-01-20 12:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mmc: sdio_cis: fix unknown tuple for CISTPL_SDIO_STD Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-20 09:30 +0100
Re: [PATCH] mmc: sdio_cis: fix unknown tuple for CISTPL_SDIO_STD Ulf Hansson <ulf.hansson@linaro.org> - 2016-01-20 12:50 +0100
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2016-01-20 09:30 +0100 |
| Subject | [PATCH] mmc: sdio_cis: fix unknown tuple for CISTPL_SDIO_STD |
| Message-ID | <qSWjo-3N7-3@gated-at.bofh.it> |
CISTPL_SDIO_STD(0x91) is a known tuple, but sdio_cis didn't define it,
so we get the warning blow while probing several sdio wifi. Refer to SDIO spec,
it's no need to parse the tuple, so this patch just make it a known one.
[ 4.098980] mmc2: queuing unknown CIS tuple 0x91 (3 bytes)
[ 4.099033] mmc2: new ultra high speed SDR104 SDIO card at address 0001
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/core/sdio_cis.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core/sdio_cis.c
index 8e94e55..6f6fc52 100644
--- a/drivers/mmc/core/sdio_cis.c
+++ b/drivers/mmc/core/sdio_cis.c
@@ -223,6 +223,7 @@ static const struct cis_tpl cis_tpl_list[] = {
{ 0x20, 4, cistpl_manfid },
{ 0x21, 2, /* cistpl_funcid */ },
{ 0x22, 0, cistpl_funce },
+ { 0x91, 2, /* cistpl_sdio_std */ },
};
static int sdio_read_cis(struct mmc_card *card, struct sdio_func *func)
--
2.3.7
[toc] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2016-01-20 12:50 +0100 |
| Message-ID | <qSZqW-5Mi-15@gated-at.bofh.it> |
| In reply to | #1312986 |
On 20 January 2016 at 09:17, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> CISTPL_SDIO_STD(0x91) is a known tuple, but sdio_cis didn't define it,
> so we get the warning blow while probing several sdio wifi. Refer to SDIO spec,
> it's no need to parse the tuple, so this patch just make it a known one.
>
> [ 4.098980] mmc2: queuing unknown CIS tuple 0x91 (3 bytes)
> [ 4.099033] mmc2: new ultra high speed SDR104 SDIO card at address 0001
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Thanks, applied for fixes.
I also updated the change-log as it caused some checkpatch warnings.
Kind regards
Uffe
> ---
>
> drivers/mmc/core/sdio_cis.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core/sdio_cis.c
> index 8e94e55..6f6fc52 100644
> --- a/drivers/mmc/core/sdio_cis.c
> +++ b/drivers/mmc/core/sdio_cis.c
> @@ -223,6 +223,7 @@ static const struct cis_tpl cis_tpl_list[] = {
> { 0x20, 4, cistpl_manfid },
> { 0x21, 2, /* cistpl_funcid */ },
> { 0x22, 0, cistpl_funce },
> + { 0x91, 2, /* cistpl_sdio_std */ },
> };
>
> static int sdio_read_cis(struct mmc_card *card, struct sdio_func *func)
> --
> 2.3.7
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web