Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1312980 > unrolled thread

[PATCH 1/4] net: mvneta: sort the headers in alphabetic order

Started byJisheng Zhang <jszhang@marvell.com>
First post2016-01-20 09:20 +0100
Last post2016-01-20 09:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/4] net: mvneta: sort the headers in alphabetic order Jisheng Zhang <jszhang@marvell.com> - 2016-01-20 09:20 +0100
    Re: [PATCH 1/4] net: mvneta: sort the headers in alphabetic order Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-01-20 09:50 +0100

#1312980 — [PATCH 1/4] net: mvneta: sort the headers in alphabetic order

FromJisheng Zhang <jszhang@marvell.com>
Date2016-01-20 09:20 +0100
Subject[PATCH 1/4] net: mvneta: sort the headers in alphabetic order
Message-ID<qSW9I-3JP-5@gated-at.bofh.it>
Sorting the headers in alphabetic order will help to reduce the conflict
when adding new headers in the future.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 drivers/net/ethernet/marvell/mvneta.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index fabc8df..79e0c7d 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -11,28 +11,28 @@
  * warranty of any kind, whether express or implied.
  */
 
-#include <linux/kernel.h>
-#include <linux/netdevice.h>
+#include <linux/clk.h>
+#include <linux/cpu.h>
 #include <linux/etherdevice.h>
-#include <linux/platform_device.h>
-#include <linux/skbuff.h>
-#include <linux/inetdevice.h>
+#include <linux/kernel.h>
 #include <linux/mbus.h>
 #include <linux/module.h>
-#include <linux/interrupt.h>
+#include <linux/netdevice.h>
 #include <linux/if_vlan.h>
-#include <net/ip.h>
-#include <net/ipv6.h>
+#include <linux/inetdevice.h>
+#include <linux/interrupt.h>
 #include <linux/io.h>
-#include <net/tso.h>
 #include <linux/of.h>
+#include <linux/of_address.h>
 #include <linux/of_irq.h>
 #include <linux/of_mdio.h>
 #include <linux/of_net.h>
-#include <linux/of_address.h>
 #include <linux/phy.h>
-#include <linux/clk.h>
-#include <linux/cpu.h>
+#include <linux/platform_device.h>
+#include <linux/skbuff.h>
+#include <net/ip.h>
+#include <net/ipv6.h>
+#include <net/tso.h>
 
 /* Registers */
 #define MVNETA_RXQ_CONFIG_REG(q)                (0x1400 + ((q) << 2))
-- 
2.7.0.rc3

[toc] | [next] | [standalone]


#1313001

FromThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date2016-01-20 09:50 +0100
Message-ID<qSWCJ-3V7-15@gated-at.bofh.it>
In reply to#1312980
Dear Jisheng Zhang,

On Wed, 20 Jan 2016 16:06:20 +0800, Jisheng Zhang wrote:
> Sorting the headers in alphabetic order will help to reduce the conflict
> when adding new headers in the future.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>  drivers/net/ethernet/marvell/mvneta.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web