Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1312929 > unrolled thread
| Started by | Eric Long <eric.long@linaro.org> |
|---|---|
| First post | 2016-01-20 07:50 +0100 |
| Last post | 2016-01-22 18:30 +0100 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[RESEND PATCH 0/2] Remove the mistakes detected by the check tools. Eric Long <eric.long@linaro.org> - 2016-01-20 07:50 +0100
[RESEND PATCH 2/2] coresight: Remove the mistakes detected by smatch tool Eric Long <eric.long@linaro.org> - 2016-01-20 07:50 +0100
Re: [RESEND PATCH 0/2] Remove the mistakes detected by the check tools. Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-01-21 18:00 +0100
Re: [RESEND PATCH 0/2] Remove the mistakes detected by the check tools. Eric Long <eric.long@linaro.org> - 2016-01-22 10:20 +0100
Re: [RESEND PATCH 0/2] Remove the mistakes detected by the check tools. Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-01-22 18:30 +0100
| From | Eric Long <eric.long@linaro.org> |
|---|---|
| Date | 2016-01-20 07:50 +0100 |
| Subject | [RESEND PATCH 0/2] Remove the mistakes detected by the check tools. |
| Message-ID | <qSUKB-2IV-9@gated-at.bofh.it> |
Both of the two patches optimize the code and remove the mistakes and warnings detected by the check tools. Eric Long (2): coresight: tmc/etm4x: Remove the mistakes detected by sparse tool coresight: Remove the mistakes detected by smatch tool drivers/hwtracing/coresight/coresight-etm4x.c | 2 +- drivers/hwtracing/coresight/coresight-tmc.c | 6 +++--- drivers/hwtracing/coresight/of_coresight.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) -- 1.7.9.5
[toc] | [next] | [standalone]
| From | Eric Long <eric.long@linaro.org> |
|---|---|
| Date | 2016-01-20 07:50 +0100 |
| Subject | [RESEND PATCH 2/2] coresight: Remove the mistakes detected by smatch tool |
| Message-ID | <qSUKC-2IV-13@gated-at.bofh.it> |
| In reply to | #1312929 |
There is an unnecessary space at the front of the code. The smatch tool output logs as the following: of_coresight.c:89 of_coresight_alloc_memory() warn: inconsistent indenting Signed-off-by: Eric Long <eric.long@linaro.org> --- drivers/hwtracing/coresight/of_coresight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c index b097361..3cc57c1 100644 --- a/drivers/hwtracing/coresight/of_coresight.c +++ b/drivers/hwtracing/coresight/of_coresight.c @@ -86,7 +86,7 @@ static int of_coresight_alloc_memory(struct device *dev, return -ENOMEM; /* Children connected to this component via @outports */ - pdata->child_names = devm_kzalloc(dev, pdata->nr_outport * + pdata->child_names = devm_kzalloc(dev, pdata->nr_outport * sizeof(*pdata->child_names), GFP_KERNEL); if (!pdata->child_names) -- 1.7.9.5
[toc] | [prev] | [next] | [standalone]
| From | Mathieu Poirier <mathieu.poirier@linaro.org> |
|---|---|
| Date | 2016-01-21 18:00 +0100 |
| Message-ID | <qTqKv-7ZR-27@gated-at.bofh.it> |
| In reply to | #1312929 |
On 19 January 2016 at 23:39, Eric Long <eric.long@linaro.org> wrote: > Both of the two patches optimize the code and remove the mistakes and > warnings detected by the check tools. > > Eric Long (2): > coresight: tmc/etm4x: Remove the mistakes detected by sparse tool > coresight: Remove the mistakes detected by smatch tool > > drivers/hwtracing/coresight/coresight-etm4x.c | 2 +- > drivers/hwtracing/coresight/coresight-tmc.c | 6 +++--- > drivers/hwtracing/coresight/of_coresight.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > Please run checkpath.pl on your patches. Also if the changes are of a different nature, ex. indentation problem and wrong argument to a function, please provide two separate patches. Thanks, Mathieu > -- > 1.7.9.5 >
[toc] | [prev] | [next] | [standalone]
| From | Eric Long <eric.long@linaro.org> |
|---|---|
| Date | 2016-01-22 10:20 +0100 |
| Message-ID | <qTG2S-20Q-5@gated-at.bofh.it> |
| In reply to | #1314348 |
On 22 January 2016 at 00:56, Mathieu Poirier <mathieu.poirier@linaro.org> wrote: > > Please run checkpath.pl on your patches. Also if the changes are of a > different nature, ex. indentation problem and wrong argument to a > function, please provide two separate patches. > Hi Mathieu, I had already ran checkpath.pl, and there was no error and warning. All the changes are either indentation problems or wrong argument, except one static defined problem. So I think there is no need to separate the patch. By the way, the patches I had send were created base on the check tools, one for smatch and another for sparse. In case I need to separate the patches, do I need to follow the this principle. Thanks. Best Regards. Eric
[toc] | [prev] | [next] | [standalone]
| From | Mathieu Poirier <mathieu.poirier@linaro.org> |
|---|---|
| Date | 2016-01-22 18:30 +0100 |
| Message-ID | <qTNH4-7bM-15@gated-at.bofh.it> |
| In reply to | #1314841 |
On 22 January 2016 at 02:15, Eric Long <eric.long@linaro.org> wrote:
> On 22 January 2016 at 00:56, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
>>
>> Please run checkpath.pl on your patches. Also if the changes are of a
>> different nature, ex. indentation problem and wrong argument to a
>> function, please provide two separate patches.
>>
>
> Hi Mathieu,
>
> I had already ran checkpath.pl, and there was no error and warning.
Using a 4.4 kernel I got the following chackpatch warnings:
mpoirier@t430:~/work/linaro/coresight/kernel-maint$
./scripts/checkpatch.pl
0001-coresight-Remove-the-mistakes-detected-by-sparse-too.patch
0002-coresight-Remove-the-mistakes-detected-by-smatch-too.patch
---------------------------------------------------------------
0001-coresight-Remove-the-mistakes-detected-by-sparse-too.patch
---------------------------------------------------------------
WARNING: A patch subject line should describe the change not the tool
that found it
#4:
Subject: [PATCH 1/2] coresight: Remove the mistakes detected by sparse tool
total: 0 errors, 1 warnings, 32 lines checked
0001-coresight-Remove-the-mistakes-detected-by-sparse-too.patch has
style problems, please review.
---------------------------------------------------------------
0002-coresight-Remove-the-mistakes-detected-by-smatch-too.patch
---------------------------------------------------------------
WARNING: A patch subject line should describe the change not the tool
that found it
#4:
Subject: [PATCH 2/2] coresight: Remove the mistakes detected by smatch tool
total: 0 errors, 1 warnings, 8 lines checked
0002-coresight-Remove-the-mistakes-detected-by-smatch-too.patch has
style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
mpoirier@t430:~/work/linaro/coresight/kernel-maint$ ls
> All the changes are either indentation problems or wrong argument,
> except one static defined problem. So I think there is no need to
> separate the patch.
After fixing the above checkpatch warning bunching changes by tools
won't make sense anymore.
> By the way, the patches I had send were created base on the check
> tools, one for smatch and another for sparse. In case I need to separate
> the patches, do I need to follow the this principle. Thanks.
It's usually one semantic change per patch - the tool that highlighted
the problem is secondary.
>
> Best Regards.
> Eric
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web