Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1310113 > unrolled thread
| Started by | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| First post | 2016-01-15 14:40 +0100 |
| Last post | 2016-01-20 02:40 +0100 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-15 14:40 +0100
[PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-15 14:40 +0100
Re: [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 John Garry <john.garry@huawei.com> - 2016-01-19 11:00 +0100
Re: [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-01-20 02:30 +0100
Re: [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA John Garry <john.garry@huawei.com> - 2016-01-19 10:50 +0100
Re: [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-01-20 02:40 +0100
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2016-01-15 14:40 +0100 |
| Subject | [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA |
| Message-ID | <qRcLE-6Jg-15@gated-at.bofh.it> |
If NO_DMA=y:
ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_set_mask" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_pool_destroy" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_free_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_pool_free" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_supported" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_pool_create" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/scsi/hisi_sas/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
index 37a0c7156087905b..2c05021636a5fea6 100644
--- a/drivers/scsi/hisi_sas/Kconfig
+++ b/drivers/scsi/hisi_sas/Kconfig
@@ -1,5 +1,6 @@
config SCSI_HISI_SAS
tristate "HiSilicon SAS"
+ depends on HAS_DMA
select SCSI_SAS_LIBSAS
select BLK_DEV_INTEGRITY
help
--
1.9.1
[toc] | [next] | [standalone]
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Date | 2016-01-15 14:40 +0100 |
| Subject | [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 |
| Message-ID | <qRcLE-6Jg-23@gated-at.bofh.it> |
| In reply to | #1310113 |
The HiSilicon SAS HBA is available in HiSilicon arm64 SoCs only. Restrict it to arm64, unless compile-testing. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/scsi/hisi_sas/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig index 2c05021636a5fea6..b67661836c9fa26f 100644 --- a/drivers/scsi/hisi_sas/Kconfig +++ b/drivers/scsi/hisi_sas/Kconfig @@ -1,6 +1,7 @@ config SCSI_HISI_SAS tristate "HiSilicon SAS" depends on HAS_DMA + depends on ARM64 || COMPILE_TEST select SCSI_SAS_LIBSAS select BLK_DEV_INTEGRITY help -- 1.9.1
[toc] | [prev] | [next] | [standalone]
| From | John Garry <john.garry@huawei.com> |
|---|---|
| Date | 2016-01-19 11:00 +0100 |
| Subject | Re: [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 |
| Message-ID | <qSBeW-5Y1-11@gated-at.bofh.it> |
| In reply to | #1310116 |
On 15/01/2016 13:39, Geert Uytterhoeven wrote: > The HiSilicon SAS HBA is available in HiSilicon arm64 SoCs only. > Restrict it to arm64, unless compile-testing. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > drivers/scsi/hisi_sas/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig > index 2c05021636a5fea6..b67661836c9fa26f 100644 > --- a/drivers/scsi/hisi_sas/Kconfig > +++ b/drivers/scsi/hisi_sas/Kconfig > @@ -1,6 +1,7 @@ > config SCSI_HISI_SAS > tristate "HiSilicon SAS" > depends on HAS_DMA > + depends on ARM64 || COMPILE_TEST > select SCSI_SAS_LIBSAS > select BLK_DEV_INTEGRITY > help > Reviewed-by: John Garry <john.garry@huawei.com>
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-01-20 02:30 +0100 |
| Subject | Re: [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 |
| Message-ID | <qSPKY-7CF-59@gated-at.bofh.it> |
| In reply to | #1310116 |
>>>>> "Geert" == Geert Uytterhoeven <geert@linux-m68k.org> writes: Geert> The HiSilicon SAS HBA is available in HiSilicon arm64 SoCs only. Geert> Restrict it to arm64, unless compile-testing. Applied to 4.5/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [next] | [standalone]
| From | John Garry <john.garry@huawei.com> |
|---|---|
| Date | 2016-01-19 10:50 +0100 |
| Message-ID | <qSB5f-5UF-13@gated-at.bofh.it> |
| In reply to | #1310113 |
On 15/01/2016 13:39, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined! > ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined! > ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined! > ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined! > ERROR: "dma_set_mask" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined! > ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined! > ERROR: "dma_pool_destroy" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined! > ERROR: "dma_free_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined! > ERROR: "dma_pool_free" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined! > ERROR: "dma_alloc_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined! > ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined! > ERROR: "dma_supported" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined! > ERROR: "dma_pool_create" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined! > > Add a dependency on HAS_DMA to fix this. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > drivers/scsi/hisi_sas/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig > index 37a0c7156087905b..2c05021636a5fea6 100644 > --- a/drivers/scsi/hisi_sas/Kconfig > +++ b/drivers/scsi/hisi_sas/Kconfig > @@ -1,5 +1,6 @@ > config SCSI_HISI_SAS > tristate "HiSilicon SAS" > + depends on HAS_DMA > select SCSI_SAS_LIBSAS > select BLK_DEV_INTEGRITY > help > Reviewed-by: John Garry <john.garry@huawei.com>
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-01-20 02:40 +0100 |
| Message-ID | <qSPUB-7Iz-1@gated-at.bofh.it> |
| In reply to | #1310113 |
>>>>> "Geert" == Geert Uytterhoeven <geert@linux-m68k.org> writes: Geert> If NO_DMA=y: ERROR: "dma_map_sg" Geert> [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined! ERROR: Geert> "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] Geert> undefined! ERROR: "dma_unmap_sg" Geert> Add a dependency on HAS_DMA to fix this. Applied to 4.5/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web