Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1312302 > unrolled thread

[LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.

Started byP L Sai Krishna <lakshmi.sai.krishna.potthuri@xilinx.com>
First post2016-01-19 15:40 +0100
Last post2016-01-19 20:20 +0100
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI. P L Sai Krishna <lakshmi.sai.krishna.potthuri@xilinx.com> - 2016-01-19 15:40 +0100
    Re: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc  for Arasan SDHCI. Sören Brinkmann <soren.brinkmann@xilinx.com> - 2016-01-19 18:00 +0100
    Re: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc  for Arasan SDHCI. Rob Herring <robh@kernel.org> - 2016-01-19 18:30 +0100
      Re: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for  Arasan SDHCI. Michal Simek <michal.simek@xilinx.com> - 2016-01-19 20:20 +0100

#1312302 — [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.

FromP L Sai Krishna <lakshmi.sai.krishna.potthuri@xilinx.com>
Date2016-01-19 15:40 +0100
Subject[LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.
Message-ID<qSFBU-HG-35@gated-at.bofh.it>
This patch adds broken-tuning property to the binding
doc for Arasan SDHCI.

Signed-off-by: P L Sai Krishna <lakshmis@xilinx.com>
---
 Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
index da541c3..2088d9f 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
@@ -17,6 +17,10 @@ Required Properties:
   - interrupt-parent: Phandle for the interrupt controller that services
 		      interrupts for this device.
 
+Optional Properties:
+  - broken-tuning: Indicates tuning broken in Silicon 1.0 of
+			  Zynq Ultrascale+ MPSoC.
+
 Example:
 	sdhci@e0100000 {
 		compatible = "arasan,sdhci-8.9a";
-- 
2.1.2

[toc] | [next] | [standalone]


#1312387 — Re: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.

FromSören Brinkmann <soren.brinkmann@xilinx.com>
Date2016-01-19 18:00 +0100
SubjectRe: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.
Message-ID<qSHNo-26P-15@gated-at.bofh.it>
In reply to#1312302
On Tue, 2016-01-19 at 07:47PM +0530, P L Sai Krishna wrote:
> This patch adds broken-tuning property to the binding
> doc for Arasan SDHCI.
> 
> Signed-off-by: P L Sai Krishna <lakshmis@xilinx.com>
> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index da541c3..2088d9f 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -17,6 +17,10 @@ Required Properties:
>    - interrupt-parent: Phandle for the interrupt controller that services
>  		      interrupts for this device.
>  
> +Optional Properties:
> +  - broken-tuning: Indicates tuning broken in Silicon 1.0 of
> +			  Zynq Ultrascale+ MPSoC.

Describe the purpose/values of the property without reference to the
SoC. Other broken implementations would want to use this property too.

	Sören

[toc] | [prev] | [next] | [standalone]


#1312399 — Re: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.

FromRob Herring <robh@kernel.org>
Date2016-01-19 18:30 +0100
SubjectRe: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.
Message-ID<qSIgr-2zg-35@gated-at.bofh.it>
In reply to#1312302
On Tue, Jan 19, 2016 at 07:47:32PM +0530, P L Sai Krishna wrote:
> This patch adds broken-tuning property to the binding
> doc for Arasan SDHCI.
> 
> Signed-off-by: P L Sai Krishna <lakshmis@xilinx.com>
> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index da541c3..2088d9f 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -17,6 +17,10 @@ Required Properties:
>    - interrupt-parent: Phandle for the interrupt controller that services
>  		      interrupts for this device.
>  
> +Optional Properties:
> +  - broken-tuning: Indicates tuning broken in Silicon 1.0 of
> +			  Zynq Ultrascale+ MPSoC.
> +

Make this a standard property.

Or use the compatible string to determine this. Si errata is exactly 
what they are for.

Rob

[toc] | [prev] | [next] | [standalone]


#1312457 — Re: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.

FromMichal Simek <michal.simek@xilinx.com>
Date2016-01-19 20:20 +0100
SubjectRe: [LINUX PATCH 2/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.
Message-ID<qSJYS-3Il-3@gated-at.bofh.it>
In reply to#1312399
On 19.1.2016 18:19, Rob Herring wrote:
> On Tue, Jan 19, 2016 at 07:47:32PM +0530, P L Sai Krishna wrote:
>> This patch adds broken-tuning property to the binding
>> doc for Arasan SDHCI.
>>
>> Signed-off-by: P L Sai Krishna <lakshmis@xilinx.com>
>> ---
>>  Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> index da541c3..2088d9f 100644
>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>> @@ -17,6 +17,10 @@ Required Properties:
>>    - interrupt-parent: Phandle for the interrupt controller that services
>>  		      interrupts for this device.
>>  
>> +Optional Properties:
>> +  - broken-tuning: Indicates tuning broken in Silicon 1.0 of
>> +			  Zynq Ultrascale+ MPSoC.
>> +
> 
> Make this a standard property.
> 
> Or use the compatible string to determine this. Si errata is exactly 
> what they are for.

I still think that having interface for runtime Silicon version
detection in generic way is much better than using compatible strings
for certain silicon version.
The same board revisions can have different silicon versions.

Asking secure monitor for this information and based on that setup
quirks for this case would be preferred solution.
I want to spend some time to share information about silicon via soc bus
to user space and there should be similar way for sharing this
information inside the kernel.

Thanks,
Michal

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web