Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1306044 > unrolled thread

[PATCH] gpio: max77620: fix of_table.cocci warnings

Started byJulia Lawall <julia.lawall@lip6.fr>
First post2016-01-11 11:50 +0100
Last post2016-01-18 13:20 +0100
Articles 7 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] gpio: max77620: fix of_table.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2016-01-11 11:50 +0100
    Re: [PATCH] gpio: max77620: fix of_table.cocci warnings Linus Walleij <linus.walleij@linaro.org> - 2016-01-14 10:10 +0100
      Re: [PATCH] gpio: max77620: fix of_table.cocci warnings Lee Jones <lee.jones@linaro.org> - 2016-01-14 10:50 +0100
        Re: [PATCH] gpio: max77620: fix of_table.cocci warnings Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-14 11:00 +0100
          Re: [PATCH] gpio: max77620: fix of_table.cocci warnings Linus Walleij <linus.walleij@linaro.org> - 2016-01-15 14:20 +0100
            Re: [PATCH] gpio: max77620: fix of_table.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2016-01-15 14:50 +0100
            Re: [PATCH] gpio: max77620: fix of_table.cocci warnings Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-18 13:20 +0100

#1306044 — [PATCH] gpio: max77620: fix of_table.cocci warnings

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-01-11 11:50 +0100
Subject[PATCH] gpio: max77620: fix of_table.cocci warnings
Message-ID<qPIcW-17S-3@gated-at.bofh.it>
Make sure (of/i2c/platform)_device_id tables are NULL terminated

Generated by: scripts/coccinelle/misc/of_table.cocci

CC: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

Please take the patch only if it's a positive warning. Thanks!

 gpio-max77620.c |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/gpio/gpio-max77620.c
+++ b/drivers/gpio/gpio-max77620.c
@@ -301,6 +301,7 @@ static struct platform_device_id max7762
 	{
 		.name = "max20024-gpio",
 	},
+	{},
 };

 static struct platform_driver max77620_gpio_driver = {

[toc] | [next] | [standalone]

#1309095

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-01-14 10:10 +0100
Message-ID<qQM4O-4UH-15@gated-at.bofh.it>
In reply to#1306044
On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:

> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>
> Generated by: scripts/coccinelle/misc/of_table.cocci
>
> CC: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Please take the patch only if it's a positive warning. Thanks!

This is merged into the MFD subsystem for the moment so patches
have to go through Lee.

Alternatively I can go back and fix it up later.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1309123

FromLee Jones <lee.jones@linaro.org>
Date2016-01-14 10:50 +0100
Message-ID<qQMHw-59v-5@gated-at.bofh.it>
In reply to#1309095
On Thu, 14 Jan 2016, Linus Walleij wrote:

> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> 
> > Make sure (of/i2c/platform)_device_id tables are NULL terminated
> >
> > Generated by: scripts/coccinelle/misc/of_table.cocci
> >
> > CC: Laxman Dewangan <ldewangan@nvidia.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> > ---
> >
> > Please take the patch only if it's a positive warning. Thanks!
> 
> This is merged into the MFD subsystem for the moment so patches
> have to go through Lee.
> 
> Alternatively I can go back and fix it up later.

Pull request for v4.5 has already been sent.

Feel free to take the patch into your tree post -rc1.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1309132

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-01-14 11:00 +0100
Message-ID<qQMRc-5dh-19@gated-at.bofh.it>
In reply to#1309123
On Thursday 14 January 2016 03:17 PM, Lee Jones wrote:
> On Thu, 14 Jan 2016, Linus Walleij wrote:
>
>> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>>
>>> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>>>
>>> Generated by: scripts/coccinelle/misc/of_table.cocci
>>>
>>> CC: Laxman Dewangan <ldewangan@nvidia.com>
>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>>> ---
>>>
>>> Please take the patch only if it's a positive warning. Thanks!
>> This is merged into the MFD subsystem for the moment so patches
>> have to go through Lee.
>>
>> Alternatively I can go back and fix it up later.
> Pull request for v4.5 has already been sent.
>
> Feel free to take the patch into your tree post -rc1.

Is the driver gpio-max77620 applied?

I think still there is discussion going on the patches?

[toc] | [prev] | [next] | [standalone]

#1310101

FromLinus Walleij <linus.walleij@linaro.org>
Date2016-01-15 14:20 +0100
Message-ID<qRcsi-6zK-23@gated-at.bofh.it>
In reply to#1309132
On Thu, Jan 14, 2016 at 10:39 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> On Thursday 14 January 2016 03:17 PM, Lee Jones wrote:
>> On Thu, 14 Jan 2016, Linus Walleij wrote:
>>
>>> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr>
>>> wrote:
>>>
>>>> Make sure (of/i2c/platform)_device_id tables are NULL terminated
>>>>
>>>> Generated by: scripts/coccinelle/misc/of_table.cocci
>>>>
>>>> CC: Laxman Dewangan <ldewangan@nvidia.com>
>>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>>>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
>>>> ---
>>>>
>>>> Please take the patch only if it's a positive warning. Thanks!
>>>
>>> This is merged into the MFD subsystem for the moment so patches
>>> have to go through Lee.
>>>
>>> Alternatively I can go back and fix it up later.
>>
>> Pull request for v4.5 has already been sent.
>>
>> Feel free to take the patch into your tree post -rc1.
>
> Is the driver gpio-max77620 applied?

Nah, I misunderstood it, don't worry. Lee just merged the core
driver(s). I have no idea what Julia's patch is based on, I was
confused by this mail so I assumed it was in the tree but it
was not. The world is full of mysteries :D

> I think still there is discussion going on the patches?

Sure let's work on this for the next cycle.

Yours,
Linus Walleij

[toc] | [prev] | [next] | [standalone]

#1310124

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-01-15 14:50 +0100
Message-ID<qRcVk-6OR-19@gated-at.bofh.it>
In reply to#1310101

On Fri, 15 Jan 2016, Linus Walleij wrote:

> On Thu, Jan 14, 2016 at 10:39 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> > On Thursday 14 January 2016 03:17 PM, Lee Jones wrote:
> >> On Thu, 14 Jan 2016, Linus Walleij wrote:
> >>
> >>> On Mon, Jan 11, 2016 at 11:48 AM, Julia Lawall <julia.lawall@lip6.fr>
> >>> wrote:
> >>>
> >>>> Make sure (of/i2c/platform)_device_id tables are NULL terminated
> >>>>
> >>>> Generated by: scripts/coccinelle/misc/of_table.cocci
> >>>>
> >>>> CC: Laxman Dewangan <ldewangan@nvidia.com>
> >>>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> >>>> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> >>>> ---
> >>>>
> >>>> Please take the patch only if it's a positive warning. Thanks!
> >>>
> >>> This is merged into the MFD subsystem for the moment so patches
> >>> have to go through Lee.
> >>>
> >>> Alternatively I can go back and fix it up later.
> >>
> >> Pull request for v4.5 has already been sent.
> >>
> >> Feel free to take the patch into your tree post -rc1.
> >
> > Is the driver gpio-max77620 applied?
>
> Nah, I misunderstood it, don't worry. Lee just merged the core
> driver(s). I have no idea what Julia's patch is based on, I was
> confused by this mail so I assumed it was in the tree but it
> was not. The world is full of mysteries :D

I don't know either.  It came to me via kbuild.  It may be derived from a
submitted patch rather than aready committed code.

julia

>
> > I think still there is discussion going on the patches?
>
> Sure let's work on this for the next cycle.
>
> Yours,
> Linus Walleij
>

[toc] | [prev] | [next] | [standalone]

#1311514

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-01-18 13:20 +0100
Message-ID<qSgWS-uP-15@gated-at.bofh.it>
In reply to#1310101
On Friday 15 January 2016 06:45 PM, Linus Walleij wrote:
> On Thu, Jan 14, 2016 at 10:39 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>> I think still there is discussion going on the patches?
> Sure let's work on this for the next cycle.
>
>

I have fixed this in V3 version and sent for review.
Please help to review it.

Thanks,
Laxman

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web