Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1311148 > unrolled thread

[PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts

Started byGeert Uytterhoeven <geert@linux-m68k.org>
First post2016-01-17 15:10 +0100
Last post2016-01-17 18:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts Geert Uytterhoeven <geert@linux-m68k.org> - 2016-01-17 15:10 +0100
    Re: [PATCH] tcp_memcontrol: Forward declare cgroup_subsys and  mem_cgroup stucts David Miller <davem@davemloft.net> - 2016-01-17 18:10 +0100

#1311148 — [PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts

FromGeert Uytterhoeven <geert@linux-m68k.org>
Date2016-01-17 15:10 +0100
Subject[PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts
Message-ID<qRWbM-3tv-11@gated-at.bofh.it>
In file included from net/ipv4/tcp_ipv4.c:77 (and many more):
include/net/tcp_memcontrol.h:5: warning: ‘struct cgroup_subsys’ declared inside parameter list
include/net/tcp_memcontrol.h:5: warning: its scope is only this definition or declaration, which is probably not what you want

Add forward declarations for all used structures to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 include/net/tcp_memcontrol.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/net/tcp_memcontrol.h b/include/net/tcp_memcontrol.h
index 3a17b16ae8aa47c4..01ff7c6efada9797 100644
--- a/include/net/tcp_memcontrol.h
+++ b/include/net/tcp_memcontrol.h
@@ -1,6 +1,9 @@
 #ifndef _TCP_MEMCG_H
 #define _TCP_MEMCG_H
 
+struct cgroup_subsys;
+struct mem_cgroup;
+
 int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
 void tcp_destroy_cgroup(struct mem_cgroup *memcg);
 #endif /* _TCP_MEMCG_H */
-- 
1.9.1

[toc] | [next] | [standalone]


#1311166 — Re: [PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts

FromDavid Miller <davem@davemloft.net>
Date2016-01-17 18:10 +0100
SubjectRe: [PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts
Message-ID<qRYZY-5jQ-5@gated-at.bofh.it>
In reply to#1311148
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun, 17 Jan 2016 11:30:37 +0100

> In file included from net/ipv4/tcp_ipv4.c:77 (and many more):
> include/net/tcp_memcontrol.h:5: warning: ‘struct cgroup_subsys’ declared inside parameter list
> include/net/tcp_memcontrol.h:5: warning: its scope is only this definition or declaration, which is probably not what you want
> 
> Add forward declarations for all used structures to fix this.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thanks Geert.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web