Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1311121 > unrolled thread
| Started by | Tapan Prakash T <tapanprakasht@gmail.com> |
|---|---|
| First post | 2016-01-17 11:00 +0100 |
| Last post | 2016-01-17 12:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: usb: storage: onetouch: fixed parethesis and space style issue Tapan Prakash T <tapanprakasht@gmail.com> - 2016-01-17 11:00 +0100
Re: [PATCH] Staging: usb: storage: onetouch: fixed parethesis and space style issue Joe Perches <joe@perches.com> - 2016-01-17 12:40 +0100
| From | Tapan Prakash T <tapanprakasht@gmail.com> |
|---|---|
| Date | 2016-01-17 11:00 +0100 |
| Subject | [PATCH] Staging: usb: storage: onetouch: fixed parethesis and space style issue |
| Message-ID | <qRShQ-KA-7@gated-at.bofh.it> |
Fixed two coding style issue.
Signed-off-by: Tapan Prakash T <tapanprakasht@gmail.com>
---
drivers/usb/storage/onetouch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/storage/onetouch.c b/drivers/usb/storage/onetouch.c
index acc3d03..9097bd4 100644
--- a/drivers/usb/storage/onetouch.c
+++ b/drivers/usb/storage/onetouch.c
@@ -69,7 +69,7 @@ struct usb_onetouch {
vendorName, productName, useProtocol, useTransport, \
initFunction, flags) \
{ USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
- .driver_info = (flags) }
+.driver_info = (flags) }
static struct usb_device_id onetouch_usb_ids[] = {
# include "unusual_onetouch.h"
@@ -125,7 +125,7 @@ static void usb_onetouch_irq(struct urb *urb)
input_sync(dev);
resubmit:
- retval = usb_submit_urb (urb, GFP_ATOMIC);
+ retval = usb_submit_urb(urb, GFP_ATOMIC);
if (retval)
dev_err(&dev->dev, "can't resubmit intr, %s-%s/input0, "
"retval %d\n", onetouch->udev->bus->bus_name,
--
1.9.1
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2016-01-17 12:40 +0100 |
| Subject | Re: [PATCH] Staging: usb: storage: onetouch: fixed parethesis and space style issue |
| Message-ID | <qRTQC-1PQ-11@gated-at.bofh.it> |
| In reply to | #1311121 |
On Sun, 2016-01-17 at 15:20 +0530, Tapan Prakash T wrote:
> Fixed two coding style issue.
Your email subject is not correct.
This driver is not in staging and there's
a trivial typo in parenthesis.
> diff --git a/drivers/usb/storage/onetouch.c b/drivers/usb/storage/onetouch.c
[]
> @@ -69,7 +69,7 @@ struct usb_onetouch {
> vendorName, productName, useProtocol, useTransport, \
> initFunction, flags) \
> { USB_DEVICE_VER(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax), \
> - .driver_info = (flags) }
> +.driver_info = (flags) }
A more typical style would have been to change
the space to a tab before .driver_info
> static struct usb_device_id onetouch_usb_ids[] = {
> # include "unusual_onetouch.h"
> @@ -125,7 +125,7 @@ static void usb_onetouch_irq(struct urb *urb)
> input_sync(dev);
>
> resubmit:
> - retval = usb_submit_urb (urb, GFP_ATOMIC);
> + retval = usb_submit_urb(urb, GFP_ATOMIC);
> if (retval)
> dev_err(&dev->dev, "can't resubmit intr, %s-%s/input0, "
> "retval %d\n", onetouch->udev->bus->bus_name,
And to coalesce the format string
dev_err(&dev->dev, "can't resubmit intr, %s-%s/input0, retval %d\n",
onetouch->udev->bus->bus_name,
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web