Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1311116 > unrolled thread
| Started by | Álvaro Fernández Rojas <noltari@gmail.com> |
|---|---|
| First post | 2016-01-17 10:10 +0100 |
| Last post | 2016-01-25 15:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/4] hw_random: bcm63xx-rng: remove unused variables Álvaro Fernández Rojas <noltari@gmail.com> - 2016-01-17 10:10 +0100
Re: [PATCH 1/4] hw_random: bcm63xx-rng: remove unused variables Florian Fainelli <f.fainelli@gmail.com> - 2016-01-18 20:10 +0100
Re: [PATCH 1/4] hw_random: bcm63xx-rng: remove unused variables Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-25 15:50 +0100
| From | Álvaro Fernández Rojas <noltari@gmail.com> |
|---|---|
| Date | 2016-01-17 10:10 +0100 |
| Subject | [PATCH 1/4] hw_random: bcm63xx-rng: remove unused variables |
| Message-ID | <qRRvt-sF-9@gated-at.bofh.it> |
These variables where left as unused in commit 6229c16060fe
("hwrng: bcm63xx - make use of devm_hwrng_register")
Fixes the following warning:
drivers/char/hw_random/bcm63xx-rng.c: In function 'bcm63xx_rng_probe':
drivers/char/hw_random/bcm63xx-rng.c:85:16: warning: unused variable 'rng'
[-Wunused-variable]
struct hwrng *rng;
^
drivers/char/hw_random/bcm63xx-rng.c:82:14: warning: unused variable 'clk'
[-Wunused-variable]
struct clk *clk;
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
drivers/char/hw_random/bcm63xx-rng.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c
index 4b31f13..c303f30 100644
--- a/drivers/char/hw_random/bcm63xx-rng.c
+++ b/drivers/char/hw_random/bcm63xx-rng.c
@@ -79,10 +79,8 @@ static int bcm63xx_rng_data_read(struct hwrng *rng, u32 *data)
static int bcm63xx_rng_probe(struct platform_device *pdev)
{
struct resource *r;
- struct clk *clk;
int ret;
struct bcm63xx_rng_priv *priv;
- struct hwrng *rng;
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!r) {
--
1.9.1
[toc] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2016-01-18 20:10 +0100 |
| Message-ID | <qSnlE-4YU-15@gated-at.bofh.it> |
| In reply to | #1311116 |
Le 17/01/2016 01:03, Álvaro Fernández Rojas a écrit :
> These variables where left as unused in commit 6229c16060fe
> ("hwrng: bcm63xx - make use of devm_hwrng_register")
>
> Fixes the following warning:
> drivers/char/hw_random/bcm63xx-rng.c: In function 'bcm63xx_rng_probe':
> drivers/char/hw_random/bcm63xx-rng.c:85:16: warning: unused variable 'rng'
> [-Wunused-variable]
> struct hwrng *rng;
> ^
> drivers/char/hw_random/bcm63xx-rng.c:82:14: warning: unused variable 'clk'
> [-Wunused-variable]
> struct clk *clk;
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
[toc] | [prev] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2016-01-25 15:50 +0100 |
| Message-ID | <qUQCS-5sa-27@gated-at.bofh.it> |
| In reply to | #1311116 |
On Sun, Jan 17, 2016 at 10:03:54AM +0100, Álvaro Fernández Rojas wrote:
> These variables where left as unused in commit 6229c16060fe
> ("hwrng: bcm63xx - make use of devm_hwrng_register")
>
> Fixes the following warning:
> drivers/char/hw_random/bcm63xx-rng.c: In function 'bcm63xx_rng_probe':
> drivers/char/hw_random/bcm63xx-rng.c:85:16: warning: unused variable 'rng'
> [-Wunused-variable]
> struct hwrng *rng;
> ^
> drivers/char/hw_random/bcm63xx-rng.c:82:14: warning: unused variable 'clk'
> [-Wunused-variable]
> struct clk *clk;
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
All applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web