Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1311114 > unrolled thread
| Started by | Álvaro Fernández Rojas <noltari@gmail.com> |
|---|---|
| First post | 2016-01-17 10:10 +0100 |
| Last post | 2016-01-18 20:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 2/4] hw_random: bcm63xx-rng: add device tree support Álvaro Fernández Rojas <noltari@gmail.com> - 2016-01-17 10:10 +0100
Re: [PATCH 2/4] hw_random: bcm63xx-rng: add device tree support Florian Fainelli <f.fainelli@gmail.com> - 2016-01-18 20:20 +0100
| From | Álvaro Fernández Rojas <noltari@gmail.com> |
|---|---|
| Date | 2016-01-17 10:10 +0100 |
| Subject | [PATCH 2/4] hw_random: bcm63xx-rng: add device tree support |
| Message-ID | <qRRvs-sF-1@gated-at.bofh.it> |
Adds device tree support for BCM6368, which seems to be the only BCM63xx with
bcm63xx-rng support.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
drivers/char/hw_random/bcm63xx-rng.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c
index c303f30..38553f0 100644
--- a/drivers/char/hw_random/bcm63xx-rng.c
+++ b/drivers/char/hw_random/bcm63xx-rng.c
@@ -130,10 +130,17 @@ static int bcm63xx_rng_probe(struct platform_device *pdev)
return 0;
}
+static const struct of_device_id bcm63xx_rng_of_match[] = {
+ { .compatible = "brcm,bcm6368-rng", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, bcm63xx_rng_of_match);
+
static struct platform_driver bcm63xx_rng_driver = {
.probe = bcm63xx_rng_probe,
.driver = {
.name = "bcm63xx-rng",
+ .of_match_table = bcm63xx_rng_of_match,
},
};
--
1.9.1
[toc] | [next] | [standalone]
| From | Florian Fainelli <f.fainelli@gmail.com> |
|---|---|
| Date | 2016-01-18 20:20 +0100 |
| Message-ID | <qSnvk-52j-11@gated-at.bofh.it> |
| In reply to | #1311114 |
Le 17/01/2016 01:03, Álvaro Fernández Rojas a écrit :
> Adds device tree support for BCM6368, which seems to be the only BCM63xx with
> bcm63xx-rng support.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> drivers/char/hw_random/bcm63xx-rng.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c
> index c303f30..38553f0 100644
> --- a/drivers/char/hw_random/bcm63xx-rng.c
> +++ b/drivers/char/hw_random/bcm63xx-rng.c
> @@ -130,10 +130,17 @@ static int bcm63xx_rng_probe(struct platform_device *pdev)
> return 0;
> }
>
#ifdef CONFIG_OF here?
> +static const struct of_device_id bcm63xx_rng_of_match[] = {
> + { .compatible = "brcm,bcm6368-rng", },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, bcm63xx_rng_of_match);
> +
> static struct platform_driver bcm63xx_rng_driver = {
> .probe = bcm63xx_rng_probe,
> .driver = {
> .name = "bcm63xx-rng",
> + .of_match_table = bcm63xx_rng_of_match,
of_match_ptr(bcm63xx_rng_of_match) would be nice here as well since we
can still build this driver for BCM63XX which is not OF enabled.
Other than that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web