Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1310999 > unrolled thread
| Started by | Borislav Petkov <bp@alien8.de> |
|---|---|
| First post | 2016-01-16 17:50 +0100 |
| Last post | 2016-01-18 01:20 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list Borislav Petkov <bp@alien8.de> - 2016-01-16 17:50 +0100
Re: include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list Johannes Weiner <hannes@cmpxchg.org> - 2016-01-18 01:10 +0100
Re: include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list Borislav Petkov <bp@alien8.de> - 2016-01-18 01:20 +0100
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2016-01-16 17:50 +0100 |
| Subject | include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list |
| Message-ID | <qRCd4-6Po-7@gated-at.bofh.it> |
Moin Johannes,
you're the last touching net/ipv4/tcp_memcontrol.c, so here you go :-P
In file included from net/ipv4/tcp_ipv4.c:76:0:
include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
^
include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv6/tcp_ipv6.c:64:0:
include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
^
include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want
In file included from net/ipv4/sysctl_net_ipv4.c:27:0:
include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list
int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
^
include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
[toc] | [next] | [standalone]
| From | Johannes Weiner <hannes@cmpxchg.org> |
|---|---|
| Date | 2016-01-18 01:10 +0100 |
| Message-ID | <qS5yr-1iK-27@gated-at.bofh.it> |
| In reply to | #1310999 |
Guten Nachmittag Boris, On Sat, Jan 16, 2016 at 05:48:33PM +0100, Borislav Petkov wrote: > In file included from net/ipv4/tcp_ipv4.c:76:0: > include/net/tcp_memcontrol.h:4:54: warning: ‘struct cgroup_subsys’ declared inside parameter list > int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss); > ^ > include/net/tcp_memcontrol.h:4:54: warning: its scope is only this definition or declaration, which is probably not what you want thanks for the report. All this code (tcp_memcontrol.*) is already deleted in -mm, so the issue should be fixed once Andrew sends the next batch for this merge window linuswards.
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2016-01-18 01:20 +0100 |
| Message-ID | <qS5I6-1mb-5@gated-at.bofh.it> |
| In reply to | #1311203 |
On Sun, Jan 17, 2016 at 07:05:57PM -0500, Johannes Weiner wrote:
> thanks for the report. All this code (tcp_memcontrol.*) is already
> deleted in -mm, so the issue should be fixed once Andrew sends the
> next batch for this merge window linuswards.
I see David applied this:
https://lkml.kernel.org/r/1453026637-9942-1-git-send-email-geert@linux-m68k.org
I guess it is moot now.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web