Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1309955 > unrolled thread

[PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-15 09:40 +0100
    Re: [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy  interrupt Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-01-22 17:20 +0100

#1309955 — [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt

No interrupt were received from the phy because PIOE 1 may not be properly
muxed. It prevented proper link detection, especially since commit
321beec5047a ("net: phy: Use interrupts when available in NOLINK state")
disables polling.

Cc: <stable@vger.kernel.org> # 4.4
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
 arch/arm/boot/dts/at91-sama5d4_xplained.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
index 131614f28e75..8cf9999cb0cd 100644
--- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
@@ -86,6 +86,8 @@
 			macb0: ethernet@f8020000 {
 				phy-mode = "rmii";
 				status = "okay";
+				pinctrl-names = "default";
+				pinctrl-0 = <&pinctrl_macb0_rmii &pinctrl_macb0_phy_irq>;
 
 				phy0: ethernet-phy@1 {
 					interrupt-parent = <&pioE>;
@@ -152,6 +154,10 @@
 						atmel,pins =
 							<AT91_PIOE 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
 					};
+					pinctrl_macb0_phy_irq: macb0_phy_irq_0 {
+						atmel,pins =
+							<AT91_PIOE 1 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
+					};
 				};
 			};
 		};
-- 
2.5.0

[toc] | [next] | [standalone]

#1315109 — Re: [PATCH] ARM: dts: at91: sama5d4_xplained: properly mux phy interrupt

Le 15/01/2016 09:30, Alexandre Belloni a écrit :
> No interrupt were received from the phy because PIOE 1 may not be properly
> muxed. It prevented proper link detection, especially since commit
> 321beec5047a ("net: phy: Use interrupts when available in NOLINK state")
> disables polling.
> 
> Cc: <stable@vger.kernel.org> # 4.4
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

And added to the upcoming at91-4.5-fixes branch.

thanks!


> ---
>  arch/arm/boot/dts/at91-sama5d4_xplained.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> index 131614f28e75..8cf9999cb0cd 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts
> @@ -86,6 +86,8 @@
>  			macb0: ethernet@f8020000 {
>  				phy-mode = "rmii";
>  				status = "okay";
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&pinctrl_macb0_rmii &pinctrl_macb0_phy_irq>;
>  
>  				phy0: ethernet-phy@1 {
>  					interrupt-parent = <&pioE>;
> @@ -152,6 +154,10 @@
>  						atmel,pins =
>  							<AT91_PIOE 8 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
>  					};
> +					pinctrl_macb0_phy_irq: macb0_phy_irq_0 {
> +						atmel,pins =
> +							<AT91_PIOE 1 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> +					};
>  				};
>  			};
>  		};
> 


-- 
Nicolas Ferre

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web