Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1309858 > unrolled thread

[PATCH v3 5/9] perf build: Add feature-dump target

Started byWang Nan <wangnan0@huawei.com>
First post2016-01-15 05:10 +0100
Last post2016-01-19 14:40 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v3 5/9] perf build: Add feature-dump target Wang Nan <wangnan0@huawei.com> - 2016-01-15 05:10 +0100
    Re: [PATCH v3 5/9] perf build: Add feature-dump target Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-15 20:20 +0100
      Re: [PATCH v3 5/9] perf build: Add feature-dump target Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-15 20:30 +0100
        Re: [PATCH v3 5/9] perf build: Add feature-dump target Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-15 20:30 +0100
    [tip:perf/urgent] perf build: Add feature-dump target tip-bot for Jiri Olsa <tipbot@zytor.com> - 2016-01-19 14:40 +0100

#1309858 — [PATCH v3 5/9] perf build: Add feature-dump target

FromWang Nan <wangnan0@huawei.com>
Date2016-01-15 05:10 +0100
Subject[PATCH v3 5/9] perf build: Add feature-dump target
Message-ID<qR3S2-Fo-5@gated-at.bofh.it>
From: Jiri Olsa <jolsa@kernel.org>

To provide FEATURE-DUMP into $(FEATURE_DUMP_COPY)
if defined, with no further action.

Get feature dump of the current build:
  $ make feature-dump
    BUILD:   Doing 'make -j4' parallel build

  Auto-detecting system features:
  ...                         dwarf: [ on  ]

  FEATURE-DUMP file available in FEATURE-DUMP

Get feature dump static build into /tmp/fd file:
  $ make feature-dump FEATURE_DUMP_COPY=/tmp/fd LDFLAGS=-static
    BUILD:   Doing 'make -j4' parallel build

  Auto-detecting system features:
  ...                         dwarf: [ OFF ]

  SNIP

  FEATURE-DUMP file copied into /tmp/fd

Suggested-by: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-xzqhfxw3euqmls3cve0ruuol@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Wang Nan <wangnan0@huawei.com>
---
 tools/perf/Makefile.perf | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 0a22407..f758a72 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -611,6 +611,17 @@ clean: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean
 	$(python-clean)
 
 #
+# To provide FEATURE-DUMP into $(FEATURE_DUMP_COPY)
+# file if defined, with no further action.
+feature-dump:
+ifdef FEATURE_DUMP_COPY
+	@cp $(OUTPUT)FEATURE-DUMP $(FEATURE_DUMP_COPY)
+	@echo "FEATURE-DUMP file copied into $(FEATURE_DUMP_COPY)"
+else
+	@echo "FEATURE-DUMP file available in $(OUTPUT)FEATURE-DUMP"
+endif
+
+#
 # Trick: if ../../.git does not exist - we are building out of tree for example,
 # then force version regeneration:
 #
-- 
1.8.3.4

[toc] | [next] | [standalone]

#1310392

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2016-01-15 20:20 +0100
Message-ID<qRi4H-204-31@gated-at.bofh.it>
In reply to#1309858
Em Fri, Jan 15, 2016 at 04:00:17AM +0000, Wang Nan escreveu:
> From: Jiri Olsa <jolsa@kernel.org>
> 
> To provide FEATURE-DUMP into $(FEATURE_DUMP_COPY)
> if defined, with no further action.
> 
> Get feature dump of the current build:
>   $ make feature-dump
>     BUILD:   Doing 'make -j4' parallel build
> 
>   Auto-detecting system features:
>   ...                         dwarf: [ on  ]
> 
>   FEATURE-DUMP file available in FEATURE-DUMP

Trying to improve this, i.e. provide an absolute or relative path to where
the file is really generated.

[acme@zoo linux]$ make -C tools/perf feature-dump
make: Entering directory '/home/git/linux/tools/perf'
  BUILD:   Doing 'make -j4' parallel build

Auto-detecting system features:
...                         dwarf: [ on  ]
...                         glibc: [ on  ]
...                          gtk2: [ on  ]
...                      libaudit: [ on  ]
...                        libbfd: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                      libslang: [ on  ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]

FEATURE-DUMP file available in FEATURE-DUMP
make: Leaving directory '/home/git/linux/tools/perf'
[acme@zoo linux]$ cat FEATURE-DUMP
cat: FEATURE-DUMP: No such file or directory
[acme@zoo linux]$ find . -name FEATURE-DUMP
./tools/perf/FEATURE-DUMP
[acme@zoo linux]$

[toc] | [prev] | [next] | [standalone]

#1310394

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2016-01-15 20:30 +0100
Message-ID<qRiem-23s-7@gated-at.bofh.it>
In reply to#1310392
Em Fri, Jan 15, 2016 at 04:11:39PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Jan 15, 2016 at 04:00:17AM +0000, Wang Nan escreveu:
> > From: Jiri Olsa <jolsa@kernel.org>
> > 
> > To provide FEATURE-DUMP into $(FEATURE_DUMP_COPY)
> > if defined, with no further action.
> > 
> > Get feature dump of the current build:
> >   $ make feature-dump
> >     BUILD:   Doing 'make -j4' parallel build
> > 
> >   Auto-detecting system features:
> >   ...                         dwarf: [ on  ]
> > 
> >   FEATURE-DUMP file available in FEATURE-DUMP
> 
> Trying to improve this, i.e. provide an absolute or relative path to where
> the file is really generated.
> 
> 
> FEATURE-DUMP file available in FEATURE-DUMP
> make: Leaving directory '/home/git/linux/tools/perf'
> [acme@zoo linux]$ cat FEATURE-DUMP
> cat: FEATURE-DUMP: No such file or directory
> [acme@zoo linux]$ find . -name FEATURE-DUMP
> ./tools/perf/FEATURE-DUMP
> [acme@zoo linux]$ 

Like what is done here already:

$(LIBBPF): fixdep FORCE
        $(Q)$(MAKE) -C $(BPF_DIR) O=$(OUTPUT) $(OUTPUT)libbpf.a FEATURES_DUMP=$(realpath $(OUTPUT)FEATURE-DUMP)

I.e. use realphat, like:


[acme@zoo linux]$ git diff
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index f758a72df1b3..ec701e61c9bd 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -618,7 +618,7 @@ ifdef FEATURE_DUMP_COPY
        @cp $(OUTPUT)FEATURE-DUMP $(FEATURE_DUMP_COPY)
        @echo "FEATURE-DUMP file copied into $(FEATURE_DUMP_COPY)"
 else
-       @echo "FEATURE-DUMP file available in $(OUTPUT)FEATURE-DUMP"
+       @echo "FEATURE-DUMP file available in $(realpath $(OUTPUT)FEATURE-DUMP)"
 endif
 
 #
[acme@zoo linux]$ make -C tools/perf feature-dump
make: Entering directory '/home/git/linux/tools/perf'
  BUILD:   Doing 'make -j4' parallel build

Auto-detecting system features:
...                         dwarf: [ on  ]
...                         glibc: [ on  ]
...                          gtk2: [ on  ]
...                      libaudit: [ on  ]
...                        libbfd: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...        numa_num_possible_cpus: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                      libslang: [ on  ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]

FEATURE-DUMP file available in /home/git/linux/tools/perf/FEATURE-DUMP
make: Leaving directory '/home/git/linux/tools/perf'
[acme@zoo linux]$


Nitpicking a bit: libbpf uses FEATURES_DUMP, i.e. plural, which I think
is the proper naming, as there are multiple features being detected and
thus dumped, would you mind if I chainsaw it all into consistency using
FEATURES-DUMP, FEATURES_DUMP, etc?

- Arnaldo

[toc] | [prev] | [next] | [standalone]

#1310401

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2016-01-15 20:30 +0100
Message-ID<qRien-23s-25@gated-at.bofh.it>
In reply to#1310394
Em Fri, Jan 15, 2016 at 04:23:52PM -0300, Arnaldo Carvalho de Melo escreveu:
> Nitpicking a bit: libbpf uses FEATURES_DUMP, i.e. plural, which I think
> is the proper naming, as there are multiple features being detected and
> thus dumped, would you mind if I chainsaw it all into consistency using
> FEATURES-DUMP, FEATURES_DUMP, etc?

Oh well, saw the next patch in this series, it then uses FEATURES_DUMP,
will leave this for later when the whole series gets applied...

- Arnaldo

[toc] | [prev] | [next] | [standalone]

#1312228 — [tip:perf/urgent] perf build: Add feature-dump target

Fromtip-bot for Jiri Olsa <tipbot@zytor.com>
Date2016-01-19 14:40 +0100
Subject[tip:perf/urgent] perf build: Add feature-dump target
Message-ID<qSEFP-4S-5@gated-at.bofh.it>
In reply to#1309858
Commit-ID:  b8e52be00ca7e7659e8ee172ce9e6f0c6af28ec8
Gitweb:     http://git.kernel.org/tip/b8e52be00ca7e7659e8ee172ce9e6f0c6af28ec8
Author:     Jiri Olsa <jolsa@kernel.org>
AuthorDate: Fri, 15 Jan 2016 04:00:17 +0000
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 15 Jan 2016 16:32:00 -0300

perf build: Add feature-dump target

To provide FEATURE-DUMP into $(FEATURE_DUMP_COPY) if defined, with no
further action.

Get feature dump of the current build:
  $ make feature-dump
    BUILD:   Doing 'make -j4' parallel build

  Auto-detecting system features:
  ...                         dwarf: [ on  ]

  FEATURE-DUMP file available in FEATURE-DUMP

Get feature dump static build into /tmp/fd file:

  $ make feature-dump FEATURE_DUMP_COPY=/tmp/fd LDFLAGS=-static
    BUILD:   Doing 'make -j4' parallel build

  Auto-detecting system features:
  ...                         dwarf: [ OFF ]

  SNIP

  FEATURE-DUMP file copied into /tmp/fd

Suggested-by: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1452830421-77757-6-git-send-email-wangnan0@huawei.com
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile.perf | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 0a22407..f758a72 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -611,6 +611,17 @@ clean: $(LIBTRACEEVENT)-clean $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean
 	$(python-clean)
 
 #
+# To provide FEATURE-DUMP into $(FEATURE_DUMP_COPY)
+# file if defined, with no further action.
+feature-dump:
+ifdef FEATURE_DUMP_COPY
+	@cp $(OUTPUT)FEATURE-DUMP $(FEATURE_DUMP_COPY)
+	@echo "FEATURE-DUMP file copied into $(FEATURE_DUMP_COPY)"
+else
+	@echo "FEATURE-DUMP file available in $(OUTPUT)FEATURE-DUMP"
+endif
+
+#
 # Trick: if ../../.git does not exist - we are building out of tree for example,
 # then force version regeneration:
 #

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web