Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1309777 > unrolled thread
| Started by | Anders Roxell <anders.roxell@linaro.org> |
|---|---|
| First post | 2016-01-15 01:20 +0100 |
| Last post | 2016-01-25 12:20 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] drivers/media: vsp1_video: fix compile error Anders Roxell <anders.roxell@linaro.org> - 2016-01-15 01:20 +0100
Re: [PATCH] drivers/media: vsp1_video: fix compile error Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-01-25 07:30 +0100
Re: [PATCH] drivers/media: vsp1_video: fix compile error Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-01-25 12:20 +0100
| From | Anders Roxell <anders.roxell@linaro.org> |
|---|---|
| Date | 2016-01-15 01:20 +0100 |
| Subject | [PATCH] drivers/media: vsp1_video: fix compile error |
| Message-ID | <qR0hr-6sG-1@gated-at.bofh.it> |
This was found with the -RT patch enabled, but the fix should apply to
non-RT also.
Compilation error without this fix:
../drivers/media/platform/vsp1/vsp1_video.c: In function
'vsp1_pipeline_stopped':
../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected
expression before 'do'
spin_unlock_irqrestore(&pipe->irqlock, flags);
^
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/media/platform/vsp1/vsp1_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c
index 637d0d6..b4dca57 100644
--- a/drivers/media/platform/vsp1/vsp1_video.c
+++ b/drivers/media/platform/vsp1/vsp1_video.c
@@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline *pipe)
bool stopped;
spin_lock_irqsave(&pipe->irqlock, flags);
- stopped = pipe->state == VSP1_PIPELINE_STOPPED,
+ stopped = pipe->state == VSP1_PIPELINE_STOPPED;
spin_unlock_irqrestore(&pipe->irqlock, flags);
return stopped;
--
2.1.4
[toc] | [next] | [standalone]
| From | Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
|---|---|
| Date | 2016-01-25 07:30 +0100 |
| Message-ID | <qUIP0-8jH-7@gated-at.bofh.it> |
| In reply to | #1309777 |
Hi Anders, Thank you for the patch. On Friday 15 January 2016 01:09:43 Anders Roxell wrote: > This was found with the -RT patch enabled, but the fix should apply to > non-RT also. > > Compilation error without this fix: > ../drivers/media/platform/vsp1/vsp1_video.c: In function > 'vsp1_pipeline_stopped': > ../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected > expression before 'do' > spin_unlock_irqrestore(&pipe->irqlock, flags); > ^ > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> and applied to my tree. > --- > drivers/media/platform/vsp1/vsp1_video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_video.c > b/drivers/media/platform/vsp1/vsp1_video.c index 637d0d6..b4dca57 100644 > --- a/drivers/media/platform/vsp1/vsp1_video.c > +++ b/drivers/media/platform/vsp1/vsp1_video.c > @@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline > *pipe) bool stopped; > > spin_lock_irqsave(&pipe->irqlock, flags); > - stopped = pipe->state == VSP1_PIPELINE_STOPPED, > + stopped = pipe->state == VSP1_PIPELINE_STOPPED; > spin_unlock_irqrestore(&pipe->irqlock, flags); > > return stopped; -- Regards, Laurent Pinchart
[toc] | [prev] | [next] | [standalone]
| From | Mauro Carvalho Chehab <mchehab@osg.samsung.com> |
|---|---|
| Date | 2016-01-25 12:20 +0100 |
| Message-ID | <qUNlE-33Y-13@gated-at.bofh.it> |
| In reply to | #1316241 |
Em Mon, 25 Jan 2016 00:15:28 +0200 Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > Hi Anders, > > Thank you for the patch. > > On Friday 15 January 2016 01:09:43 Anders Roxell wrote: > > This was found with the -RT patch enabled, but the fix should apply to > > non-RT also. > > > > Compilation error without this fix: > > ../drivers/media/platform/vsp1/vsp1_video.c: In function > > 'vsp1_pipeline_stopped': > > ../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected > > expression before 'do' > > spin_unlock_irqrestore(&pipe->irqlock, flags); > > ^ > > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > and applied to my tree. Better to apply this to the fixes branch and send it together with the next set of patches upstream. > > > --- > > drivers/media/platform/vsp1/vsp1_video.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/vsp1/vsp1_video.c > > b/drivers/media/platform/vsp1/vsp1_video.c index 637d0d6..b4dca57 100644 > > --- a/drivers/media/platform/vsp1/vsp1_video.c > > +++ b/drivers/media/platform/vsp1/vsp1_video.c > > @@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline > > *pipe) bool stopped; > > > > spin_lock_irqsave(&pipe->irqlock, flags); > > - stopped = pipe->state == VSP1_PIPELINE_STOPPED, > > + stopped = pipe->state == VSP1_PIPELINE_STOPPED; > > spin_unlock_irqrestore(&pipe->irqlock, flags); > > > > return stopped; >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web