Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1306483 > unrolled thread

[RFC][PATCH 00/12] various perf fixes

Back to article view | Back to linux.kernel

Contents

  [RFC][PATCH 00/12] various perf fixes Peter Zijlstra <peterz@infradead.org> - 2016-01-11 17:40 +0100
    [RFC][PATCH 06/12] perf: Use task_ctx_sched_out() Peter Zijlstra <peterz@infradead.org> - 2016-01-11 17:40 +0100
    [RFC][PATCH 05/12] perf: Fix enable_on_exec event scheduling Peter Zijlstra <peterz@infradead.org> - 2016-01-11 17:40 +0100
    [RFC][PATCH 10/12] perf: Fix task context scheduling Peter Zijlstra <peterz@infradead.org> - 2016-01-11 17:40 +0100
    [RFC][PATCH 07/12] perf: Simplify/fix perf_event_enable() event scheduling Peter Zijlstra <peterz@infradead.org> - 2016-01-11 17:40 +0100
    [RFC][PATCH 04/12] perf: Remove stale comment Peter Zijlstra <peterz@infradead.org> - 2016-01-11 17:40 +0100
    [RFC][PATCH 11/12] perf: Specialize perf_event_exit_task() Peter Zijlstra <peterz@infradead.org> - 2016-01-11 17:40 +0100
    Re: [RFC][PATCH 00/12] various perf fixes Dmitry Vyukov <dvyukov@google.com> - 2016-01-11 19:50 +0100
      Re: [RFC][PATCH 00/12] various perf fixes Andi Kleen <andi@firstfloor.org> - 2016-01-11 21:00 +0100
      Re: [RFC][PATCH 00/12] various perf fixes Peter Zijlstra <peterz@infradead.org> - 2016-01-11 23:10 +0100
        Re: [RFC][PATCH 00/12] various perf fixes Ingo Molnar <mingo@kernel.org> - 2016-01-12 11:00 +0100
    Re: [RFC][PATCH 00/12] various perf fixes Ingo Molnar <mingo@kernel.org> - 2016-01-12 11:20 +0100
      Re: [RFC][PATCH 00/12] various perf fixes Dmitry Vyukov <dvyukov@google.com> - 2016-01-12 12:00 +0100
        Re: [RFC][PATCH 00/12] various perf fixes Dmitry Vyukov <dvyukov@google.com> - 2016-01-12 12:10 +0100
          Re: [RFC][PATCH 00/12] various perf fixes Dmitry Vyukov <dvyukov@google.com> - 2016-01-12 12:10 +0100
            Re: [RFC][PATCH 00/12] various perf fixes Dmitry Vyukov <dvyukov@google.com> - 2016-01-12 12:30 +0100
              Re: [RFC][PATCH 00/12] various perf fixes Dmitry Vyukov <dvyukov@google.com> - 2016-01-12 12:40 +0100
              Re: [RFC][PATCH 00/12] various perf fixes Peter Zijlstra <peterz@infradead.org> - 2016-01-12 13:10 +0100
              Re: [RFC][PATCH 00/12] various perf fixes Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-01-13 16:20 +0100
                Re: [RFC][PATCH 00/12] various perf fixes Dmitry Vyukov <dvyukov@google.com> - 2016-01-13 16:30 +0100
                  Re: [RFC][PATCH 00/12] various perf fixes Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-01-13 16:40 +0100
              Re: [RFC][PATCH 00/12] various perf fixes Peter Zijlstra <peterz@infradead.org> - 2016-01-14 10:40 +0100
                Re: [RFC][PATCH 00/12] various perf fixes Dmitry Vyukov <dvyukov@google.com> - 2016-01-14 11:10 +0100
      Re: [RFC][PATCH 00/12] various perf fixes Peter Zijlstra <peterz@infradead.org> - 2016-01-12 14:20 +0100
        Re: [RFC][PATCH 00/12] various perf fixes Ingo Molnar <mingo@kernel.org> - 2016-01-12 14:40 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1308512

Dmitry Vyukov <dvyukov@google.com> writes:

> On Wed, Jan 13, 2016 at 4:18 PM, Alexander Shishkin
> <alexander.shishkin@linux.intel.com> wrote:
>> Dmitry Vyukov <dvyukov@google.com> writes:
>>
>>> 2016/01/12 12:08:26 qemu-12: saving crash 'WARNING: CPU: 2 PID: 26946
>>> at kernel/events/core.c:213 event_function+0x4ba/0x590()' to
>>
>> If you still have the code, can you check which of the WARN_ON_ONCE()s
>> is this?
>
> Here is my core.c
> https://gist.github.com/dvyukov/3b3a4993ade37e344636

Bingo! Thanks.

Regards,
--
Alex

[toc] | [prev] | [next] | [standalone]

#1309118

On Tue, Jan 12, 2016 at 12:26:27PM +0100, Dmitry Vyukov wrote:
> What do you think if we work on making syzkaller work for you locally?

There's no easy way to do this right? I had a look at that project on
github and it looks like the most complex test setup possible :-(

I don't generally do VMs so I'm not much good at setting those up nor do
I speak Go (although I did play the game a lot of years ago).

Isn't there an easy way to just run syz-fuzzer on a machine without all
the bells and whistles on?

[toc] | [prev] | [next] | [standalone]

#1309145

On Thu, Jan 14, 2016 at 10:35 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Jan 12, 2016 at 12:26:27PM +0100, Dmitry Vyukov wrote:
>> What do you think if we work on making syzkaller work for you locally?
>
> There's no easy way to do this right? I had a look at that project on
> github and it looks like the most complex test setup possible :-(
>
> I don't generally do VMs so I'm not much good at setting those up nor do
> I speak Go (although I did play the game a lot of years ago).
>
> Isn't there an easy way to just run syz-fuzzer on a machine without all
> the bells and whistles on?


There is a way to run it without coverage on a local machine.

First, you need to setup Go toolchain: download latest Go distribution
from https://golang.org/dl:
https://storage.googleapis.com/golang/go1.5.3.linux-amd64.tar.gz
Unpack it to $HOME/go1.5.

$ export GOROOT=$HOME/go1.5
$ export GOPATH=$HOME/gopath

Download syzkaller sources:

$ go get github.com/google/syzkaller

Build necessary syzkaller binaries:

$ cd $GOPATH/src/github.com/google/syzkaller
$ make

Then save the following content into
$GOPATH/src/github.com/google/syzkaller/perf.cfg

{
        "http": "localhost:50000",
        "workdir": "home/gopath/src/github.com/google/syzkaller/workdir",
        "syzkaller": "/home/gopath/src/github.com/google/syzkaller",
        "vmlinux": "-",
        "type": "local",
        "count": 1,
        "procs": 16,
        "nocover": true,
        "nodropprivs": true,
        "enable_syscalls": [
                "getpid",
                "perf_event_open",
                "ioctl$PERF*",
                "prctl$void",
                "bpf$*",
                "sched_yield"
        ]
}

Alter paths as necessary. Also you can change procs parameter (number
of parallel test processes), something like NCPU*4 would be a good
number. Also you can add additional syscalls to the mix.

Then run:

$ bin/syz-manager -config perf.cfg

If you run it on a separate test machine, then scp syzkaller/bin dir
and perf.cfg to the machine (the syzkaller param in config is where it
will search for the bin dir).

If syz-manager does not appear to be doing anything useful, then pleas
run it in the following mode and post output:

$ bin/syz-manager -config perf.cfg -v 1 -debug

[toc] | [prev] | [next] | [standalone]

#1307395

On Tue, Jan 12, 2016 at 11:11:09AM +0100, Ingo Molnar wrote:
> 
> * Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > Hi,
> > 
> > I've been hunting perf bugs for the past few weeks. This resulted in this pile
> > of patches, that mostly seems to work -- I still get an occasional fail so
> > something is still off.

 ^^^^

> Btw., if there's no test failures I plan to apply and push this to Linus fairly 
> soon, so guys please give it all the review and testing you can.

Dmitry also hit plenty fail, so please wait a little while. I'll take
another look tomorrow, but I just have to stare at something else for a
little while to reset my brain.

[toc] | [prev] | [next] | [standalone]

#1307402

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, Jan 12, 2016 at 11:11:09AM +0100, Ingo Molnar wrote:
> > 
> > * Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > Hi,
> > > 
> > > I've been hunting perf bugs for the past few weeks. This resulted in this pile
> > > of patches, that mostly seems to work -- I still get an occasional fail so
> > > something is still off.
> 
>  ^^^^
> 
> > Btw., if there's no test failures I plan to apply and push this to Linus fairly 
> > soon, so guys please give it all the review and testing you can.
> 
> Dmitry also hit plenty fail, so please wait a little while. I'll take
> another look tomorrow, but I just have to stare at something else for a
> little while to reset my brain.

Ok, fair enough!

Thanks,

	Ingo

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web