Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1306165 > unrolled thread

Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-11 14:00 +0100
    Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA Sakari Ailus <sakari.ailus@iki.fi> - 2016-01-12 15:20 +0100
      Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-12 17:10 +0100
      Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA Marek Szyprowski <m.szyprowski@samsung.com> - 2016-01-13 15:40 +0100
        Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA Sakari Ailus <sakari.ailus@iki.fi> - 2016-01-14 09:50 +0100

#1306165 — Re: [PATCH] [media] media: Kconfig: add dependency of HAS_DMA

On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> The build of m32r allmodconfig fails with the error:
> drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> 	error: implicit declaration of function 'dma_get_cache_alignment'
> 
> The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> videobuf2-dma-contig.c even though HAS_DMA is not defined.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---

A gentle ping. m32r allmodconfig still fails with next-20160111. Build
log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379

regards
sudip

[toc] | [next] | [standalone]

#1307460

On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
> On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> > The build of m32r allmodconfig fails with the error:
> > drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> > 	error: implicit declaration of function 'dma_get_cache_alignment'
> > 
> > The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> > correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> > selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> > videobuf2-dma-contig.c even though HAS_DMA is not defined.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> 
> A gentle ping. m32r allmodconfig still fails with next-20160111. Build
> log is at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379

Hi Sudip,

Even though the issue now manifests itself on m32r, the problem is wider
than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
set.

I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
disabled, so perhaps it'd be possible to make it depend on HAS_DMA.

Cc others.

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

[toc] | [prev] | [next] | [standalone]

#1307583

On Tue, Jan 12, 2016 at 04:10:43PM +0200, Sakari Ailus wrote:
> On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
> > On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> > > The build of m32r allmodconfig fails with the error:
> > > drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> > > 	error: implicit declaration of function 'dma_get_cache_alignment'
> > > 
> > > The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> > > correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> > > selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> > > videobuf2-dma-contig.c even though HAS_DMA is not defined.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > > ---
> > 
> > A gentle ping. m32r allmodconfig still fails with next-20160111. Build
> > log is at:
> > https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379
> 
> Hi Sudip,
> 
> Even though the issue now manifests itself on m32r, the problem is wider
> than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
> set.
> 
> I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
> disabled, so perhaps it'd be possible to make it depend on HAS_DMA.

I have checked with all the Kconfig which selects VIDEOBUF2_DMA_CONTIG
and all of them does depend on HAS_DMA. This is the only place where it
was missing.

regards
sudip

[toc] | [prev] | [next] | [standalone]

#1308466

Hello,

On 2016-01-12 15:10, Sakari Ailus wrote:
> On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
>> On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
>>> The build of m32r allmodconfig fails with the error:
>>> drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
>>> 	error: implicit declaration of function 'dma_get_cache_alignment'
>>>
>>> The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
>>> correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
>>> selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
>>> videobuf2-dma-contig.c even though HAS_DMA is not defined.
>>>
>>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>>> ---
>> A gentle ping. m32r allmodconfig still fails with next-20160111. Build
>> log is at:
>> https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379
> Hi Sudip,
>
> Even though the issue now manifests itself on m32r, the problem is wider
> than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
> set.
>
> I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
> disabled, so perhaps it'd be possible to make it depend on HAS_DMA.

VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select
directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies
are not checked further. This is known limitation/feature of kconfig system.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

[toc] | [prev] | [next] | [standalone]

#1309083

Hi Marek and Sudip,

On Wed, Jan 13, 2016 at 03:36:39PM +0100, Marek Szyprowski wrote:
> Hello,
> 
> On 2016-01-12 15:10, Sakari Ailus wrote:
> >On Mon, Jan 11, 2016 at 06:23:11PM +0530, Sudip Mukherjee wrote:
> >>On Wed, Dec 30, 2015 at 06:56:03PM +0530, Sudip Mukherjee wrote:
> >>>The build of m32r allmodconfig fails with the error:
> >>>drivers/media/v4l2-core/videobuf2-dma-contig.c:484:2:
> >>>	error: implicit declaration of function 'dma_get_cache_alignment'
> >>>
> >>>The build of videobuf2-dma-contig.c depends on HAS_DMA and it is
> >>>correctly mentioned in the Kconfig but the symbol VIDEO_STI_BDISP also
> >>>selects VIDEOBUF2_DMA_CONTIG, so it is trying to compile
> >>>videobuf2-dma-contig.c even though HAS_DMA is not defined.
> >>>
> >>>Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >>>---
> >>A gentle ping. m32r allmodconfig still fails with next-20160111. Build
> >>log is at:
> >>https://travis-ci.org/sudipm-mukherjee/parport/jobs/101536379
> >Hi Sudip,
> >
> >Even though the issue now manifests itself on m32r, the problem is wider
> >than that: dma_get_cache_alignment() is only defined if CONFIG_HAS_DMA is
> >set.
> >
> >I wonder if using videobuf2-dma-contig makes any sense if HAS_DMA is
> >disabled, so perhaps it'd be possible to make it depend on HAS_DMA.
> 
> VIDEOBUF2_DMA_CONTIG already depends on HAS_DMA, but when driver use select
> directive for enabling support for VIDEOBUF2_DMA_CONTIG, the dependencies
> are not checked further. This is known limitation/feature of kconfig system.

Thanks for the insight. Sounds like this is the right thing to do then.

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web