Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1308421 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-01-13 14:50 +0100 |
| Last post | 2016-01-13 15:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Arnd Bergmann <arnd@arndb.de> - 2016-01-13 14:50 +0100
Re: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Karol Herbst <nouveau@karolherbst.de> - 2016-01-13 15:00 +0100
Re: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Arnd Bergmann <arnd@arndb.de> - 2016-01-13 15:10 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-01-13 14:50 +0100 |
| Subject | [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype |
| Message-ID | <qQtYe-s0-13@gated-at.bofh.it> |
The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
is disabled:
In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nouveau_debugfs_init':
drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name omitted
nouveau_debugfs_init(struct nouveau_drm *)
This fixes the prototypes so we can build it again.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b126a200e9db ("drm/nouveau/debugfs: we need a ctrl object for debugfs")
---
This broke when the nouveau patches got merged into drm-next on Monday.
Found on ARM randconfig builds.
diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.h b/drivers/gpu/drm/nouveau/nouveau_debugfs.h
index 52c7161297d7..b8c03ff5bf05 100644
--- a/drivers/gpu/drm/nouveau/nouveau_debugfs.h
+++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.h
@@ -34,13 +34,13 @@ nouveau_drm_debugfs_cleanup(struct drm_minor *minor)
}
static inline int
-nouveau_debugfs_init(struct nouveau_drm *)
+nouveau_debugfs_init(struct nouveau_drm *drm)
{
return 0;
}
static inline void
-nouveau_debugfs_fini(struct nouveau_drm *)
+nouveau_debugfs_fini(struct nouveau_drm *drm)
{
}
[toc] | [next] | [standalone]
| From | Karol Herbst <nouveau@karolherbst.de> |
|---|---|
| Date | 2016-01-13 15:00 +0100 |
| Message-ID | <qQu7U-vr-5@gated-at.bofh.it> |
| In reply to | #1308421 |
> Arnd Bergmann <arnd@arndb.de> hat am 13. Januar 2016 um 14:48 geschrieben:
>
> The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
> is disabled:
>
> In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
> drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nouveau_debugfs_init':
> drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name omitted
> nouveau_debugfs_init(struct nouveau_drm *)
>
> This fixes the prototypes so we can build it again.
>
thanks for this. I already send a patch to the nouveau ML here:
http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html
but I guess I should mail to the kernel list directly next time.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b126a200e9db ("drm/nouveau/debugfs: we need a ctrl object for debugfs")
> ---
> This broke when the nouveau patches got merged into drm-next on Monday.
> Found on ARM randconfig builds.
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> b/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> index 52c7161297d7..b8c03ff5bf05 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> @@ -34,13 +34,13 @@ nouveau_drm_debugfs_cleanup(struct drm_minor *minor)
> }
>
> static inline int
> -nouveau_debugfs_init(struct nouveau_drm *)
> +nouveau_debugfs_init(struct nouveau_drm *drm)
> {
> return 0;
> }
>
> static inline void
> -nouveau_debugfs_fini(struct nouveau_drm *)
> +nouveau_debugfs_fini(struct nouveau_drm *drm)
> {
> }
>
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-01-13 15:10 +0100 |
| Message-ID | <qQuhz-Oj-1@gated-at.bofh.it> |
| In reply to | #1308427 |
On Wednesday 13 January 2016 14:55:47 Karol Herbst wrote: > > Arnd Bergmann <arnd@arndb.de> hat am 13. Januar 2016 um 14:48 geschrieben: > > > > The new debugfs initialization code fails to build when CONFIG_DEBUG_FS > > is disabled: > > > > In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0: > > drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nouveau_debugfs_init': > > drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name omitted > > nouveau_debugfs_init(struct nouveau_drm *) > > > > This fixes the prototypes so we can build it again. > > > > thanks for this. I already send a patch to the nouveau ML here: > http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html Ok, thanks Arnd
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web