Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1308349 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-01-13 13:30 +0100 |
| Last post | 2016-01-13 13:50 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set_link() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-13 13:30 +0100
Re: [patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set_link() Karol Herbst <nouveau@karolherbst.de> - 2016-01-13 13:40 +0100
Re: [patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set_link() Karol Herbst <desurium@karolherbst.de> - 2016-01-13 13:50 +0100
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-01-13 13:30 +0100 |
| Subject | [patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set_link() |
| Message-ID | <qQsIO-84i-7@gated-at.bofh.it> |
The condition is reversed so this function is a no-op.
Fixes: bcc19d9bf5cd ('drm/nouveau/pci: implement generic code for pcie speed change')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
index b32954f..d71e5db 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
@@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum nvkm_pcie_speed speed, u8 width)
struct pci_bus *pbus;
int ret;
- if (pci || !pci_is_pcie(pci->pdev))
+ if (!pci || !pci_is_pcie(pci->pdev))
return 0;
pbus = pci->pdev->bus;
[toc] | [next] | [standalone]
| From | Karol Herbst <nouveau@karolherbst.de> |
|---|---|
| Date | 2016-01-13 13:40 +0100 |
| Subject | Re: [patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set_link() |
| Message-ID | <qQsSu-89F-9@gated-at.bofh.it> |
| In reply to | #1308349 |
Hi Dan,
yeah I also catched that. I assume something went wrong in the review process,
because I am sure I didn't added that "pci ||" check myself ;) but who knows,
maybe I was tired working with ben on that, cause it was like 4am while doing
the last polishing steps.
nvm, I already send a patch to the nouveau ML:
http://lists.freedesktop.org/archives/nouveau/2016-January/023772.html
I just tried to poke ben the last day like several times, but he didn't seem to
be there yesterday
> Dan Carpenter <dan.carpenter@oracle.com> hat am 13. Januar 2016 um 13:21
> geschrieben:
>
> The condition is reversed so this function is a no-op.
>
> Fixes: bcc19d9bf5cd ('drm/nouveau/pci: implement generic code for pcie speed
> change')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> index b32954f..d71e5db 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> @@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum
> nvkm_pcie_speed speed, u8 width)
> struct pci_bus *pbus;
> int ret;
>
> - if (pci || !pci_is_pcie(pci->pdev))
> + if (!pci || !pci_is_pcie(pci->pdev))
> return 0;
> pbus = pci->pdev->bus;
>
[toc] | [prev] | [next] | [standalone]
| From | Karol Herbst <desurium@karolherbst.de> |
|---|---|
| Date | 2016-01-13 13:50 +0100 |
| Subject | Re: [patch] drm/nouveau/pci: reversed condition in nvkm_pcie_set_link() |
| Message-ID | <qQt2a-8ek-3@gated-at.bofh.it> |
| In reply to | #1308358 |
> Karol Herbst <nouveau@karolherbst.de> hat am 13. Januar 2016 um 13:30
> geschrieben:
>
> Hi Dan,
>
> yeah I also catched that. I assume something went wrong in the review process,
> because I am sure I didn't added that "pci ||" check myself ;) but who knows,
> maybe I was tired working with ben on that, cause it was like 4am while doing
maybe I chose the wrong words here. Seems like I still need to improve my
english here and there ;)
I meant that I was literally tired, cause it was 4am, not that I was tired
because of ben. Just clarify that before somebody thinks I am a mean person.
> the last polishing steps.
>
> nvm, I already send a patch to the nouveau ML:
> http://lists.freedesktop.org/archives/nouveau/2016-January/023772.html
>
> I just tried to poke ben the last day like several times, but he didn't seem
> to
> be there yesterday
>
> > Dan Carpenter <dan.carpenter@oracle.com> hat am 13. Januar 2016 um 13:21
> > geschrieben:
> >
> > The condition is reversed so this function is a no-op.
> >
> > Fixes: bcc19d9bf5cd ('drm/nouveau/pci: implement generic code for pcie speed
> > change')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> > b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> > index b32954f..d71e5db 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c
> > @@ -119,7 +119,7 @@ nvkm_pcie_set_link(struct nvkm_pci *pci, enum
> > nvkm_pcie_speed speed, u8 width)
> > struct pci_bus *pbus;
> > int ret;
> >
> > - if (pci || !pci_is_pcie(pci->pdev))
> > + if (!pci || !pci_is_pcie(pci->pdev))
> > return 0;
> > pbus = pci->pdev->bus;
>
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web