Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1306107 > unrolled thread

[PATCH 2/2] crypto: s5p-sss - Use memcpy_toio for iomem annotated memory

Started byKrzysztof Kozlowski <k.kozlowski.k@gmail.com>
First post2016-01-11 12:50 +0100
Last post2016-01-13 04:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/2] crypto: s5p-sss - Use memcpy_toio for iomem annotated memory Krzysztof Kozlowski <k.kozlowski.k@gmail.com> - 2016-01-11 12:50 +0100
    Re: [PATCH 2/2] crypto: s5p-sss - Use memcpy_toio for iomem annotated  memory Vladimir Zapolskiy <vz@mleia.com> - 2016-01-13 04:10 +0100

#1306107 — [PATCH 2/2] crypto: s5p-sss - Use memcpy_toio for iomem annotated memory

FromKrzysztof Kozlowski <k.kozlowski.k@gmail.com>
Date2016-01-11 12:50 +0100
Subject[PATCH 2/2] crypto: s5p-sss - Use memcpy_toio for iomem annotated memory
Message-ID<qPJ90-1Mh-3@gated-at.bofh.it>
Use memcpy_toio to fix following sparse warning:

drivers/crypto/s5p-sss.c:386:40: warning: incorrect type in argument 1 (different address spaces)
drivers/crypto/s5p-sss.c:386:40:    expected void *<noident>
drivers/crypto/s5p-sss.c:386:40:    got void [noderef] <asn:2>*

Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
---
 drivers/crypto/s5p-sss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index e10284744fd2..5f161a9777e3 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -383,7 +383,7 @@ static void s5p_set_aes(struct s5p_aes_dev *dev,
 	void __iomem *keystart;
 
 	if (iv)
-		memcpy(dev->aes_ioaddr + SSS_REG_AES_IV_DATA(0), iv, 0x10);
+		memcpy_toio(dev->aes_ioaddr + SSS_REG_AES_IV_DATA(0), iv, 0x10);
 
 	if (keylen == AES_KEYSIZE_256)
 		keystart = dev->aes_ioaddr + SSS_REG_AES_KEY_DATA(0);
@@ -392,7 +392,7 @@ static void s5p_set_aes(struct s5p_aes_dev *dev,
 	else
 		keystart = dev->aes_ioaddr + SSS_REG_AES_KEY_DATA(4);
 
-	memcpy(keystart, key, keylen);
+	memcpy_toio(keystart, key, keylen);
 }
 
 static void s5p_aes_crypt_start(struct s5p_aes_dev *dev, unsigned long mode)
-- 
2.1.4

[toc] | [next] | [standalone]


#1308005 — Re: [PATCH 2/2] crypto: s5p-sss - Use memcpy_toio for iomem annotated memory

FromVladimir Zapolskiy <vz@mleia.com>
Date2016-01-13 04:10 +0100
SubjectRe: [PATCH 2/2] crypto: s5p-sss - Use memcpy_toio for iomem annotated memory
Message-ID<qQjYR-1Vd-9@gated-at.bofh.it>
In reply to#1306107
On 11.01.2016 13:45, Krzysztof Kozlowski wrote:
> Use memcpy_toio to fix following sparse warning:
> 
> drivers/crypto/s5p-sss.c:386:40: warning: incorrect type in argument 1 (different address spaces)
> drivers/crypto/s5p-sss.c:386:40:    expected void *<noident>
> drivers/crypto/s5p-sss.c:386:40:    got void [noderef] <asn:2>*
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
> ---
>  drivers/crypto/s5p-sss.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

With best wishes,
Vladimir

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web