Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1307795 > unrolled thread

Re: [RFC V5] Add gup trace points support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [RFC V5] Add gup trace points support "Shi, Yang" <yang.shi@linaro.org> - 2016-01-12 21:10 +0100
    Re: [RFC V5] Add gup trace points support Steven Rostedt <rostedt@goodmis.org> - 2016-01-12 21:20 +0100
      Re: [RFC V5] Add gup trace points support "Shi, Yang" <yang.shi@linaro.org> - 2016-01-13 19:20 +0100
        Re: [RFC V5] Add gup trace points support Steven Rostedt <rostedt@goodmis.org> - 2016-01-14 15:50 +0100

#1307795 — Re: [RFC V5] Add gup trace points support

Hi Steven,

Any more comments on this series? How should I proceed it?

Thanks,
Yang


On 12/9/2015 1:22 PM, Yang Shi wrote:
> v5:
> * Fixed a typo introduced by v4 rebase
> * Removed redundant "#define CREATE_TRACE_POINTS" from architecture specifc
>    gup.c
>
> v4:
> * Adopted Steven's suggestion to use "unsigned int" for nr_pages to save
>    space in ring buffer since it is unlikely to have more than 0xffffffff
>    pages are touched by gup in one invoke
> * Remove unnecessray type cast
>
> v3:
> * Adopted suggestion from Dave Hansen to move the gup header include to the last
> * Adopted comments from Steven:
>    - Use DECLARE_EVENT_CLASS and DEFINE_EVENT
>    - Just keep necessary TP_ARGS
> * Moved archtichture specific fall-backable fast version trace point after the
>    do while loop since it may jump to the slow version.
> * Not implement recording return value since Steven plans to have it in generic
>    tracing code
>
> v2:
> * Adopted commetns from Steven
>    - remove all reference to tsk->comm since it is unnecessary for non-sched
>      trace points
>    - reduce arguments for __get_user_pages trace point and update mm/gup.c
>      accordingly
> * Added Ralf's acked-by for patch 4/7.
>
>
> Some background about why I think this might be useful.
>
> When I was profiling some hugetlb related program, I got page-faults event
> doubled when hugetlb is enabled. When I looked into the code, I found page-faults
> come from two places, do_page_fault and gup. So, I tried to figure out which
> play a role (or both) in my use case. But I can't find existing finer tracing
> event for sub page-faults in current mainline kernel.
>
> So, I added the gup trace points support to have finer tracing events for
> page-faults. The below events are added:
>
> __get_user_pages
> __get_user_pages_fast
> fixup_user_fault
>
> Both __get_user_pages and fixup_user_fault call handle_mm_fault.
>
> Just added trace points to raw version __get_user_pages since all variants
> will call it finally to do real work.
>
> Although __get_user_pages_fast doesn't call handle_mm_fault, it might be useful
> to have it to distinguish between slow and fast version.
>

[toc] | [next] | [standalone]

#1307799

On Tue, 12 Jan 2016 12:00:54 -0800
"Shi, Yang" <yang.shi@linaro.org> wrote:

> Hi Steven,
> 
> Any more comments on this series? How should I proceed it?
> 

The tracing part looks fine to me. Now you just need to get the arch
maintainers to ack each of the arch patches, and I can pull them in for
4.6. Too late for 4.5. Probably need Andrew Morton's ack for the
mm/gup.c patch.

-- Steve

[toc] | [prev] | [next] | [standalone]

#1308709

On 1/12/2016 12:10 PM, Steven Rostedt wrote:
> On Tue, 12 Jan 2016 12:00:54 -0800
> "Shi, Yang" <yang.shi@linaro.org> wrote:
>
>> Hi Steven,
>>
>> Any more comments on this series? How should I proceed it?
>>
>
> The tracing part looks fine to me. Now you just need to get the arch
> maintainers to ack each of the arch patches, and I can pull them in for
> 4.6. Too late for 4.5. Probably need Andrew Morton's ack for the
> mm/gup.c patch.

Thanks Steven. Already sent email to x86, s390 and sparc maintainers. 
Ralf already acked the MIPS part since v1.

Regards,
Yang

>
> -- Steve
>

[toc] | [prev] | [next] | [standalone]

#1309338

Andrew,

Do you want to pull in this series? You can add my Acked-by to the whole
set.

-- Steve


On Wed, 13 Jan 2016 10:14:24 -0800
"Shi, Yang" <yang.shi@linaro.org> wrote:

> On 1/12/2016 12:10 PM, Steven Rostedt wrote:
> > On Tue, 12 Jan 2016 12:00:54 -0800
> > "Shi, Yang" <yang.shi@linaro.org> wrote:
> >  
> >> Hi Steven,
> >>
> >> Any more comments on this series? How should I proceed it?
> >>  
> >
> > The tracing part looks fine to me. Now you just need to get the arch
> > maintainers to ack each of the arch patches, and I can pull them in for
> > 4.6. Too late for 4.5. Probably need Andrew Morton's ack for the
> > mm/gup.c patch.  
> 
> Thanks Steven. Already sent email to x86, s390 and sparc maintainers. 
> Ralf already acked the MIPS part since v1.
> 
> Regards,
> Yang
> 
> >
> > -- Steve
> >  

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web