Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1307706 > unrolled thread

[RESEND][PATCH] Staging: unisys: fix potential format string leak

Back to article view | Back to linux.kernel

Contents

  [RESEND][PATCH] Staging: unisys: fix potential format string leak Kees Cook <keescook@chromium.org> - 2016-01-12 19:10 +0100

#1307706 — [RESEND][PATCH] Staging: unisys: fix potential format string leak

Since "name" is always used directly, force "%s" for the kthread
format string to avoid any potential format string leaks.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c
index c119f20dfd44..89712144f804 100644
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -167,7 +167,7 @@ static int visor_thread_start(struct visor_thread_info *thrinfo,
 {
 	/* used to stop the thread */
 	init_completion(&thrinfo->has_stopped);
-	thrinfo->task = kthread_run(threadfn, thrcontext, name);
+	thrinfo->task = kthread_run(threadfn, thrcontext, "%s", name);
 	if (IS_ERR(thrinfo->task)) {
 		thrinfo->id = 0;
 		return PTR_ERR(thrinfo->task);
-- 
2.6.3


-- 
Kees Cook
Chrome OS & Brillo Security

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web