Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1307359 > unrolled thread

Re: [PATCH v15 02/25] tools: Make list.h self-sufficient

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v15 02/25] tools: Make list.h self-sufficient Borislav Petkov <bp@alien8.de> - 2016-01-12 13:40 +0100
    Re: [PATCH v15 02/25] tools: Make list.h self-sufficient Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-12 16:00 +0100
      Re: [PATCH v15 02/25] tools: Make list.h self-sufficient Borislav Petkov <bp@alien8.de> - 2016-01-12 17:00 +0100
        Re: [PATCH v15 02/25] tools: Make list.h self-sufficient Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-12 18:20 +0100

#1307359 — Re: [PATCH v15 02/25] tools: Make list.h self-sufficient

On Fri, Dec 18, 2015 at 06:39:16AM -0600, Josh Poimboeuf wrote:
> Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel

nitpick: we like to do this commit quoting style:

  7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")

Checkpatch catches that:

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")'
#21: 
Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel

> version of list.h, which broke the stacktool build because the tools
> list.h includes the kernel list.h.
> 
> Avoid this type of situation in the future and make list.h
> self-sufficient by copying the kernel list.h routines directly into
> tools list.h.
> 
> This is a straight copy except for adjustments to the include statements
> and copying of the tools-specific list routines (list_del_range and
> list_for_each_from).
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
>  tools/include/linux/list.h | 753 ++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 747 insertions(+), 6 deletions(-)

...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

[toc] | [next] | [standalone]

#1307503

Em Tue, Jan 12, 2016 at 01:35:40PM +0100, Borislav Petkov escreveu:
> On Fri, Dec 18, 2015 at 06:39:16AM -0600, Josh Poimboeuf wrote:
> > Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel
> 
> nitpick: we like to do this commit quoting style:
> 
>   7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")
> 
> Checkpatch catches that:
> 
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit 7f5f873c6a07 ("rculist: Use WRITE_ONCE() when deleting from reader-visible list")'
> #21: 
> Commit 7f5f873c6a07 added the use of the WRITE_ONCE macro to the kernel

I'm fixing this up and taking this patch, ok?

- Arnaldo
 
> > version of list.h, which broke the stacktool build because the tools
> > list.h includes the kernel list.h.
> > 
> > Avoid this type of situation in the future and make list.h
> > self-sufficient by copying the kernel list.h routines directly into
> > tools list.h.
> > 
> > This is a straight copy except for adjustments to the include statements
> > and copying of the tools-specific list routines (list_del_range and
> > list_for_each_from).
> > 
> > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> > ---
> >  tools/include/linux/list.h | 753 ++++++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 747 insertions(+), 6 deletions(-)
> 
> ...
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> ECO tip #101: Trim your mails when you reply.

[toc] | [prev] | [next] | [standalone]

#1307580

On Tue, Jan 12, 2016 at 11:54:06AM -0300, Arnaldo Carvalho de Melo wrote:
> I'm fixing this up and taking this patch, ok?

Right, it is better for the whole patchset to go together...

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

[toc] | [prev] | [next] | [standalone]

#1307643

Em Tue, Jan 12, 2016 at 04:59:19PM +0100, Borislav Petkov escreveu:
> On Tue, Jan 12, 2016 at 11:54:06AM -0300, Arnaldo Carvalho de Melo wrote:
> > I'm fixing this up and taking this patch, ok?
> 
> Right, it is better for the whole patchset to go together...

The good thing is for the patchset to be processed, one way or the other
:)

I merged it in my tree, so that it goes thru testing on my side, if it
is merged somewhere else, no problem, git will sort this out easily.

- Arnaldo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web