Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1309253 > unrolled thread
| Started by | Jan Glauber <jan.glauber@gmail.com> |
|---|---|
| First post | 2016-01-14 14:00 +0100 |
| Last post | 2016-01-14 17:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC PATCH 3/5] arm64: dts: Add Cavium ThunderX specific PMU Jan Glauber <jan.glauber@gmail.com> - 2016-01-14 14:00 +0100
Re: [RFC PATCH 3/5] arm64: dts: Add Cavium ThunderX specific PMU Mark Rutland <mark.rutland@arm.com> - 2016-01-14 15:50 +0100
Re: [RFC PATCH 3/5] arm64: dts: Add Cavium ThunderX specific PMU Jan Glauber <jan.glauber@caviumnetworks.com> - 2016-01-14 17:30 +0100
| From | Jan Glauber <jan.glauber@gmail.com> |
|---|---|
| Date | 2016-01-14 14:00 +0100 |
| Subject | [RFC PATCH 3/5] arm64: dts: Add Cavium ThunderX specific PMU |
| Message-ID | <qQPFo-7a4-9@gated-at.bofh.it> |
Add a compatible string for the Cavium ThunderX PMU.
Signed-off-by: Jan Glauber <jglauber@cavium.com>
---
Documentation/devicetree/bindings/arm/pmu.txt | 1 +
arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
index 5651883..9bd0a33 100644
--- a/Documentation/devicetree/bindings/arm/pmu.txt
+++ b/Documentation/devicetree/bindings/arm/pmu.txt
@@ -25,6 +25,7 @@ Required properties:
"qcom,scorpion-pmu"
"qcom,scorpion-mp-pmu"
"qcom,krait-pmu"
+ "cavium,thunderx-pmu"
- interrupts : 1 combined interrupt or 1 per core. If the interrupt is a per-cpu
interrupt (PPI) then 1 interrupt should be specified.
diff --git a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
index 9cb7cf9..84ac556 100644
--- a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
+++ b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
@@ -360,6 +360,11 @@
<1 10 0xff01>;
};
+ pmu {
+ compatible = "cavium,thunderx-pmu", "arm,armv8-pmuv3";
+ interrupts = <1 7 4>;
+ };
+
soc {
compatible = "simple-bus";
#address-cells = <2>;
--
1.9.1
[toc] | [next] | [standalone]
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Date | 2016-01-14 15:50 +0100 |
| Message-ID | <qQRnQ-8rT-7@gated-at.bofh.it> |
| In reply to | #1309253 |
Hi,
As it's the middle of the merge window, it will be a while before this
sees a full review. In future, it would be better to wait until -rc1
before posting new patches (appropriately rebased).
I did spot one thing however.
On Thu, Jan 14, 2016 at 01:55:43PM +0100, Jan Glauber wrote:
> Add a compatible string for the Cavium ThunderX PMU.
>
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
> ---
> Documentation/devicetree/bindings/arm/pmu.txt | 1 +
> arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
> index 5651883..9bd0a33 100644
> --- a/Documentation/devicetree/bindings/arm/pmu.txt
> +++ b/Documentation/devicetree/bindings/arm/pmu.txt
> @@ -25,6 +25,7 @@ Required properties:
> "qcom,scorpion-pmu"
> "qcom,scorpion-mp-pmu"
> "qcom,krait-pmu"
> + "cavium,thunderx-pmu"
> - interrupts : 1 combined interrupt or 1 per core. If the interrupt is a per-cpu
> interrupt (PPI) then 1 interrupt should be specified.
>
> diff --git a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
> index 9cb7cf9..84ac556 100644
> --- a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
> +++ b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
> @@ -360,6 +360,11 @@
> <1 10 0xff01>;
> };
>
> + pmu {
> + compatible = "cavium,thunderx-pmu", "arm,armv8-pmuv3";
In current dts, "cavium,thunder" is used as the CPU compatible string.
Please decide whether you want to call the CPU "Thunder", or
"Thunder-X", and ensure that all compatible strings are consistent.
Please also ansure that any related names exposes to userspace (i.e.
e.g. the PMU name) follow this consistent naming.
Thanks,
Mark.
> + interrupts = <1 7 4>;
> + };
> +
> soc {
> compatible = "simple-bus";
> #address-cells = <2>;
> --
> 1.9.1
>
[toc] | [prev] | [next] | [standalone]
| From | Jan Glauber <jan.glauber@caviumnetworks.com> |
|---|---|
| Date | 2016-01-14 17:30 +0100 |
| Message-ID | <qQSWC-197-27@gated-at.bofh.it> |
| In reply to | #1309339 |
On Thu, Jan 14, 2016 at 02:47:12PM +0000, Mark Rutland wrote:
> Hi,
>
> As it's the middle of the merge window, it will be a while before this
> sees a full review. In future, it would be better to wait until -rc1
> before posting new patches (appropriately rebased).
OK, fair enough. I'll repost after -rc1 if the patches don't fit
anymore.
> I did spot one thing however.
>
> On Thu, Jan 14, 2016 at 01:55:43PM +0100, Jan Glauber wrote:
> > Add a compatible string for the Cavium ThunderX PMU.
> >
> > Signed-off-by: Jan Glauber <jglauber@cavium.com>
> > ---
> > Documentation/devicetree/bindings/arm/pmu.txt | 1 +
> > arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 5 +++++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt
> > index 5651883..9bd0a33 100644
> > --- a/Documentation/devicetree/bindings/arm/pmu.txt
> > +++ b/Documentation/devicetree/bindings/arm/pmu.txt
> > @@ -25,6 +25,7 @@ Required properties:
> > "qcom,scorpion-pmu"
> > "qcom,scorpion-mp-pmu"
> > "qcom,krait-pmu"
> > + "cavium,thunderx-pmu"
> > - interrupts : 1 combined interrupt or 1 per core. If the interrupt is a per-cpu
> > interrupt (PPI) then 1 interrupt should be specified.
> >
> > diff --git a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
> > index 9cb7cf9..84ac556 100644
> > --- a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
> > +++ b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi
> > @@ -360,6 +360,11 @@
> > <1 10 0xff01>;
> > };
> >
> > + pmu {
> > + compatible = "cavium,thunderx-pmu", "arm,armv8-pmuv3";
>
> In current dts, "cavium,thunder" is used as the CPU compatible string.
>
> Please decide whether you want to call the CPU "Thunder", or
> "Thunder-X", and ensure that all compatible strings are consistent.
I think we should keep the already existing name then.
thanks,
Jan
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web