Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1308710 > unrolled thread

Re: [PATCH v5 7/7] sparc64: mm/gup: add gup trace points

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v5 7/7] sparc64: mm/gup: add gup trace points "Shi, Yang" <yang.shi@linaro.org> - 2016-01-13 19:20 +0100
    Re: [PATCH v5 7/7] sparc64: mm/gup: add gup trace points David Miller <davem@davemloft.net> - 2016-01-13 21:30 +0100
      Re: [PATCH v5 7/7] sparc64: mm/gup: add gup trace points Steven Rostedt <rostedt@goodmis.org> - 2016-01-13 21:50 +0100

#1308710 — Re: [PATCH v5 7/7] sparc64: mm/gup: add gup trace points

Hi David,

Any comment on this one? The tracing part review has been done.

Thanks,
Yang


On 12/9/2015 1:22 PM, Yang Shi wrote:
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> ---
>   arch/sparc/mm/gup.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/arch/sparc/mm/gup.c b/arch/sparc/mm/gup.c
> index 2e5c4fc..5a06c34 100644
> --- a/arch/sparc/mm/gup.c
> +++ b/arch/sparc/mm/gup.c
> @@ -12,6 +12,8 @@
>   #include <linux/rwsem.h>
>   #include <asm/pgtable.h>
>
> +#include <trace/events/gup.h>
> +
>   /*
>    * The performance critical leaf functions are made noinline otherwise gcc
>    * inlines everything into a single function which results in too much
> @@ -174,6 +176,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
>   	len = (unsigned long) nr_pages << PAGE_SHIFT;
>   	end = start + len;
>
> +	trace_gup_get_user_pages_fast(start, nr_pages);
> +
>   	local_irq_save(flags);
>   	pgdp = pgd_offset(mm, addr);
>   	do {
> @@ -236,6 +240,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write,
>
>   	local_irq_enable();
>
> +	trace_gup_get_user_pages_fast(start, nr_pages);
> +
>   	VM_BUG_ON(nr != (end - start) >> PAGE_SHIFT);
>   	return nr;
>
>

[toc] | [next] | [standalone]

#1308784

From: "Shi, Yang" <yang.shi@linaro.org>
Date: Wed, 13 Jan 2016 10:13:08 -0800

> Any comment on this one? The tracing part review has been done.

I thought this was going to simply be submitted upstream via
another tree.

If you just want my ack then:

Acked-by: David S. Miller <davem@davemloft.net>

[toc] | [prev] | [next] | [standalone]

#1308795

On Wed, 13 Jan 2016 15:21:38 -0500 (EST)
David Miller <davem@davemloft.net> wrote:

> From: "Shi, Yang" <yang.shi@linaro.org>
> Date: Wed, 13 Jan 2016 10:13:08 -0800
> 
> > Any comment on this one? The tracing part review has been done.  
> 
> I thought this was going to simply be submitted upstream via
> another tree.
> 
> If you just want my ack then:
> 
> Acked-by: David S. Miller <davem@davemloft.net>

Yep, that's what I wanted. Thanks!

-- Steve

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web