Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1307394 > unrolled thread
| Started by | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| First post | 2016-01-12 14:20 +0100 |
| Last post | 2016-01-14 23:40 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-12 14:20 +0100
Re: [PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-14 10:50 +0100
Re: [PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others Matt Fleming <matt@codeblueprint.co.uk> - 2016-01-14 16:50 +0100
Re: [PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-14 23:40 +0100
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2016-01-12 14:20 +0100 |
| Subject | [PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others |
| Message-ID | <qQ71E-1nL-3@gated-at.bofh.it> |
There is one user coming which would like to use those string arrays. It might
be useful for any other user in the future.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/string_helpers.h | 3 +++
lib/string_helpers.c | 21 ++++++++++++---------
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h
index dabe643..1d16240 100644
--- a/include/linux/string_helpers.h
+++ b/include/linux/string_helpers.h
@@ -10,6 +10,9 @@ enum string_size_units {
STRING_UNITS_2, /* use binary powers of 2^10 */
};
+extern const char *const string_units_10[];
+extern const char *const string_units_2[];
+
void string_get_size(u64 size, u64 blk_size, enum string_size_units units,
char *buf, int len);
diff --git a/lib/string_helpers.c b/lib/string_helpers.c
index 5939f63..3a4c812 100644
--- a/lib/string_helpers.c
+++ b/lib/string_helpers.c
@@ -13,6 +13,15 @@
#include <linux/string.h>
#include <linux/string_helpers.h>
+const char * const string_units_10[] = {
+ "B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB",
+};
+EXPORT_SYMBOL(string_units_10);
+const char * const string_units_2[] = {
+ "B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB", "ZiB", "YiB",
+};
+EXPORT_SYMBOL(string_units_2);
+
/**
* string_get_size - get the size in the specified units
* @size: The size to be converted in blocks
@@ -29,15 +38,9 @@
void string_get_size(u64 size, u64 blk_size, const enum string_size_units units,
char *buf, int len)
{
- static const char *const units_10[] = {
- "B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB"
- };
- static const char *const units_2[] = {
- "B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB", "ZiB", "YiB"
- };
static const char *const *const units_str[] = {
- [STRING_UNITS_10] = units_10,
- [STRING_UNITS_2] = units_2,
+ [STRING_UNITS_10] = string_units_10,
+ [STRING_UNITS_2] = string_units_2,
};
static const unsigned int divisor[] = {
[STRING_UNITS_10] = 1000,
@@ -92,7 +95,7 @@ void string_get_size(u64 size, u64 blk_size, const enum string_size_units units,
}
out:
- if (i >= ARRAY_SIZE(units_2))
+ if (i >= ARRAY_SIZE(string_units_2))
unit = "UNK";
else
unit = units_str[units][i];
--
2.6.4
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Date | 2016-01-14 10:50 +0100 |
| Subject | Re: [PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others |
| Message-ID | <qQMHw-59v-1@gated-at.bofh.it> |
| In reply to | #1307394 |
On Tue, 2016-01-12 at 15:13 +0200, Andy Shevchenko wrote:
> There is one user coming which would like to use those string arrays.
> It might
> be useful for any other user in the future.
Please, comment on the idea, but discard both patches, I'm cooking
better approach.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/linux/string_helpers.h | 3 +++
> lib/string_helpers.c | 21 ++++++++++++---------
> 2 files changed, 15 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/string_helpers.h
> b/include/linux/string_helpers.h
> index dabe643..1d16240 100644
> --- a/include/linux/string_helpers.h
> +++ b/include/linux/string_helpers.h
> @@ -10,6 +10,9 @@ enum string_size_units {
> STRING_UNITS_2, /* use binary powers of 2^10
> */
> };
>
> +extern const char *const string_units_10[];
> +extern const char *const string_units_2[];
> +
> void string_get_size(u64 size, u64 blk_size, enum string_size_units
> units,
> char *buf, int len);
>
> diff --git a/lib/string_helpers.c b/lib/string_helpers.c
> index 5939f63..3a4c812 100644
> --- a/lib/string_helpers.c
> +++ b/lib/string_helpers.c
> @@ -13,6 +13,15 @@
> #include <linux/string.h>
> #include <linux/string_helpers.h>
>
> +const char * const string_units_10[] = {
> + "B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB",
> +};
> +EXPORT_SYMBOL(string_units_10);
> +const char * const string_units_2[] = {
> + "B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB", "ZiB", "YiB",
> +};
> +EXPORT_SYMBOL(string_units_2);
> +
> /**
> * string_get_size - get the size in the specified units
> * @size: The size to be converted in blocks
> @@ -29,15 +38,9 @@
> void string_get_size(u64 size, u64 blk_size, const enum
> string_size_units units,
> char *buf, int len)
> {
> - static const char *const units_10[] = {
> - "B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB"
> - };
> - static const char *const units_2[] = {
> - "B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB",
> "ZiB", "YiB"
> - };
> static const char *const *const units_str[] = {
> - [STRING_UNITS_10] = units_10,
> - [STRING_UNITS_2] = units_2,
> + [STRING_UNITS_10] = string_units_10,
> + [STRING_UNITS_2] = string_units_2,
> };
> static const unsigned int divisor[] = {
> [STRING_UNITS_10] = 1000,
> @@ -92,7 +95,7 @@ void string_get_size(u64 size, u64 blk_size, const
> enum string_size_units units,
> }
>
> out:
> - if (i >= ARRAY_SIZE(units_2))
> + if (i >= ARRAY_SIZE(string_units_2))
> unit = "UNK";
> else
> unit = units_str[units][i];
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
[toc] | [prev] | [next] | [standalone]
| From | Matt Fleming <matt@codeblueprint.co.uk> |
|---|---|
| Date | 2016-01-14 16:50 +0100 |
| Subject | Re: [PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others |
| Message-ID | <qQSjU-Dz-13@gated-at.bofh.it> |
| In reply to | #1309120 |
On Thu, 14 Jan, at 11:45:05AM, Andy Shevchenko wrote: > On Tue, 2016-01-12 at 15:13 +0200, Andy Shevchenko wrote: > > There is one user coming which would like to use those string arrays. > > It might > > be useful for any other user in the future. > > Please, comment on the idea, but discard both patches, I'm cooking > better approach. I like this idea. I'm all for reusing existing code where possible.
[toc] | [prev] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2016-01-14 23:40 +0100 |
| Message-ID | <qQYIG-5f6-15@gated-at.bofh.it> |
| In reply to | #1309439 |
On Thu, Jan 14, 2016 at 5:44 PM, Matt Fleming <matt@codeblueprint.co.uk> wrote: > On Thu, 14 Jan, at 11:45:05AM, Andy Shevchenko wrote: >> On Tue, 2016-01-12 at 15:13 +0200, Andy Shevchenko wrote: >> > There is one user coming which would like to use those string arrays. >> > It might >> > be useful for any other user in the future. >> >> Please, comment on the idea, but discard both patches, I'm cooking >> better approach. > > I like this idea. I'm all for reusing existing code where possible. Just sent v2. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web