Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1304249 > unrolled thread
| Started by | Alexander Kuleshov <kuleshovmail@gmail.com> |
|---|---|
| First post | 2016-01-08 09:10 +0100 |
| Last post | 2016-01-11 15:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mm/page_alloc: remove unused struct zone *z variable Alexander Kuleshov <kuleshovmail@gmail.com> - 2016-01-08 09:10 +0100
Re: [PATCH] mm/page_alloc: remove unused struct zone *z variable "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-01-09 00:40 +0100
Re: [PATCH] mm/page_alloc: remove unused struct zone *z variable Vlastimil Babka <vbabka@suse.cz> - 2016-01-11 15:00 +0100
| From | Alexander Kuleshov <kuleshovmail@gmail.com> |
|---|---|
| Date | 2016-01-08 09:10 +0100 |
| Subject | [PATCH] mm/page_alloc: remove unused struct zone *z variable |
| Message-ID | <qOAhr-3X1-11@gated-at.bofh.it> |
This patch removes unused struct zone *z variable which is
appeared in 86051ca5eaf5 (mm: fix usemap initialization)
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
mm/page_alloc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 9d666df..9bde098 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -4471,13 +4471,11 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
pg_data_t *pgdat = NODE_DATA(nid);
unsigned long end_pfn = start_pfn + size;
unsigned long pfn;
- struct zone *z;
unsigned long nr_initialised = 0;
if (highest_memmap_pfn < end_pfn - 1)
highest_memmap_pfn = end_pfn - 1;
- z = &pgdat->node_zones[zone];
for (pfn = start_pfn; pfn < end_pfn; pfn++) {
/*
* There can be holes in boot-time mem_map[]s
--
2.6.2.485.g1bc8fea
[toc] | [next] | [standalone]
| From | "Kirill A. Shutemov" <kirill@shutemov.name> |
|---|---|
| Date | 2016-01-09 00:40 +0100 |
| Message-ID | <qOONs-5sr-15@gated-at.bofh.it> |
| In reply to | #1304249 |
On Fri, Jan 08, 2016 at 01:59:08PM +0600, Alexander Kuleshov wrote:
> This patch removes unused struct zone *z variable which is
> appeared in 86051ca5eaf5 (mm: fix usemap initialization)
I guess it's a fix for 1e8ce83cd17f (mm: meminit: move page initialization
into a separate function).
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> mm/page_alloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 9d666df..9bde098 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -4471,13 +4471,11 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
> pg_data_t *pgdat = NODE_DATA(nid);
> unsigned long end_pfn = start_pfn + size;
> unsigned long pfn;
> - struct zone *z;
> unsigned long nr_initialised = 0;
>
> if (highest_memmap_pfn < end_pfn - 1)
> highest_memmap_pfn = end_pfn - 1;
>
> - z = &pgdat->node_zones[zone];
> for (pfn = start_pfn; pfn < end_pfn; pfn++) {
> /*
> * There can be holes in boot-time mem_map[]s
> --
> 2.6.2.485.g1bc8fea
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
Kirill A. Shutemov
[toc] | [prev] | [next] | [standalone]
| From | Vlastimil Babka <vbabka@suse.cz> |
|---|---|
| Date | 2016-01-11 15:00 +0100 |
| Message-ID | <qPLaR-38k-61@gated-at.bofh.it> |
| In reply to | #1305087 |
On 01/09/2016 12:29 AM, Kirill A. Shutemov wrote:
> On Fri, Jan 08, 2016 at 01:59:08PM +0600, Alexander Kuleshov wrote:
>> This patch removes unused struct zone *z variable which is
>> appeared in 86051ca5eaf5 (mm: fix usemap initialization)
>
> I guess it's a fix for 1e8ce83cd17f (mm: meminit: move page initialization
> into a separate function).
Yeah but it's not a bug, so a tag like that would be just noise.
>>
>> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
>> ---
>> mm/page_alloc.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 9d666df..9bde098 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -4471,13 +4471,11 @@ void __meminit memmap_init_zone(unsigned long size, int nid, unsigned long zone,
>> pg_data_t *pgdat = NODE_DATA(nid);
>> unsigned long end_pfn = start_pfn + size;
>> unsigned long pfn;
>> - struct zone *z;
>> unsigned long nr_initialised = 0;
>>
>> if (highest_memmap_pfn < end_pfn - 1)
>> highest_memmap_pfn = end_pfn - 1;
>>
>> - z = &pgdat->node_zones[zone];
>> for (pfn = start_pfn; pfn < end_pfn; pfn++) {
>> /*
>> * There can be holes in boot-time mem_map[]s
>> --
>> 2.6.2.485.g1bc8fea
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web