Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1306025 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2016-01-11 11:30 +0100 |
| Last post | 2016-01-12 08:40 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 6/9] mfd: add TI LMU hardware fault monitoring driver Lee Jones <lee.jones@linaro.org> - 2016-01-11 11:30 +0100
Re: [PATCH v2 6/9] mfd: add TI LMU hardware fault monitoring driver Milo Kim <milo.kim@ti.com> - 2016-01-12 04:40 +0100
Re: [PATCH v2 6/9] mfd: add TI LMU hardware fault monitoring driver Lee Jones <lee.jones@linaro.org> - 2016-01-12 08:40 +0100
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-01-11 11:30 +0100 |
| Subject | Re: [PATCH v2 6/9] mfd: add TI LMU hardware fault monitoring driver |
| Message-ID | <qPHTB-Yo-41@gated-at.bofh.it> |
On Thu, 26 Nov 2015, Milo Kim wrote: > LM3633 and LM3697 are TI LMU MFD device. > Those devices have hardware monitoring feature which detects open or > short circuit case. > > Debugfs > ------- > Two files are created. > open_fault: check light output channel is open or not. > short_fault: check light output channel is shorted or not. > > The driver checks the status of backlight output channels. > LM3633 and LM3697 have same sequence to check channels, so common > functions are used. > ABI/testing document is also included. > > Operations > ---------- > Two devices have common control flow but register addresses are different. > The structure, 'ti_lmu_reg' is used for register configuration. > > Event notifier > -------------- > After fault monitoring is done, LMU device is reset. So backlight and > LED device should be reinitialized. It notifies an event as soon as > the monitoring is done. Then, LM3633 and LM3697 backlight and LED drivers > handle this event. > > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Jacek Anaszewski <j.anaszewski@samsung.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: devicetree@vger.kernel.org > Cc: linux-leds@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Milo Kim <milo.kim@ti.com> > --- > .../ABI/testing/debugfs-ti-lmu-fault-monitor | 32 ++ > drivers/mfd/Kconfig | 10 + > drivers/mfd/Makefile | 1 + > drivers/mfd/ti-lmu-fault-monitor.c | 405 +++++++++++++++++++++ I think this device is part of the MFD, rather than an MFD itself. Please relocate it to somewhere more appropriate. > 4 files changed, 448 insertions(+) > create mode 100644 Documentation/ABI/testing/debugfs-ti-lmu-fault-monitor > create mode 100644 drivers/mfd/ti-lmu-fault-monitor.c [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [next] | [standalone]
| From | Milo Kim <milo.kim@ti.com> |
|---|---|
| Date | 2016-01-12 04:40 +0100 |
| Message-ID | <qPXYm-3Gv-5@gated-at.bofh.it> |
| In reply to | #1306025 |
On 01/11/2016 07:21 PM, Lee Jones wrote: > On Thu, 26 Nov 2015, Milo Kim wrote: > >> LM3633 and LM3697 are TI LMU MFD device. >> Those devices have hardware monitoring feature which detects open or >> short circuit case. >> >> Debugfs >> ------- >> Two files are created. >> open_fault: check light output channel is open or not. >> short_fault: check light output channel is shorted or not. >> >> The driver checks the status of backlight output channels. >> LM3633 and LM3697 have same sequence to check channels, so common >> functions are used. >> ABI/testing document is also included. >> >> Operations >> ---------- >> Two devices have common control flow but register addresses are different. >> The structure, 'ti_lmu_reg' is used for register configuration. >> >> Event notifier >> -------------- >> After fault monitoring is done, LMU device is reset. So backlight and >> LED device should be reinitialized. It notifies an event as soon as >> the monitoring is done. Then, LM3633 and LM3697 backlight and LED drivers >> handle this event. >> >> Cc: Lee Jones <lee.jones@linaro.org> >> Cc: Jacek Anaszewski <j.anaszewski@samsung.com> >> Cc: Mark Brown <broonie@kernel.org> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: devicetree@vger.kernel.org >> Cc: linux-leds@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Milo Kim <milo.kim@ti.com> >> --- >> .../ABI/testing/debugfs-ti-lmu-fault-monitor | 32 ++ >> drivers/mfd/Kconfig | 10 + >> drivers/mfd/Makefile | 1 + >> drivers/mfd/ti-lmu-fault-monitor.c | 405 +++++++++++++++++++++ > > I think this device is part of the MFD, rather than an MFD itself. > Please relocate it to somewhere more appropriate. Actually, initial patch driver was created under 'drivers/hwmon/' but HWMON maintainer pointed this driver doesn't include HW sensor feature. So I moved here. This driver doesn't need any subsystem infrastructure, 'drivers/misc/' could be OK. Does it make sense? Best regards, Milo
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-01-12 08:40 +0100 |
| Message-ID | <qQ1IC-6a2-9@gated-at.bofh.it> |
| In reply to | #1306966 |
On Tue, 12 Jan 2016, Milo Kim wrote: > On 01/11/2016 07:21 PM, Lee Jones wrote: > >On Thu, 26 Nov 2015, Milo Kim wrote: > > > >>LM3633 and LM3697 are TI LMU MFD device. > >>Those devices have hardware monitoring feature which detects open or > >>short circuit case. > >> > >>Debugfs > >>------- > >> Two files are created. > >> open_fault: check light output channel is open or not. > >> short_fault: check light output channel is shorted or not. > >> > >> The driver checks the status of backlight output channels. > >> LM3633 and LM3697 have same sequence to check channels, so common > >> functions are used. > >> ABI/testing document is also included. > >> > >>Operations > >>---------- > >> Two devices have common control flow but register addresses are different. > >> The structure, 'ti_lmu_reg' is used for register configuration. > >> > >>Event notifier > >>-------------- > >> After fault monitoring is done, LMU device is reset. So backlight and > >> LED device should be reinitialized. It notifies an event as soon as > >> the monitoring is done. Then, LM3633 and LM3697 backlight and LED drivers > >> handle this event. > >> > >>Cc: Lee Jones <lee.jones@linaro.org> > >>Cc: Jacek Anaszewski <j.anaszewski@samsung.com> > >>Cc: Mark Brown <broonie@kernel.org> > >>Cc: Rob Herring <robh+dt@kernel.org> > >>Cc: devicetree@vger.kernel.org > >>Cc: linux-leds@vger.kernel.org > >>Cc: linux-kernel@vger.kernel.org > >>Signed-off-by: Milo Kim <milo.kim@ti.com> > >>--- > >> .../ABI/testing/debugfs-ti-lmu-fault-monitor | 32 ++ > >> drivers/mfd/Kconfig | 10 + > >> drivers/mfd/Makefile | 1 + > >> drivers/mfd/ti-lmu-fault-monitor.c | 405 +++++++++++++++++++++ > > > >I think this device is part of the MFD, rather than an MFD itself. > >Please relocate it to somewhere more appropriate. > > Actually, initial patch driver was created under 'drivers/hwmon/' > but HWMON maintainer pointed this driver doesn't include HW sensor > feature. > So I moved here. > > This driver doesn't need any subsystem infrastructure, > 'drivers/misc/' could be OK. Does it make sense? Either drivers/misc or drivers/platform I guess. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web