Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1305962 > unrolled thread
| Started by | Manjeet Pawar <manjeet.p@samsung.com> |
|---|---|
| First post | 2016-01-11 10:10 +0100 |
| Last post | 2016-01-11 23:50 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well. Manjeet Pawar <manjeet.p@samsung.com> - 2016-01-11 10:10 +0100
Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well. Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-01-11 15:20 +0100
Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well. Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-01-11 16:20 +0100
Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well. David Miller <davem@davemloft.net> - 2016-01-11 23:50 +0100
| From | Manjeet Pawar <manjeet.p@samsung.com> |
|---|---|
| Date | 2016-01-11 10:10 +0100 |
| Subject | [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well. |
| Message-ID | <qPGEa-eD-9@gated-at.bofh.it> |
This patch enable network driver support for ARM64 Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com> Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com> --- drivers/net/ethernet/smsc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig index eb9230e..6e73c73 100644 --- a/drivers/net/ethernet/smsc/Kconfig +++ b/drivers/net/ethernet/smsc/Kconfig @@ -77,7 +77,7 @@ config SMC911X tristate "SMSC LAN911[5678] support" select CRC32 select MII - depends on (ARM || SUPERH || MN10300) + depends on (ARM || ARM64 || SUPERH || MN10300) ---help--- This is a driver for SMSC's LAN911x series of Ethernet chipsets including the new LAN9115, LAN9116, LAN9117, and LAN9118. -- 1.7.9.5
[toc] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2016-01-11 15:20 +0100 |
| Message-ID | <qPLua-3uR-9@gated-at.bofh.it> |
| In reply to | #1305962 |
Hello.
On 01/11/2016 12:02 PM, Manjeet Pawar wrote:
> This patch enable network driver support for ARM64
>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com>
> ---
> drivers/net/ethernet/smsc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig
> index eb9230e..6e73c73 100644
> --- a/drivers/net/ethernet/smsc/Kconfig
> +++ b/drivers/net/ethernet/smsc/Kconfig
> @@ -77,7 +77,7 @@ config SMC911X
> tristate "SMSC LAN911[5678] support"
> select CRC32
> select MII
> - depends on (ARM || SUPERH || MN10300)
> + depends on (ARM || ARM64 || SUPERH || MN10300)
Could as well drop useless parens...
[...]
MBR, Sergei
[toc] | [prev] | [next] | [standalone]
| From | Paul Gortmaker <paul.gortmaker@windriver.com> |
|---|---|
| Date | 2016-01-11 16:20 +0100 |
| Message-ID | <qPMqe-46s-21@gated-at.bofh.it> |
| In reply to | #1305962 |
On 2016-01-11 04:02 AM, Manjeet Pawar wrote: > This patch enable network driver support for ARM64 Your commit log only repeats what is obvious from the one line change itself. It might be nice to indicate what platform it was validated on, what tests were run and what features of the driver were exercised (multicast, netpoll, ...) Imagine if I sent you a similar patch where I added MIPS and said nothing more than "enable network driver support for MIPS" and Cc'd you expecting you to comment on whether it was OK. Thanks, Paul. -- > > Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com> > Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com> > --- > drivers/net/ethernet/smsc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/smsc/Kconfig b/drivers/net/ethernet/smsc/Kconfig > index eb9230e..6e73c73 100644 > --- a/drivers/net/ethernet/smsc/Kconfig > +++ b/drivers/net/ethernet/smsc/Kconfig > @@ -77,7 +77,7 @@ config SMC911X > tristate "SMSC LAN911[5678] support" > select CRC32 > select MII > - depends on (ARM || SUPERH || MN10300) > + depends on (ARM || ARM64 || SUPERH || MN10300) > ---help--- > This is a driver for SMSC's LAN911x series of Ethernet chipsets > including the new LAN9115, LAN9116, LAN9117, and LAN9118. >
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-01-11 23:50 +0100 |
| Subject | Re: [PATCH 1/1] smsc: Enabling SMSC LAN911 driver for ARM64 as well. |
| Message-ID | <qPTrI-rQ-7@gated-at.bofh.it> |
| In reply to | #1305962 |
From: Manjeet Pawar <manjeet.p@samsung.com> Date: Mon, 11 Jan 2016 14:32:25 +0530 > This patch enable network driver support for ARM64 > > Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com> > Signed-off-by: Manjeet Pawar <manjeet.p@samsung.com> There is no _WAY_ this is valid. This driver casts skb->data pointers to "u32" integers and then casts it back to a pointer and proceeds to dereference that pointer. I don't think you even looked at the build when trying to compile this on a 64-bit machine. That makes me have absolutely no confidence in the changes you submit to me.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web