Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305216 > unrolled thread

[PATCH] mm/memblock: If nr_new is 0 just return

Back to article view | Back to linux.kernel

Contents

  [PATCH] mm/memblock: If nr_new is 0 just return nimisolo <nimisolo@gmail.com> - 2016-01-09 12:40 +0100
    Re: [PATCH] mm/memblock: If nr_new is 0 just return Andrew Morton <akpm@linux-foundation.org> - 2016-01-12 23:50 +0100

#1305216 — [PATCH] mm/memblock: If nr_new is 0 just return

If nr_new is 0 which means there's no region would be added,
so just return to the caller.

Signed-off-by: nimisolo <nimisolo@gmail.com>
---
 mm/memblock.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/memblock.c b/mm/memblock.c
index d300f13..9a30077 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -588,6 +588,9 @@ repeat:
 					       nid, flags);
 	}
 
+	if (!nr_new)
+		return 0;
+
 	/*
 	 * If this was the first round, resize array and repeat for actual
 	 * insertions; otherwise, merge and return.
-- 
2.5.0

[toc] | [next] | [standalone]

#1307899

On Sat,  9 Jan 2016 06:33:40 -0500 nimisolo <nimisolo@gmail.com> wrote:

> If nr_new is 0 which means there's no region would be added,
> so just return to the caller.
> 
> ...
>
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -588,6 +588,9 @@ repeat:
>  					       nid, flags);
>  	}
>  
> +	if (!nr_new)
> +		return 0;
> +
>  	/*
>  	 * If this was the first round, resize array and repeat for actual
>  	 * insertions; otherwise, merge and return.

hm, why?  Is there something actually wrong with the current code?

Under what circumstances does nr_new==0 actually happen?  Is it a bug
in the caller?

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web